[Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[James Hilliard]

README.md hash changed due to syntax fix:
https://github.com/systemd/systemd-stable/commit/49ddb4757b197b303309b0dcdfc5f858f4b8e168

Remove no longer supported/required valgrind config option.

Disable new unsupported passwdqc config option.

Disable new unsupported ukify config option.

Disable new unsupported xenctrl config option.

Update systemd-boot config options to new format.

Add new host-python-pyelftools systemd-boot dependency.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/systemd/systemd.hash |  4 ++--
 package/systemd/systemd.mk   | 29 ++++++++++++-----------------
 2 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/package/systemd/systemd.hash b/package/systemd/systemd.hash
index 00c08edcd9..10f4bc04fa 100644
--- a/package/systemd/systemd.hash
+++ b/package/systemd/systemd.hash
@@ -1,5 +1,5 @@
 # sha256 locally computed
-sha256  cf2d27e67663d599a045101c7178cf0ec63d9df2962a54adf7de0d0357724f00  systemd-252.4.tar.gz
+sha256  18db69c8fc33afebf95a40cfa3769df5f0e4a07bccdebd33b2fd81c8b75e7a02  systemd-254.tar.gz
 sha256  ab15fd526bd8dd18a9e77ebc139656bf4d33e97fc7238cd11bf60e2b9b8666c6  LICENSE.GPL2
 sha256  dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  LICENSE.LGPL2.1
 sha256  e5a8645ad94aab24e312dd0c6be2aa54236eb9374480b1b14ea5c61598874fd5  LICENSES/BSD-2-Clause.txt
@@ -12,4 +12,4 @@ sha256  8a6fc0879cecc0b96bf4c08159b9d733bf0f15fcf32879aec98c4ffd05424554  LICENS
 sha256  b85dcd3e453d05982552c52b5fc9e0bdd6d23c6f8e844b984a88af32570b0cc0  LICENSES/MIT.txt
 sha256  2a98749f6bec00dfaed86fa9c1edea871aaae4f11ee4d100b671aaf4ce353a73  LICENSES/murmurhash2-public-domain.txt
 sha256  1a7adaa2c86cedfd6c7f5c0c7c72fd6d3e02cd0c9593f21fdb53c89bb2b130ec  LICENSES/OFL-1.1.txt
-sha256  da9b2c7b8cd10516fd2c4279b82496ea61787148f13e899c62fc8988c5fac34f  LICENSES/README.md
+sha256  8ccb649d1fc1103e5726612cf303f05d4eb86b7ab46d9f630009dd32e87612e2  LICENSES/README.md
diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
index 63467171ed..0aa1da3fb8 100644
--- a/package/systemd/systemd.mk
+++ b/package/systemd/systemd.mk
@@ -19,7 +19,7 @@
 # - Diff sysusers.d with the previous version
 # - Diff factory/etc/nsswitch.conf with the previous version
 #   (details are often sprinkled around in README and manpages)
-SYSTEMD_VERSION = 252.4
+SYSTEMD_VERSION = 254
 SYSTEMD_SITE = $(call github,systemd,systemd-stable,v$(SYSTEMD_VERSION))
 SYSTEMD_LICENSE = \
 	LGPL-2.1+, \
@@ -82,6 +82,7 @@ SYSTEMD_CONF_OPTS += \
 	-Dmode=release \
 	-Dnspawn-locale='C.UTF-8' \
 	-Dnss-systemd=true \
+	-Dpasswdqc=false \
 	-Dquotacheck-path=/usr/sbin/quotacheck \
 	-Dquotaon-path=/usr/sbin/quotaon \
 	-Drootlibdir='/usr/lib' \
@@ -96,7 +97,9 @@ SYSTEMD_CONF_OPTS += \
 	-Dtelinit-path= \
 	-Dtests=false \
 	-Dtmpfiles=true \
-	-Dumount-path=/usr/bin/umount
+	-Dukify=false \
+	-Dumount-path=/usr/bin/umount \
+	-Dxenctrl=false
 
 SYSTEMD_CFLAGS = $(TARGET_CFLAGS)
 ifeq ($(BR2_OPTIMIZE_FAST),y)
@@ -215,13 +218,6 @@ else
 SYSTEMD_CONF_OPTS += -Dfdisk=false
 endif
 
-ifeq ($(BR2_PACKAGE_VALGRIND),y)
-SYSTEMD_DEPENDENCIES += valgrind
-SYSTEMD_CONF_OPTS += -Dvalgrind=true
-else
-SYSTEMD_CONF_OPTS += -Dvalgrind=false
-endif
-
 ifeq ($(BR2_PACKAGE_XZ),y)
 SYSTEMD_DEPENDENCIES += xz
 SYSTEMD_CONF_OPTS += -Dxz=true
@@ -575,13 +571,8 @@ endif
 
 ifeq ($(BR2_PACKAGE_SYSTEMD_BOOT),y)
 SYSTEMD_INSTALL_IMAGES = YES
-SYSTEMD_DEPENDENCIES += gnu-efi
-SYSTEMD_CONF_OPTS += \
-	-Defi=true \
-	-Dgnu-efi=true \
-	-Defi-ld=bfd \
-	-Defi-libdir=$(STAGING_DIR)/usr/lib \
-	-Defi-includedir=$(STAGING_DIR)/usr/include/efi
+SYSTEMD_DEPENDENCIES += gnu-efi host-python-pyelftools
+SYSTEMD_CONF_OPTS += -Defi=true -Dbootloader=true
 
 SYSTEMD_BOOT_EFI_ARCH = $(call qstrip,$(BR2_PACKAGE_SYSTEMD_BOOT_EFI_ARCH))
 define SYSTEMD_INSTALL_BOOT_FILES
@@ -594,7 +585,7 @@ define SYSTEMD_INSTALL_BOOT_FILES
 endef
 
 else
-SYSTEMD_CONF_OPTS += -Defi=false -Dgnu-efi=false
+SYSTEMD_CONF_OPTS += -Defi=false -Dbootloader=false
 endif # BR2_PACKAGE_SYSTEMD_BOOT == y
 
 SYSTEMD_FALLBACK_HOSTNAME = $(call qstrip,$(BR2_TARGET_GENERIC_HOSTNAME))
@@ -812,6 +803,7 @@ HOST_SYSTEMD_CONF_OPTS = \
 	-Dhibernate=false \
 	-Dldconfig=false \
 	-Dresolve=false \
+	-Dbootloader=false \
 	-Defi=false \
 	-Dtpm=false \
 	-Denvironment-d=false \
@@ -826,6 +818,7 @@ HOST_SYSTEMD_CONF_OPTS = \
 	-Dhostnamed=false \
 	-Dlocaled=false \
 	-Dmachined=false \
+	-Dpasswdqc=false \
 	-Dportabled=false \
 	-Dsysext=false \
 	-Dsysupdate=false \
@@ -868,9 +861,11 @@ HOST_SYSTEMD_CONF_OPTS = \
 	-Dinitrd=false \
 	-Dxdg-autostart=false \
 	-Dkernel-install=false \
+	-Dukify=false \
 	-Danalyze=false \
 	-Dlibcryptsetup=false \
 	-Daudit=false \
+	-Dxenctrl=false \
 	-Dzstd=false
 
 HOST_SYSTEMD_DEPENDENCIES = \
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[Thomas Petazzoni via buildroot]

On Sat, 29 Jul 2023 00:56:16 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> README.md hash changed due to syntax fix:
> https://github.com/systemd/systemd-stable/commit/49ddb4757b197b303309b0dcdfc5f858f4b8e168
> 
> Remove no longer supported/required valgrind config option.
> 
> Disable new unsupported passwdqc config option.
> 
> Disable new unsupported ukify config option.
> 
> Disable new unsupported xenctrl config option.
> 
> Update systemd-boot config options to new format.
> 
> Add new host-python-pyelftools systemd-boot dependency.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/systemd/systemd.hash |  4 ++--
>  package/systemd/systemd.mk   | 29 ++++++++++++-----------------
>  2 files changed, 14 insertions(+), 19 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[Thomas Petazzoni via buildroot]

Hello James,

On Sat, 29 Jul 2023 00:56:16 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> README.md hash changed due to syntax fix:
> https://github.com/systemd/systemd-stable/commit/49ddb4757b197b303309b0dcdfc5f858f4b8e168
> 
> Remove no longer supported/required valgrind config option.
> 
> Disable new unsupported passwdqc config option.
> 
> Disable new unsupported ukify config option.
> 
> Disable new unsupported xenctrl config option.
> 
> Update systemd-boot config options to new format.
> 
> Add new host-python-pyelftools systemd-boot dependency.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/systemd/systemd.hash |  4 ++--
>  package/systemd/systemd.mk   | 29 ++++++++++++-----------------
>  2 files changed, 14 insertions(+), 19 deletions(-)

I am getting back to you regarding this version bump. Did you run the
systemd test cases in supporting/testing after doing this version bump?

Indeed, it seems like the systemd test cases are no broken. See
https://gitlab.com/buildroot.org/buildroot/-/pipelines/950175077/failures
for the full list of failed cases (a number are not systemd related,
and not relevant here, but many are systemd related).

I looked at only one, and the failure happens at runtime and goes like
this:

# systemctl --no-pager --failed --no-legend
● systemd-vconsole-setup.service loaded failed failed Virtual Console Setup
# echo $?
0

I haven't checked the other failures. Could you have a look at fix the
issue?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[Yann E. MORIN]

James, All,

On 2023-07-31 21:20 +0200, Thomas Petazzoni via buildroot spake thusly:
> On Sat, 29 Jul 2023 00:56:16 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
> >  package/systemd/systemd.hash |  4 ++--
> >  package/systemd/systemd.mk   | 29 ++++++++++++-----------------
> >  2 files changed, 14 insertions(+), 19 deletions(-)
> I am getting back to you regarding this version bump. Did you run the
> systemd test cases in supporting/testing after doing this version bump?
> 
> Indeed, it seems like the systemd test cases are no broken. See
> https://gitlab.com/buildroot.org/buildroot/-/pipelines/950175077/failures
> for the full list of failed cases (a number are not systemd related,
> and not relevant here, but many are systemd related).
> 
> I looked at only one, and the failure happens at runtime and goes like
> this:
> 
> # systemctl --no-pager --failed --no-legend
> ● systemd-vconsole-setup.service loaded failed failed Virtual Console Setup

    # journalctl -u systemd-vconsole-setup.service
    Jul 31 20:21:04 buildroot systemd-vconsole-setup[129]: /usr/bin/loadkeys failed with exit status 1.

So it looks like it needs kbd (for loadkeys). v252 already did, so it
would be interesting to also understand why it did not fail then, while
it fails now.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/systemd: bump to version 254

[Romain Naour]

Hello James, Thomas, Yann, All,

Le 31/07/2023 à 21:20, Thomas Petazzoni a écrit :
> Hello James,
> 
> On Sat, 29 Jul 2023 00:56:16 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
> 
>> README.md hash changed due to syntax fix:
>> https://github.com/systemd/systemd-stable/commit/49ddb4757b197b303309b0dcdfc5f858f4b8e168
>>
>> Remove no longer supported/required valgrind config option.
>>
>> Disable new unsupported passwdqc config option.
>>
>> Disable new unsupported ukify config option.
>>
>> Disable new unsupported xenctrl config option.
>>
>> Update systemd-boot config options to new format.
>>
>> Add new host-python-pyelftools systemd-boot dependency.
>>
>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>> ---
>>  package/systemd/systemd.hash |  4 ++--
>>  package/systemd/systemd.mk   | 29 ++++++++++++-----------------
>>  2 files changed, 14 insertions(+), 19 deletions(-)
> 
> I am getting back to you regarding this version bump. Did you run the
> systemd test cases in supporting/testing after doing this version bump?
> 
> Indeed, it seems like the systemd test cases are no broken. See
> https://gitlab.com/buildroot.org/buildroot/-/pipelines/950175077/failures
> for the full list of failed cases (a number are not systemd related,
> and not relevant here, but many are systemd related).
> 
> I looked at only one, and the failure happens at runtime and goes like
> this:
> 
> # systemctl --no-pager --failed --no-legend
> ● systemd-vconsole-setup.service loaded failed failed Virtual Console Setup
> # echo $?
> 0
> 
> I haven't checked the other failures. Could you have a look at fix the
> issue?

There is one (hopefully) remaining issue related to systemd v254

https://gitlab.com/buildroot.org/buildroot/-/jobs/4768561464 (TestPolkitSystemd)

Something changed in systemd because the return code of "su brtest -c
'/bin/systemctl restart systemd-timesyncd.service" changed from 1 to 4.

Indeed, the log seems different:

systemd v253:
Failed to restart systemd-timesyncd.service: Interactive authentication required.

systemd v254:
Failed to restart systemd-timesyncd.service: Access denied

git bisect report this commit:
https://github.com/systemd/systemd/commit/959301cf9f42418314abf027183dc25c08731b82

From the PR (to get more context):
https://github.com/systemd/systemd/pull/26365

I'm not sure if it's expected or not..

Otherwise we have to do a "one character change" in TestPolkitSystemd:

  cmd = "su brtest -c '/bin/systemctl restart systemd-timesyncd.service'"
  _, exit_code = self.emulator.run(cmd, 10)
  self.assertEqual(exit_code, 1)
                             ^^^
update to 4 ?

Best regards,
Romain


> 
> Thanks a lot!
> 
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot