From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/x11r7/xapp_xfd: disable gettext detection when not needed
Date: Sun, 30 Jul 2023 00:40:40 +0200 [thread overview]
Message-ID: <20230730004040.0d0e8127@windsurf> (raw)
In-Reply-To: <20230614173033.1748392-1-bernd.kuhls@t-online.de>
Hello Bernd,
On Wed, 14 Jun 2023 19:30:32 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> +ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
> +XAPP_XFD_CONF_ENV += ac_cv_search_gettext=no
> +endif
I have not looked too much into the details, but I don't think this is
the right fix. Indeed, xapp_xfd should obey to the standard
--enable-nls/--disable-nls option. There is some standard
autoconf/automake machinery to handle NLS, and xapp_xfd is not using
it, which is what is causing the problem.
See
http://thegreyblog.blogspot.com/2017/11/making-gettext-optional-during-build-of.html
for a starting point on how to fix this properly.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-07-29 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 17:30 [Buildroot] [PATCH 1/2] package/x11r7/xapp_xfd: disable gettext detection when not needed Bernd Kuhls
2023-06-14 17:30 ` [Buildroot] [PATCH 2/2] package/x11r7/xapp_xhost: " Bernd Kuhls
2023-07-29 22:40 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730004040.0d0e8127@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox