[Buildroot] [PATCH 1/2] package/x11r7/xapp_xfd: disable gettext detection when not needed

[Buildroot] [PATCH 1/2] package/x11r7/xapp_xfd: disable gettext detection when not needed

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/856/856b0f332b4a82a5ce308643c37a14d3c6aebcc1/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xapp_xfd/xapp_xfd.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/x11r7/xapp_xfd/xapp_xfd.mk b/package/x11r7/xapp_xfd/xapp_xfd.mk
index 1ef1d69db3..bccbc1da5d 100644
--- a/package/x11r7/xapp_xfd/xapp_xfd.mk
+++ b/package/x11r7/xapp_xfd/xapp_xfd.mk
@@ -25,4 +25,8 @@ else
 XAPP_XFD_CONF_OPTS += --without-xkb
 endif
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
+XAPP_XFD_CONF_ENV += ac_cv_search_gettext=no
+endif
+
 $(eval $(autotools-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/x11r7/xapp_xhost: disable gettext detection when not needed

[Bernd Kuhls]

Fixes a build error similar to
http://autobuild.buildroot.net/results/856/856b0f332b4a82a5ce308643c37a14d3c6aebcc1/

To reproduce just enable this package using the defconfig on a host
without /usr/bin/gettext and without /usr/bin/xgettext.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/x11r7/xapp_xhost/xapp_xhost.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/x11r7/xapp_xhost/xapp_xhost.mk b/package/x11r7/xapp_xhost/xapp_xhost.mk
index 55f7ca5cc7..4638095976 100644
--- a/package/x11r7/xapp_xhost/xapp_xhost.mk
+++ b/package/x11r7/xapp_xhost/xapp_xhost.mk
@@ -12,4 +12,8 @@ XAPP_XHOST_LICENSE_FILES = COPYING
 XAPP_XHOST_DEPENDENCIES = xlib_libX11 xlib_libXmu $(TARGET_NLS_DEPENDENCIES)
 XAPP_XHOST_CONF_ENV = LIBS=$(TARGET_NLS_LIBS)
 
+ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
+XAPP_XHOST_CONF_ENV += ac_cv_search_gettext=no
+endif
+
 $(eval $(autotools-package))
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/x11r7/xapp_xfd: disable gettext detection when not needed

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Wed, 14 Jun 2023 19:30:32 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> +ifeq ($(BR2_SYSTEM_ENABLE_NLS),)
> +XAPP_XFD_CONF_ENV += ac_cv_search_gettext=no
> +endif

I have not looked too much into the details, but I don't think this is
the right fix. Indeed, xapp_xfd should obey to the standard
--enable-nls/--disable-nls option. There is some standard
autoconf/automake machinery to handle NLS, and xapp_xfd is not using
it, which is what is causing the problem.

See
http://thegreyblog.blogspot.com/2017/11/making-gettext-optional-during-build-of.html
for a starting point on how to fix this properly.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot