[Buildroot] [PATCH RFC 1/1] package/xenomai: disable -Werror

[Buildroot] [PATCH RFC 1/1] package/xenomai: disable -Werror

[Bernd Kuhls]

Fixes:
http://autobuild.buildroot.net/results/1fd/1fd8d97e0f514a65eb6a4723e49605073c9e3824/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
This is a quick'n'dirty fix for the build error which is only visible if
you issue the build commands manually and remove ">/dev/null 2>&1".
Since this is my first patch for Xenomai I am unsure the fix would be
accepted upstream so I would like to discuss it here before sending it
upstream. Therefore I did not add an Upstream: tag.

 .../0004-configure.ac-Remove-Werror.patch     | 31 +++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 package/xenomai/3.0.10/0004-configure.ac-Remove-Werror.patch

diff --git a/package/xenomai/3.0.10/0004-configure.ac-Remove-Werror.patch b/package/xenomai/3.0.10/0004-configure.ac-Remove-Werror.patch
new file mode 100644
index 0000000000..74e590deff
--- /dev/null
+++ b/package/xenomai/3.0.10/0004-configure.ac-Remove-Werror.patch
@@ -0,0 +1,31 @@
+From 7e1010c82453442edce2914667538f648875284a Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd@kuhls.net>
+Date: Sun, 30 Jul 2023 22:59:41 +0200
+Subject: [PATCH] configure.ac: Remove -Werror
+
+Fixes build errors
+
+task.c:398:16: error: 'ret' may be used uninitialized [-Werror=maybe-uninitialized]
+task.c:444:16: error: 'ret' may be used uninitialized [-Werror=maybe-uninitialized]
+
+Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 45e222b97..5c9476e7b 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -629,7 +629,7 @@ fi
+ dnl Internal CFLAGS and LDFLAGS, may be enhanced per-arch below
+ XENO_USER_CFLAGS="$XENO_USER_APP_CFLAGS -pipe -fstrict-aliasing \
+ -Wall -Wstrict-prototypes -Wmissing-prototypes -Wno-long-long \
+--Wno-unused-parameter -Werror -Wformat-security -D__XENO__ -D__IN_XENO__"
++-Wno-unused-parameter -Wformat-security -D__XENO__ -D__IN_XENO__"
+ if test x$want_fortify = xyes -a x$debug_mode != xfull; then
+    XENO_USER_CFLAGS="$XENO_USER_CFLAGS -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2"
+ fi
+-- 
+2.39.2
+
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH RFC 1/1] package/xenomai: disable -Werror

[Thomas Petazzoni via buildroot]

Hello Bernd,

On Sun, 30 Jul 2023 23:05:23 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> This is a quick'n'dirty fix for the build error which is only visible if
> you issue the build commands manually and remove ">/dev/null 2>&1".
> Since this is my first patch for Xenomai I am unsure the fix would be
> accepted upstream so I would like to discuss it here before sending it
> upstream. Therefore I did not add an Upstream: tag.

I guess upstream would prefer to fix the actual issue rather than
dropping -Werror.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot