Re: [Buildroot] [PATCH v2] package/swaybg: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello James,

On Thu, 20 Apr 2023 21:42:34 -0400
James Knight <james.d.knight@live.com> wrote:

> Provides the `swaybg` utility, which is commonly used with `sway` to
> manage background images/color configuration for the compositor.
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

Thanks, I've applied, with minor tweaks.

> ---
>  package/Config.in          |  1 +
>  package/swaybg/Config.in   | 13 +++++++++++++
>  package/swaybg/swaybg.hash |  3 +++
>  package/swaybg/swaybg.mk   | 35 +++++++++++++++++++++++++++++++++++
>  4 files changed, 52 insertions(+)

You forgot an entry in the DEVELOPERS file.

> diff --git a/package/swaybg/Config.in b/package/swaybg/Config.in
> new file mode 100644
> index 0000000000000000000000000000000000000000..63aa8cdb6a7f72c09644d47238d8705da19329d1
> --- /dev/null
> +++ b/package/swaybg/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_SWAYBG
> +	bool "swaybg"
> +	default y if BR2_PACKAGE_SWAY

We normally don't do this, but I kind of agree here it makes sense, so
I kept it. Let's see if other maintainers disagree :-)

> +	depends on !BR2_STATIC_LIBS # wayland -> dlfcn.h
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	select BR2_PACKAGE_CAIRO
> +	select BR2_PACKAGE_CAIRO_PNG
> +	select BR2_PACKAGE_WAYLAND
> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS
> +	help
> +	  Wallpaper tool for Wayland compositors.
> +
> +	  https://github.com/swaywm/swaybg
> index 0000000000000000000000000000000000000000..4cb738286fb9ec6651754c0a591f5c1cc60b705d
> --- /dev/null
> +++ b/package/swaybg/swaybg.mk
> @@ -0,0 +1,35 @@
> +################################################################################
> +#
> +# swaybg
> +#
> +################################################################################
> +
> +SWAYBG_VERSION = 1.2.0
> +SWAYBG_SITE = https://github.com/swaywm/swaybg/releases/download/v$(SWAYBG_VERSION)
> +SWAYBG_LICENSE = MIT
> +SWAYBG_LICENSE_FILES = LICENSE
> +
> +SWAYBG_DEPENDENCIES = \
> +	cairo \
> +	wayland \
> +	wayland-protocols
> +
> +SWAYBG_CONF_OPTS = \
> +	-Dman-pages=disabled
> +
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> +# swaybg does not build against uClibc, swaybg uses POSIX defines to indicate
> +# support for `strdup`, which is not enough for uClibc to provide a declaration
> +# of `strdup`. The implicit use of the function causes a build failure. To
> +# avoid this, turn off the "warnings are errors" flag.
> +SWAYBG_CONF_OPTS += -Dwerror=false

I was not able to reproduce the uClibc build issues, and in general we
don't try to make Werror disabling conditional on the exact situation
where they happen, and we simply disable Werror unconditionally for the
package, which is what I did here.

Applied with those tweaks. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot