* [Buildroot] [PATCH v2] package/swaybg: new package
@ 2023-04-21 1:42 James Knight
2023-07-31 21:17 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: James Knight @ 2023-04-21 1:42 UTC (permalink / raw)
To: buildroot; +Cc: James Knight
Provides the `swaybg` utility, which is commonly used with `sway` to
manage background images/color configuration for the compositor.
Signed-off-by: James Knight <james.d.knight@live.com>
---
package/Config.in | 1 +
package/swaybg/Config.in | 13 +++++++++++++
package/swaybg/swaybg.hash | 3 +++
package/swaybg/swaybg.mk | 35 +++++++++++++++++++++++++++++++++++
4 files changed, 52 insertions(+)
create mode 100644 package/swaybg/Config.in
create mode 100644 package/swaybg/swaybg.hash
create mode 100644 package/swaybg/swaybg.mk
diff --git a/package/Config.in b/package/Config.in
index eaac32a01af363936edc8a0a8dd2450c458a38ae..d2b6422860a4da5a1d810aad26d2e10a10270275 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -329,6 +329,7 @@ comment "Graphic applications"
source "package/rrdtool/Config.in"
source "package/stellarium/Config.in"
source "package/sway/Config.in"
+ source "package/swaybg/Config.in"
source "package/tesseract-ocr/Config.in"
source "package/tinifier/Config.in"
diff --git a/package/swaybg/Config.in b/package/swaybg/Config.in
new file mode 100644
index 0000000000000000000000000000000000000000..63aa8cdb6a7f72c09644d47238d8705da19329d1
--- /dev/null
+++ b/package/swaybg/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_SWAYBG
+ bool "swaybg"
+ default y if BR2_PACKAGE_SWAY
+ depends on !BR2_STATIC_LIBS # wayland -> dlfcn.h
+ depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+ select BR2_PACKAGE_CAIRO
+ select BR2_PACKAGE_CAIRO_PNG
+ select BR2_PACKAGE_WAYLAND
+ select BR2_PACKAGE_WAYLAND_PROTOCOLS
+ help
+ Wallpaper tool for Wayland compositors.
+
+ https://github.com/swaywm/swaybg
diff --git a/package/swaybg/swaybg.hash b/package/swaybg/swaybg.hash
new file mode 100644
index 0000000000000000000000000000000000000000..62bf048d6125ebe7d6d936875bdd0083a105d60c
--- /dev/null
+++ b/package/swaybg/swaybg.hash
@@ -0,0 +1,3 @@
+# Locally computed, tarball verified with GPG signature
+sha256 c0205b34f1fad94553b6cb2c2b983cc33186018026058cad0b841a00bc3087e3 swaybg-1.2.0.tar.gz
+sha256 95224d118a325daf31828afcca98cd958d53f0a7cdd856b50b1be8ac44832faf LICENSE
diff --git a/package/swaybg/swaybg.mk b/package/swaybg/swaybg.mk
new file mode 100644
index 0000000000000000000000000000000000000000..4cb738286fb9ec6651754c0a591f5c1cc60b705d
--- /dev/null
+++ b/package/swaybg/swaybg.mk
@@ -0,0 +1,35 @@
+################################################################################
+#
+# swaybg
+#
+################################################################################
+
+SWAYBG_VERSION = 1.2.0
+SWAYBG_SITE = https://github.com/swaywm/swaybg/releases/download/v$(SWAYBG_VERSION)
+SWAYBG_LICENSE = MIT
+SWAYBG_LICENSE_FILES = LICENSE
+
+SWAYBG_DEPENDENCIES = \
+ cairo \
+ wayland \
+ wayland-protocols
+
+SWAYBG_CONF_OPTS = \
+ -Dman-pages=disabled
+
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
+# swaybg does not build against uClibc, swaybg uses POSIX defines to indicate
+# support for `strdup`, which is not enough for uClibc to provide a declaration
+# of `strdup`. The implicit use of the function causes a build failure. To
+# avoid this, turn off the "warnings are errors" flag.
+SWAYBG_CONF_OPTS += -Dwerror=false
+endif
+
+ifeq ($(BR2_PACKAGE_GDK_PIXBUF),y)
+SWAYBG_CONF_OPTS += -Dgdk-pixbuf=enabled
+SWAYBG_DEPENDENCIES += gdk-pixbuf
+else
+SWAYBG_CONF_OPTS += -Dgdk-pixbuf=disabled
+endif
+
+$(eval $(meson-package))
--
2.39.1.windows.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Buildroot] [PATCH v2] package/swaybg: new package
2023-04-21 1:42 [Buildroot] [PATCH v2] package/swaybg: new package James Knight
@ 2023-07-31 21:17 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-31 21:17 UTC (permalink / raw)
To: James Knight; +Cc: buildroot
Hello James,
On Thu, 20 Apr 2023 21:42:34 -0400
James Knight <james.d.knight@live.com> wrote:
> Provides the `swaybg` utility, which is commonly used with `sway` to
> manage background images/color configuration for the compositor.
>
> Signed-off-by: James Knight <james.d.knight@live.com>
Thanks, I've applied, with minor tweaks.
> ---
> package/Config.in | 1 +
> package/swaybg/Config.in | 13 +++++++++++++
> package/swaybg/swaybg.hash | 3 +++
> package/swaybg/swaybg.mk | 35 +++++++++++++++++++++++++++++++++++
> 4 files changed, 52 insertions(+)
You forgot an entry in the DEVELOPERS file.
> diff --git a/package/swaybg/Config.in b/package/swaybg/Config.in
> new file mode 100644
> index 0000000000000000000000000000000000000000..63aa8cdb6a7f72c09644d47238d8705da19329d1
> --- /dev/null
> +++ b/package/swaybg/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_SWAYBG
> + bool "swaybg"
> + default y if BR2_PACKAGE_SWAY
We normally don't do this, but I kind of agree here it makes sense, so
I kept it. Let's see if other maintainers disagree :-)
> + depends on !BR2_STATIC_LIBS # wayland -> dlfcn.h
> + depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> + select BR2_PACKAGE_CAIRO
> + select BR2_PACKAGE_CAIRO_PNG
> + select BR2_PACKAGE_WAYLAND
> + select BR2_PACKAGE_WAYLAND_PROTOCOLS
> + help
> + Wallpaper tool for Wayland compositors.
> +
> + https://github.com/swaywm/swaybg
> index 0000000000000000000000000000000000000000..4cb738286fb9ec6651754c0a591f5c1cc60b705d
> --- /dev/null
> +++ b/package/swaybg/swaybg.mk
> @@ -0,0 +1,35 @@
> +################################################################################
> +#
> +# swaybg
> +#
> +################################################################################
> +
> +SWAYBG_VERSION = 1.2.0
> +SWAYBG_SITE = https://github.com/swaywm/swaybg/releases/download/v$(SWAYBG_VERSION)
> +SWAYBG_LICENSE = MIT
> +SWAYBG_LICENSE_FILES = LICENSE
> +
> +SWAYBG_DEPENDENCIES = \
> + cairo \
> + wayland \
> + wayland-protocols
> +
> +SWAYBG_CONF_OPTS = \
> + -Dman-pages=disabled
> +
> +ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
> +# swaybg does not build against uClibc, swaybg uses POSIX defines to indicate
> +# support for `strdup`, which is not enough for uClibc to provide a declaration
> +# of `strdup`. The implicit use of the function causes a build failure. To
> +# avoid this, turn off the "warnings are errors" flag.
> +SWAYBG_CONF_OPTS += -Dwerror=false
I was not able to reproduce the uClibc build issues, and in general we
don't try to make Werror disabling conditional on the exact situation
where they happen, and we simply disable Werror unconditionally for the
package, which is what I did here.
Applied with those tweaks. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-31 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-21 1:42 [Buildroot] [PATCH v2] package/swaybg: new package James Knight
2023-07-31 21:17 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox