* [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure
@ 2023-07-31 15:47 Neal Frager via buildroot
2023-07-31 15:47 ` [Buildroot] [PATCH v2 2/2] board/versal: " Neal Frager via buildroot
2023-08-01 21:25 ` [Buildroot] [PATCH v2 1/2] board/zynqmp: " Thomas Petazzoni via buildroot
0 siblings, 2 replies; 5+ messages in thread
From: Neal Frager via buildroot @ 2023-07-31 15:47 UTC (permalink / raw)
To: buildroot; +Cc: michal.simek, luca.ceresoli, thomas.petazzoni, Neal Frager
Binutils 2.39 now warns when a segment has RXW permissions:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
This causes the following build error:
aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
permissions.
This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
included with buildroot to solve the problem.
Fixes: https://developer.trustedfirmware.org/T996
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
-switch to upstream version of patch already included with buildroot
-fix commit message accordingly
---
.../0001-feat-build-add-support-for-new-binutils-versions.patch | 1 +
configs/zynqmp_kria_kv260_defconfig | 2 +-
configs/zynqmp_zcu102_defconfig | 1 +
configs/zynqmp_zcu106_defconfig | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
create mode 120000 board/zynqmp/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
diff --git a/board/zynqmp/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch b/board/zynqmp/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
new file mode 120000
index 0000000000..695cc80b94
--- /dev/null
+++ b/board/zynqmp/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
@@ -0,0 +1 @@
+../../../../boot/arm-trusted-firmware/v2.6/0001-feat-build-add-support-for-new-binutils-versions.patch
\ No newline at end of file
diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
index e180d5e7e7..8ceaa6983d 100644
--- a/configs/zynqmp_kria_kv260_defconfig
+++ b/configs/zynqmp_kria_kv260_defconfig
@@ -38,4 +38,4 @@ BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
-BR2_GLOBAL_PATCH_DIR="board/zynqmp/kria/patches"
+BR2_GLOBAL_PATCH_DIR="board/zynqmp/kria/patches board/zynqmp/patches"
diff --git a/configs/zynqmp_zcu102_defconfig b/configs/zynqmp_zcu102_defconfig
index 00b33261b6..f4789b9d88 100644
--- a/configs/zynqmp_zcu102_defconfig
+++ b/configs/zynqmp_zcu102_defconfig
@@ -36,3 +36,4 @@ BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
+BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches"
diff --git a/configs/zynqmp_zcu106_defconfig b/configs/zynqmp_zcu106_defconfig
index 88295571af..516f1143ce 100644
--- a/configs/zynqmp_zcu106_defconfig
+++ b/configs/zynqmp_zcu106_defconfig
@@ -36,3 +36,4 @@ BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
+BR2_GLOBAL_PATCH_DIR="board/zynqmp/patches"
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/2] board/versal: fix atf build failure
2023-07-31 15:47 [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure Neal Frager via buildroot
@ 2023-07-31 15:47 ` Neal Frager via buildroot
2023-08-01 21:26 ` Thomas Petazzoni via buildroot
2023-08-01 21:25 ` [Buildroot] [PATCH v2 1/2] board/zynqmp: " Thomas Petazzoni via buildroot
1 sibling, 1 reply; 5+ messages in thread
From: Neal Frager via buildroot @ 2023-07-31 15:47 UTC (permalink / raw)
To: buildroot; +Cc: michal.simek, luca.ceresoli, thomas.petazzoni, Neal Frager
Binutils 2.39 now warns when a segment has RXW permissions:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
This causes the following build error:
aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
permissions.
This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
included with buildroot to solve the problem.
Fixes: https://developer.trustedfirmware.org/T996
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
-switch to upstream version of patch already included with buildroot
-fix commit message accordingly
---
.../0001-feat-build-add-support-for-new-binutils-versions.patch | 1 +
configs/versal_vck190_defconfig | 1 +
2 files changed, 2 insertions(+)
create mode 120000 board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
diff --git a/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch b/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
new file mode 120000
index 0000000000..695cc80b94
--- /dev/null
+++ b/board/versal/patches/arm-trusted-firmware/0001-feat-build-add-support-for-new-binutils-versions.patch
@@ -0,0 +1 @@
+../../../../boot/arm-trusted-firmware/v2.6/0001-feat-build-add-support-for-new-binutils-versions.patch
\ No newline at end of file
diff --git a/configs/versal_vck190_defconfig b/configs/versal_vck190_defconfig
index a393b681c8..fab41a2991 100644
--- a/configs/versal_vck190_defconfig
+++ b/configs/versal_vck190_defconfig
@@ -39,3 +39,4 @@ BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
BR2_PACKAGE_HOST_BOOTGEN=y
+BR2_GLOBAL_PATCH_DIR="board/versal/patches"
--
2.25.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure
2023-07-31 15:47 [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure Neal Frager via buildroot
2023-07-31 15:47 ` [Buildroot] [PATCH v2 2/2] board/versal: " Neal Frager via buildroot
@ 2023-08-01 21:25 ` Thomas Petazzoni via buildroot
2023-08-02 4:06 ` Frager, Neal via buildroot
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-01 21:25 UTC (permalink / raw)
To: Neal Frager via buildroot; +Cc: luca.ceresoli, michal.simek, Neal Frager
Hello Neal,
On Mon, 31 Jul 2023 16:47:38 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> Binutils 2.39 now warns when a segment has RXW permissions:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
>
> This causes the following build error:
> aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
> permissions.
>
> This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
> included with buildroot to solve the problem.
>
> Fixes: https://developer.trustedfirmware.org/T996
This Fixes: tag is not really useful. What we're interested in in the
context of Buildroot is which Buildroot issue is being fixed. So I
changed that to:
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556414 (zynqmp_kria_kv260)
https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556417 (zynqmp_zcu102)
https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556420 (zynqmp_zcu106)
when applying. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2 2/2] board/versal: fix atf build failure
2023-07-31 15:47 ` [Buildroot] [PATCH v2 2/2] board/versal: " Neal Frager via buildroot
@ 2023-08-01 21:26 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-01 21:26 UTC (permalink / raw)
To: Neal Frager via buildroot; +Cc: luca.ceresoli, michal.simek, Neal Frager
Hello Neal,
On Mon, 31 Jul 2023 16:47:39 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> Binutils 2.39 now warns when a segment has RXW permissions:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107
>
> This causes the following build error:
> aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
> permissions.
>
> This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch already
> included with buildroot to solve the problem.
>
> Fixes: https://developer.trustedfirmware.org/T996
Same comment as for PATCH 1/2, so I changed to:
Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556395 (versal_vck190)
when applying. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure
2023-08-01 21:25 ` [Buildroot] [PATCH v2 1/2] board/zynqmp: " Thomas Petazzoni via buildroot
@ 2023-08-02 4:06 ` Frager, Neal via buildroot
0 siblings, 0 replies; 5+ messages in thread
From: Frager, Neal via buildroot @ 2023-08-02 4:06 UTC (permalink / raw)
To: Thomas Petazzoni, Neal Frager via buildroot
Cc: luca.ceresoli@bootlin.com, Simek, Michal
Hello Thomas,
> Binutils 2.39 now warns when a segment has RXW permissions:
> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb9991
> 2da01a6e8434126b8fac7aa75107
>
> This causes the following build error:
> aarch64-buildroot-linux-gnu-ld: bl31.elf has a LOAD segment with RWX
> permissions.
>
> This patch applies the upstream boot/arm-trusted-firmware/v2.6 patch
> already included with buildroot to solve the problem.
>
> Fixes: https://developer.trustedfirmware.org/T996
> This Fixes: tag is not really useful. What we're interested in in the context of Buildroot is which Buildroot issue is being fixed. So I changed that to:
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556414 (zynqmp_kria_kv260)
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556417 (zynqmp_zcu102)
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556420 (zynqmp_zcu106)
> when applying. Thanks!
Ok, thanks! Noted for the future.
I have the same response for the versal vck190 patch as well.
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-02 4:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-31 15:47 [Buildroot] [PATCH v2 1/2] board/zynqmp: fix atf build failure Neal Frager via buildroot
2023-07-31 15:47 ` [Buildroot] [PATCH v2 2/2] board/versal: " Neal Frager via buildroot
2023-08-01 21:26 ` Thomas Petazzoni via buildroot
2023-08-01 21:25 ` [Buildroot] [PATCH v2 1/2] board/zynqmp: " Thomas Petazzoni via buildroot
2023-08-02 4:06 ` Frager, Neal via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox