* [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package
2023-07-26 20:28 [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Christian Stewart via buildroot
@ 2023-07-26 20:28 ` Christian Stewart via buildroot
2023-08-06 11:33 ` Thomas Petazzoni via buildroot
2023-07-26 20:28 ` [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed Christian Stewart via buildroot
` (3 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: Christian Stewart via buildroot @ 2023-07-26 20:28 UTC (permalink / raw)
To: buildroot; +Cc: Christian Stewart, Yann E . MORIN, Thomas Petazzoni
Signed-off-by: Christian Stewart <christian@aperture.us>
---
package/python-pylibfdt/python-pylibfdt.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/python-pylibfdt/python-pylibfdt.mk b/package/python-pylibfdt/python-pylibfdt.mk
index 5511bd12b3..8850b69b30 100644
--- a/package/python-pylibfdt/python-pylibfdt.mk
+++ b/package/python-pylibfdt/python-pylibfdt.mk
@@ -12,4 +12,7 @@ PYTHON_PYLIBFDT_LICENSE = BSD-2-Clause or GPL-2.0+
PYTHON_PYLIBFDT_LICENSE_FILES = BSD-2-Clause GPL
PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
+HOST_PYTHON_PYLIBFDT_DEPENDENCIES = $(PYTHON_PYLIBFDT_DEPENDENCIES)
+
$(eval $(python-package))
+$(eval $(host-python-package))
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package
2023-07-26 20:28 ` [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package Christian Stewart via buildroot
@ 2023-08-06 11:33 ` Thomas Petazzoni via buildroot
2023-09-10 21:32 ` Peter Korsgaard
0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-06 11:33 UTC (permalink / raw)
To: Christian Stewart via buildroot; +Cc: Yann E . MORIN, Christian Stewart
On Wed, 26 Jul 2023 13:28:37 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
> package/python-pylibfdt/python-pylibfdt.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/python-pylibfdt/python-pylibfdt.mk b/package/python-pylibfdt/python-pylibfdt.mk
> index 5511bd12b3..8850b69b30 100644
> --- a/package/python-pylibfdt/python-pylibfdt.mk
> +++ b/package/python-pylibfdt/python-pylibfdt.mk
> @@ -12,4 +12,7 @@ PYTHON_PYLIBFDT_LICENSE = BSD-2-Clause or GPL-2.0+
> PYTHON_PYLIBFDT_LICENSE_FILES = BSD-2-Clause GPL
> PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
>
> +HOST_PYTHON_PYLIBFDT_DEPENDENCIES = $(PYTHON_PYLIBFDT_DEPENDENCIES)
Changed to:
HOST_PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
We generally don't do HOST_<pkg>_DEPENDENCIES = <pkg>_DEPENDENCIES in
packages.
And applied. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package
2023-08-06 11:33 ` Thomas Petazzoni via buildroot
@ 2023-09-10 21:32 ` Peter Korsgaard
0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2023-09-10 21:32 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: Christian Stewart, Yann E . MORIN, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Wed, 26 Jul 2023 13:28:37 -0700
> Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
>> Signed-off-by: Christian Stewart <christian@aperture.us>
>> ---
>> package/python-pylibfdt/python-pylibfdt.mk | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/package/python-pylibfdt/python-pylibfdt.mk b/package/python-pylibfdt/python-pylibfdt.mk
>> index 5511bd12b3..8850b69b30 100644
>> --- a/package/python-pylibfdt/python-pylibfdt.mk
>> +++ b/package/python-pylibfdt/python-pylibfdt.mk
>> @@ -12,4 +12,7 @@ PYTHON_PYLIBFDT_LICENSE = BSD-2-Clause or GPL-2.0+
>> PYTHON_PYLIBFDT_LICENSE_FILES = BSD-2-Clause GPL
>> PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
>>
>> +HOST_PYTHON_PYLIBFDT_DEPENDENCIES = $(PYTHON_PYLIBFDT_DEPENDENCIES)
> Changed to:
> HOST_PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
> We generally don't do HOST_<pkg>_DEPENDENCIES = <pkg>_DEPENDENCIES in
> packages.
> And applied. Thanks!
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-26 20:28 [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Christian Stewart via buildroot
2023-07-26 20:28 ` [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package Christian Stewart via buildroot
@ 2023-07-26 20:28 ` Christian Stewart via buildroot
2023-07-26 20:34 ` Thomas Petazzoni via buildroot
` (2 more replies)
2023-08-06 7:05 ` [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Sergey Matyukevich
` (2 subsequent siblings)
4 siblings, 3 replies; 16+ messages in thread
From: Christian Stewart via buildroot @ 2023-07-26 20:28 UTC (permalink / raw)
To: buildroot; +Cc: Christian Stewart, Yann E . MORIN, Thomas Petazzoni
If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
host-python-pylibfdt.
Fixes a build failure with uboot 2023.07:
$ make uboot
error: pylibfdt does not seem to be available with python3
Signed-off-by: Christian Stewart <christian@aperture.us>
---
boot/uboot/uboot.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 1a6e70a792..73ef204292 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -217,7 +217,7 @@ UBOOT_DEPENDENCIES += host-python3 host-python-setuptools
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
-UBOOT_DEPENDENCIES += host-swig
+UBOOT_DEPENDENCIES += host-swig host-python-pylibfdt
endif
ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-26 20:28 ` [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed Christian Stewart via buildroot
@ 2023-07-26 20:34 ` Thomas Petazzoni via buildroot
2023-07-26 20:42 ` Christian Stewart via buildroot
2023-07-31 14:10 ` Giulio Benetti
2023-08-06 11:34 ` Thomas Petazzoni via buildroot
2 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-26 20:34 UTC (permalink / raw)
To: Christian Stewart; +Cc: Yann E . MORIN, buildroot
On Wed, 26 Jul 2023 13:28:38 -0700
Christian Stewart <christian@aperture.us> wrote:
> If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
> host-python-pylibfdt.
>
> Fixes a build failure with uboot 2023.07:
>
> $ make uboot
> error: pylibfdt does not seem to be available with python3
>
> Signed-off-by: Christian Stewart <christian@aperture.us>
But I thought pylibfdt was shipped as part of U-Boot? Isn't that no
longer the case?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-26 20:34 ` Thomas Petazzoni via buildroot
@ 2023-07-26 20:42 ` Christian Stewart via buildroot
0 siblings, 0 replies; 16+ messages in thread
From: Christian Stewart via buildroot @ 2023-07-26 20:42 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Yann E . MORIN, buildroot
Thomas,
On Wed, Jul 26, 2023 at 1:34 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 26 Jul 2023 13:28:38 -0700
> Christian Stewart <christian@aperture.us> wrote:
>
> > If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
> > host-python-pylibfdt.
> >
> > Fixes a build failure with uboot 2023.07:
> >
> > $ make uboot
> > error: pylibfdt does not seem to be available with python3
> >
> > Signed-off-by: Christian Stewart <christian@aperture.us>
>
> But I thought pylibfdt was shipped as part of U-Boot? Isn't that no
> longer the case?
That does not seem to be the case if dtc is provided, in the makefile:
# Check dtc and pylibfdt, if DTC is provided, else build them
PHONY += scripts_dtc
scripts_dtc: scripts_basic
$(Q)if test "$(DTC)" = "$(DTC_INTREE)"; then \
$(MAKE) $(build)=scripts/dtc; \
else \
if ! $(DTC) -v >/dev/null; then \
echo '*** Failed to check dtc version: $(DTC)'; \
false; \
else \
if test "$(call dtc-version)" -lt $(DTC_MIN_VERSION); then \
echo '*** Your dtc is too old, please upgrade to dtc
$(DTC_MIN_VERSION) or newer'; \
false; \
else \
if [ -n "$(CONFIG_PYLIBFDT)" ]; then \
if ! echo "import libfdt" | $(PYTHON3) 2>/dev/null; then \
echo '*** pylibfdt does not seem to be
available with $(PYTHON3)'; \
false; \
fi; \
fi; \
fi; \
fi; \
fi
It executes:
echo "import libfdt" | python3
... which fails in Buildroot unless host-python-pylibfdt is installed.
I think if this part evaluates to true it might use the in-tree version:
$(Q)if test "$(DTC)" = "$(DTC_INTREE)"; then \
$(MAKE) $(build)=scripts/dtc; \
else
It's up to you if you want to somehow force the in-tree version but
for my purposes the host-python-pylibfdt package does the trick and
fixes the build failure.
Best regards,
Christian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-26 20:28 ` [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed Christian Stewart via buildroot
2023-07-26 20:34 ` Thomas Petazzoni via buildroot
@ 2023-07-31 14:10 ` Giulio Benetti
2023-07-31 14:43 ` Thomas Petazzoni via buildroot
2023-08-06 11:34 ` Thomas Petazzoni via buildroot
2 siblings, 1 reply; 16+ messages in thread
From: Giulio Benetti @ 2023-07-31 14:10 UTC (permalink / raw)
To: Christian Stewart, buildroot; +Cc: Yann E . MORIN, Thomas Petazzoni
Hi Christian, All,
sorry if I don't answer on the Thread but I've lost previous e-mails :-/
On 26/07/23 22:28, Christian Stewart wrote:
> If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
> host-python-pylibfdt.
>
> Fixes a build failure with uboot 2023.07:
>
> $ make uboot
> error: pylibfdt does not seem to be available with python3
>
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
> boot/uboot/uboot.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index 1a6e70a792..73ef204292 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -217,7 +217,7 @@ UBOOT_DEPENDENCIES += host-python3 host-python-setuptools
> endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
> -UBOOT_DEPENDENCIES += host-swig
> +UBOOT_DEPENDENCIES += host-swig host-python-pylibfdt
> endif
>
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
U-Boot approach for this is to force Python3 to build libfdtpy[1]
but what we experience here is a consequence of Buildroot's commit
231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 [2]
Something happens after that patch has been applied that basically
passes Buildroot's host dtc to UBOOT_MAKE_OPTS:
```
UBOOT_MAKE_OPTS += DTC=$(HOST_DIR)/bin/dtc
```
The root cause seems to be Python3 anyway as U-Boot patch points.
Since we can't patch every U-Boot version we could fix Python3 but
using the approach proposed by Christian is easier to be honest.
To prove it's a Python3 issue you can see from one of my Gitlab-CI
failure[3] that various U-Boot versions are different, not the last
one(2023.07).
I've tested this patchset successully, so:
Tested-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
[1]:
https://patchwork.ozlabs.org/project/uboot/patch/20170329194123.2361-1-stefan@agner.ch/#1630820
[2]:
https://gitlab.com/buildroot.org/buildroot/-/commit/231d79c81e9a1f8c2ef14861374a40fcdc5e6b33
[3]: https://gitlab.com/buildroot.org/buildroot/-/jobs/4749555892
Best regards
--
CEO/CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-31 14:10 ` Giulio Benetti
@ 2023-07-31 14:43 ` Thomas Petazzoni via buildroot
2023-07-31 14:56 ` Christian Stewart via buildroot
0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-07-31 14:43 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Yann E . MORIN, Christian Stewart, buildroot
On Mon, 31 Jul 2023 16:10:48 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> U-Boot approach for this is to force Python3 to build libfdtpy[1]
> but what we experience here is a consequence of Buildroot's commit
> 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 [2]
>
> Something happens after that patch has been applied that basically
> passes Buildroot's host dtc to UBOOT_MAKE_OPTS:
> ```
> UBOOT_MAKE_OPTS += DTC=$(HOST_DIR)/bin/dtc
> ```
> The root cause seems to be Python3 anyway as U-Boot patch points.
>
> Since we can't patch every U-Boot version we could fix Python3 but
> using the approach proposed by Christian is easier to be honest.
>
> To prove it's a Python3 issue you can see from one of my Gitlab-CI
> failure[3] that various U-Boot versions are different, not the last
> one(2023.07).
Hm, thanks for your feedback, but even after reading 3 times your
e-mail, I still don't grasp what's going on. You've pointed out that
Buildroot commit 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 is when build
failures starting to occur. But what's the relationship between setting
DTC and U-Boot having issues finding pylibfdt?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-31 14:43 ` Thomas Petazzoni via buildroot
@ 2023-07-31 14:56 ` Christian Stewart via buildroot
2023-07-31 15:02 ` Giulio Benetti
0 siblings, 1 reply; 16+ messages in thread
From: Christian Stewart via buildroot @ 2023-07-31 14:56 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Giulio Benetti, Yann E . MORIN, Buildroot Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 1429 bytes --]
Thomas,
On Mon, Jul 31, 2023, 7:43 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:
> On Mon, 31 Jul 2023 16:10:48 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
>
> > U-Boot approach for this is to force Python3 to build libfdtpy[1]
> > but what we experience here is a consequence of Buildroot's commit
> > 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 [2]
> >
> > Something happens after that patch has been applied that basically
> > passes Buildroot's host dtc to UBOOT_MAKE_OPTS:
> > ```
> > UBOOT_MAKE_OPTS += DTC=$(HOST_DIR)/bin/dtc
> > ```
> > The root cause seems to be Python3 anyway as U-Boot patch points.
> >
> > Since we can't patch every U-Boot version we could fix Python3 but
> > using the approach proposed by Christian is easier to be honest.
> >
> > To prove it's a Python3 issue you can see from one of my Gitlab-CI
> > failure[3] that various U-Boot versions are different, not the last
> > one(2023.07).
>
> Hm, thanks for your feedback, but even after reading 3 times your
> e-mail, I still don't grasp what's going on. You've pointed out that
> Buildroot commit 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 is when build
> failures starting to occur. But what's the relationship between setting
> DTC and U-Boot having issues finding pylibfdt?
>
If DTC is set the uboot makefile attempts to use the external python
package instead of building the internal one
Best,
Christian
[-- Attachment #1.2: Type: text/html, Size: 2088 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-31 14:56 ` Christian Stewart via buildroot
@ 2023-07-31 15:02 ` Giulio Benetti
0 siblings, 0 replies; 16+ messages in thread
From: Giulio Benetti @ 2023-07-31 15:02 UTC (permalink / raw)
To: Christian Stewart, Thomas Petazzoni
Cc: Yann E . MORIN, Buildroot Mailing List
On 31/07/23 16:56, Christian Stewart via buildroot wrote:
> Thomas,
>
> On Mon, Jul 31, 2023, 7:43 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com <mailto:thomas.petazzoni@bootlin.com>> wrote:
>
> On Mon, 31 Jul 2023 16:10:48 +0200
> Giulio Benetti <giulio.benetti@benettiengineering.com
> <mailto:giulio.benetti@benettiengineering.com>> wrote:
>
> > U-Boot approach for this is to force Python3 to build libfdtpy[1]
> > but what we experience here is a consequence of Buildroot's commit
> > 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 [2]
> >
> > Something happens after that patch has been applied that basically
> > passes Buildroot's host dtc to UBOOT_MAKE_OPTS:
> > ```
> > UBOOT_MAKE_OPTS += DTC=$(HOST_DIR)/bin/dtc
> > ```
> > The root cause seems to be Python3 anyway as U-Boot patch points.
> >
> > Since we can't patch every U-Boot version we could fix Python3 but
> > using the approach proposed by Christian is easier to be honest.
> >
> > To prove it's a Python3 issue you can see from one of my Gitlab-CI
> > failure[3] that various U-Boot versions are different, not the last
> > one(2023.07).
>
> Hm, thanks for your feedback, but even after reading 3 times your
> e-mail, I still don't grasp what's going on. You've pointed out that
> Buildroot commit 231d79c81e9a1f8c2ef14861374a40fcdc5e6b33 is when build
> failures starting to occur. But what's the relationship between setting
> DTC and U-Boot having issues finding pylibfdt?
>
>
> If DTC is set the uboot makefile attempts to use the external python
> package instead of building the internal one
This ^^^ is what I've meant :-)
--
CEO/CTO@Benetti Engineering sas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-07-26 20:28 ` [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed Christian Stewart via buildroot
2023-07-26 20:34 ` Thomas Petazzoni via buildroot
2023-07-31 14:10 ` Giulio Benetti
@ 2023-08-06 11:34 ` Thomas Petazzoni via buildroot
2023-09-10 21:33 ` Peter Korsgaard
2 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-06 11:34 UTC (permalink / raw)
To: Christian Stewart via buildroot; +Cc: Yann E . MORIN, Christian Stewart
On Wed, 26 Jul 2023 13:28:38 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
> host-python-pylibfdt.
>
> Fixes a build failure with uboot 2023.07:
>
> $ make uboot
> error: pylibfdt does not seem to be available with python3
>
> Signed-off-by: Christian Stewart <christian@aperture.us>
I've completely reworded the commit log to really explain what's going
and since when the problem is occurring.
> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
> -UBOOT_DEPENDENCIES += host-swig
> +UBOOT_DEPENDENCIES += host-swig host-python-pylibfdt
I dropped host-swig from here. Indeed, it was previously needed to
allow U-Boot to build its own pylibfdt copy. Now that we build our own
host-python-pylibfdt, host-swig is no longer needed as a dependency of
U-Boot: it's needed as a dependency of host-python-pylibfdt (which it
already is).
Applied with those changes, thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed
2023-08-06 11:34 ` Thomas Petazzoni via buildroot
@ 2023-09-10 21:33 ` Peter Korsgaard
0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2023-09-10 21:33 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot
Cc: Christian Stewart, Yann E . MORIN, Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Wed, 26 Jul 2023 13:28:38 -0700
> Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
>> If BR2_TARGET_UBOOT_NEEDS_PYLIBFDT is set, add a dependency on
>> host-python-pylibfdt.
>>
>> Fixes a build failure with uboot 2023.07:
>>
>> $ make uboot
>> error: pylibfdt does not seem to be available with python3
>>
>> Signed-off-by: Christian Stewart <christian@aperture.us>
> I've completely reworded the commit log to really explain what's going
> and since when the problem is occurring.
>> ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
>> -UBOOT_DEPENDENCIES += host-swig
>> +UBOOT_DEPENDENCIES += host-swig host-python-pylibfdt
> I dropped host-swig from here. Indeed, it was previously needed to
> allow U-Boot to build its own pylibfdt copy. Now that we build our own
> host-python-pylibfdt, host-swig is no longer needed as a dependency of
> U-Boot: it's needed as a dependency of host-python-pylibfdt (which it
> already is).
> Applied with those changes, thanks!
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1
2023-07-26 20:28 [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Christian Stewart via buildroot
2023-07-26 20:28 ` [Buildroot] [PATCH v1 2/3] package/python-pylibfdt: add host python package Christian Stewart via buildroot
2023-07-26 20:28 ` [Buildroot] [PATCH v1 3/3] boot/uboot: add host-python-pylibfdt dependency if needed Christian Stewart via buildroot
@ 2023-08-06 7:05 ` Sergey Matyukevich
2023-08-06 11:08 ` Lothar Felten
2023-08-06 11:32 ` Thomas Petazzoni via buildroot
4 siblings, 0 replies; 16+ messages in thread
From: Sergey Matyukevich @ 2023-08-06 7:05 UTC (permalink / raw)
To: Christian Stewart; +Cc: Yann E . MORIN, Thomas Petazzoni, buildroot
Hi Christian,
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
> package/python-pylibfdt/python-pylibfdt.hash | 4 ++--
> package/python-pylibfdt/python-pylibfdt.mk | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/package/python-pylibfdt/python-pylibfdt.hash b/package/python-pylibfdt/python-pylibfdt.hash
> index 056fd3a62e..82527e727e 100644
> --- a/package/python-pylibfdt/python-pylibfdt.hash
> +++ b/package/python-pylibfdt/python-pylibfdt.hash
> @@ -1,6 +1,6 @@
> # md5, sha256 from https://pypi.python.org/pypi/pylibfdt/json
> -md5 5765c20ac6cde517d5b7218503ab707b pylibfdt-1.6.1.tar.gz
> -sha256 90c667c5adf44c6ab2f13bdc566598897784c7b781bed91064e7373bd270b778 pylibfdt-1.6.1.tar.gz
> +md5 353ee3063d0b10e94d165e032897d34e pylibfdt-1.7.0.post1.tar.gz
> +sha256 2d048f9f8ce9a0527d497f423dea1f1135f9811c05b009cc5d5753771c1f9ba1 pylibfdt-1.7.0.post1.tar.gz
> # Locally computed
> sha256 6313108c23efffa36948f8b2cff1560a5935373b527b0e1a837cc77e6ed1bacd BSD-2-Clause
> sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 GPL
> diff --git a/package/python-pylibfdt/python-pylibfdt.mk b/package/python-pylibfdt/python-pylibfdt.mk
> index dc68de83b3..5511bd12b3 100644
> --- a/package/python-pylibfdt/python-pylibfdt.mk
> +++ b/package/python-pylibfdt/python-pylibfdt.mk
> @@ -4,10 +4,10 @@
> #
> ################################################################################
>
> -PYTHON_PYLIBFDT_VERSION = 1.6.1
> +PYTHON_PYLIBFDT_VERSION = 1.7.0.post1
> PYTHON_PYLIBFDT_SOURCE = pylibfdt-$(PYTHON_PYLIBFDT_VERSION).tar.gz
> -PYTHON_PYLIBFDT_SITE = https://files.pythonhosted.org/packages/15/3c/40b1d6a1df9dbc9d9ba5700a47ad95ca1e984f18daf25ede0da5f67d0cf7
> -PYTHON_PYLIBFDT_SETUP_TYPE = setuptools
> +PYTHON_PYLIBFDT_SITE = https://files.pythonhosted.org/packages/96/5c/77ef0f0459e0b13f39ecc22e21ad4ac9fbe741e8a7cd70702ac8165f80e2
> +PYTHON_PYLIBFDT_SETUP_TYPE = pep517
> PYTHON_PYLIBFDT_LICENSE = BSD-2-Clause or GPL-2.0+
> PYTHON_PYLIBFDT_LICENSE_FILES = BSD-2-Clause GPL
> PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
This patch series fixes the following recent build failures:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556137
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556224
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556227
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556229
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4749556230
Tested-by: Sergey Matyukevich <geomatsi@gmail.com>
Thanks,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1
2023-07-26 20:28 [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Christian Stewart via buildroot
` (2 preceding siblings ...)
2023-08-06 7:05 ` [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Sergey Matyukevich
@ 2023-08-06 11:08 ` Lothar Felten
2023-08-06 11:32 ` Thomas Petazzoni via buildroot
4 siblings, 0 replies; 16+ messages in thread
From: Lothar Felten @ 2023-08-06 11:08 UTC (permalink / raw)
To: Christian Stewart, buildroot; +Cc: Yann E . MORIN, Thomas Petazzoni
Hi Christian,
On Wed, 2023-07-26 at 13:28 -0700, Christian Stewart via buildroot
wrote:
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
> package/python-pylibfdt/python-pylibfdt.hash | 4 ++--
> package/python-pylibfdt/python-pylibfdt.mk | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/package/python-pylibfdt/python-pylibfdt.hash
> b/package/python-pylibfdt/python-pylibfdt.hash
> index 056fd3a62e..82527e727e 100644
> --- a/package/python-pylibfdt/python-pylibfdt.hash
> +++ b/package/python-pylibfdt/python-pylibfdt.hash
> @@ -1,6 +1,6 @@
> # md5, sha256 from https://pypi.python.org/pypi/pylibfdt/json
> -md5 5765c20ac6cde517d5b7218503ab707b pylibfdt-1.6.1.tar.gz
> -sha256
> 90c667c5adf44c6ab2f13bdc566598897784c7b781bed91064e7373bd270b778
> pylibfdt-1.6.1.tar.gz
> +md5 353ee3063d0b10e94d165e032897d34e pylibfdt-1.7.0.post1.tar.gz
> +sha256
> 2d048f9f8ce9a0527d497f423dea1f1135f9811c05b009cc5d5753771c1f9ba1
> pylibfdt-1.7.0.post1.tar.gz
> # Locally computed
> sha256
> 6313108c23efffa36948f8b2cff1560a5935373b527b0e1a837cc77e6ed1bacd
> BSD-2-Clause
> sha256
> 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643 GPL
> diff --git a/package/python-pylibfdt/python-pylibfdt.mk
> b/package/python-pylibfdt/python-pylibfdt.mk
> index dc68de83b3..5511bd12b3 100644
> --- a/package/python-pylibfdt/python-pylibfdt.mk
> +++ b/package/python-pylibfdt/python-pylibfdt.mk
> @@ -4,10 +4,10 @@
> #
> ####################################################################
> ############
>
> -PYTHON_PYLIBFDT_VERSION = 1.6.1
> +PYTHON_PYLIBFDT_VERSION = 1.7.0.post1
> PYTHON_PYLIBFDT_SOURCE = pylibfdt-$(PYTHON_PYLIBFDT_VERSION).tar.gz
> -PYTHON_PYLIBFDT_SITE =
> https://files.pythonhosted.org/packages/15/3c/40b1d6a1df9dbc9d9ba5700a47ad95ca1e984f18daf25ede0da5f67d0cf7
> -PYTHON_PYLIBFDT_SETUP_TYPE = setuptools
> +PYTHON_PYLIBFDT_SITE =
> https://files.pythonhosted.org/packages/96/5c/77ef0f0459e0b13f39ecc22e21ad4ac9fbe741e8a7cd70702ac8165f80e2
> +PYTHON_PYLIBFDT_SETUP_TYPE = pep517
> PYTHON_PYLIBFDT_LICENSE = BSD-2-Clause or GPL-2.0+
> PYTHON_PYLIBFDT_LICENSE_FILES = BSD-2-Clause GPL
> PYTHON_PYLIBFDT_DEPENDENCIES = host-python-setuptools-scm host-swig
This fixes the build failure:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4749555991
Tested-by: Lothar Felten <lothar.felten@gmail.com>
Best regards,
Lothar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1
2023-07-26 20:28 [Buildroot] [PATCH v1 1/3] package/python-pylibfdt: bump version to 1.7.0.post1 Christian Stewart via buildroot
` (3 preceding siblings ...)
2023-08-06 11:08 ` Lothar Felten
@ 2023-08-06 11:32 ` Thomas Petazzoni via buildroot
4 siblings, 0 replies; 16+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-06 11:32 UTC (permalink / raw)
To: Christian Stewart via buildroot; +Cc: Yann E . MORIN, Christian Stewart
On Wed, 26 Jul 2023 13:28:36 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: Christian Stewart <christian@aperture.us>
> ---
> package/python-pylibfdt/python-pylibfdt.hash | 4 ++--
> package/python-pylibfdt/python-pylibfdt.mk | 6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 16+ messages in thread