Re: [Buildroot] [PATCH 1/1] package/screenfetch: Add mawk/gawk dependency, and upstream detection patch.

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Nicolas,

On Sun,  6 Aug 2023 12:17:29 +0000
Nicolas Boichat via buildroot <buildroot@buildroot.org> wrote:

> screenfetch requires an "awk" implementation: add that to dependencies.
> 
> Also, upstream would only use an executable called "awk": pick up
> upstream patch that can autodetect awk implementation, so that
> "mawk" can be used.
> 
> Signed-off-by: Nicolas Boichat <drinkcat@google.com>

Thanks for the patch. One question below.

> diff --git a/package/screenfetch/Config.in b/package/screenfetch/Config.in
> index c0e7100f38..00248bafcf 100644
> --- a/package/screenfetch/Config.in
> +++ b/package/screenfetch/Config.in
> @@ -2,8 +2,12 @@ config BR2_PACKAGE_SCREENFETCH
>  	bool "screenfetch"
>  	depends on BR2_USE_MMU # bash
>  	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash
> +	depends on BR2_PACKAGE_GAWK || BR2_PACKAGE_MAWK # runtime dependency

Would the "awk" implementation from Busybox also work? It's the awk
implementation that we use by default.

Also, just like bash is enabled via "select", we should if possible try
to do the same for the awk implementation. I don't know if something like:

	select BR2_PACKAGE_BUSYBOX if !BR2_PACKAGE_GAWK || !BR2_PACKAGE_MAWK

would work (of course, assuming the "awk" from Busybox is good enough).

Thanks for your feedback,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot