From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Nicolas Boichat <drinkcat@google.com>,
Nicolas Boichat via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/screenfetch: Add mawk/gawk dependency, and upstream detection patch.
Date: Sat, 12 Aug 2023 00:27:09 +0200 [thread overview]
Message-ID: <20230812002709.20986967@windsurf> (raw)
In-Reply-To: <03e35eba-6a35-f185-2d32-b7eab93beb05@mind.be>
On Fri, 11 Aug 2023 22:18:15 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > I had a quick try, and yes, I think busybox's awk is good enough.
>
> We assume that "normal tools" are available in the rootfs and don't add
> explicit selects for them. Normal tools include sed, sort, grep, and IMHO also
> awk. So I don't think there's a need for this at all.
>
> And anyway, the presence of busybox doesn't guarantee at all that awk is
> present, because you can configure it out.
>
> So I'd keep the patch, but not the rest of this commit.
That's a good point indeed.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-11 22:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 12:17 [Buildroot] [PATCH 1/1] package/screenfetch: Add mawk/gawk dependency, and upstream detection patch Nicolas Boichat via buildroot
2023-08-06 13:33 ` Thomas Petazzoni via buildroot
2023-08-07 8:22 ` Nicolas Boichat via buildroot
2023-08-11 20:18 ` Arnout Vandecappelle via buildroot
2023-08-11 22:27 ` Thomas Petazzoni via buildroot [this message]
2023-08-12 1:01 ` Nicolas Boichat via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230812002709.20986967@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=drinkcat@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox