Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@buildroot.org
Cc: Martin Bark <martin@barkynet.com>,
	Julien Grossholtz <julien.grossholtz@openest.io>
Subject: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'
Date: Tue,  8 Aug 2023 20:09:59 +0200	[thread overview]
Message-ID: <20230808180959.28091-2-ps.report@gmx.net> (raw)
In-Reply-To: <20230808180959.28091-1-ps.report@gmx.net>

Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit
689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by
changing an dtoverlay option wrongly to an extra line (instead of changing
to an proper dtparam line), but as no one complained since 2021 just
drop it (and upcoming raspberry pi kernel/device tree will enable
it by default [2]).

Fixes (on the board):

	$ cat /proc/device-tree/chosen/user-warnings
	Failed to load overlay 'krnbt=on'

[1] https://git.buildroot.net/buildroot/commit/?id=689b9ac439ab7b507c8982b6102bddf59d03efbf
[2] https://github.com/raspberrypi/linux/commit/ec08e93837efa2e75e5cab4d80427fdf7ea23da1

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/raspberrypi/config_0w.txt      | 3 ---
 board/raspberrypi/config_3.txt       | 3 ---
 board/raspberrypi/config_3_64bit.txt | 3 ---
 board/raspberrypi/config_4.txt       | 3 ---
 board/raspberrypi/config_4_64bit.txt | 3 ---
 board/raspberrypi/config_zero2w.txt  | 3 ---
 6 files changed, 18 deletions(-)

diff --git a/board/raspberrypi/config_0w.txt b/board/raspberrypi/config_0w.txt
index 195bad449e..771b975046 100644
--- a/board/raspberrypi/config_0w.txt
+++ b/board/raspberrypi/config_0w.txt
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
diff --git a/board/raspberrypi/config_3.txt b/board/raspberrypi/config_3.txt
index 195bad449e..771b975046 100644
--- a/board/raspberrypi/config_3.txt
+++ b/board/raspberrypi/config_3.txt
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
diff --git a/board/raspberrypi/config_3_64bit.txt b/board/raspberrypi/config_3_64bit.txt
index 34412fa9e8..ac5a09c486 100644
--- a/board/raspberrypi/config_3_64bit.txt
+++ b/board/raspberrypi/config_3_64bit.txt
@@ -25,8 +25,5 @@ gpu_mem_1024=100
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
 
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
-
 # enable 64bits support
 arm_64bit=1
diff --git a/board/raspberrypi/config_4.txt b/board/raspberrypi/config_4.txt
index ea02d3f071..01f60395b3 100644
--- a/board/raspberrypi/config_4.txt
+++ b/board/raspberrypi/config_4.txt
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
diff --git a/board/raspberrypi/config_4_64bit.txt b/board/raspberrypi/config_4_64bit.txt
index 4a77fb3f1b..139f6a8788 100644
--- a/board/raspberrypi/config_4_64bit.txt
+++ b/board/raspberrypi/config_4_64bit.txt
@@ -25,8 +25,5 @@ gpu_mem_1024=100
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
 dtoverlay=miniuart-bt
 
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
-
 # enable 64bits support
 arm_64bit=1
diff --git a/board/raspberrypi/config_zero2w.txt b/board/raspberrypi/config_zero2w.txt
index 9e6b7f5ccf..151e446b5d 100644
--- a/board/raspberrypi/config_zero2w.txt
+++ b/board/raspberrypi/config_zero2w.txt
@@ -24,6 +24,3 @@ gpu_mem_1024=100
 
 # fixes rpi (3B, 3B+, 3A+, 4B ,zero W and zero 2) ttyAMA0 serial console
 dtoverlay=miniuart-bt
-
-# enable autoprobing of Bluetooth driver without need of hciattach/btattach
-dtoverlay=krnbt=on
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-08 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:09 [Buildroot] [PATCH v1] board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219) Peter Seiderer
2023-08-08 18:09 ` Peter Seiderer [this message]
2023-08-08 22:12   ` [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on' Thomas Petazzoni via buildroot
2023-08-09 22:10     ` Peter Seiderer
2023-11-27 18:51 ` [Buildroot] [PATCH v1] board/raspberrypi/config_4_64bit.txt: remove testing dtoverlay entries (vc4-kms-v3d-pi4, imx219) Yann E. MORIN
2023-11-30 22:37   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808180959.28091-2-ps.report@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@buildroot.org \
    --cc=julien.grossholtz@openest.io \
    --cc=martin@barkynet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox