Re: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'

From: Peter Seiderer <ps.report@gmx.net>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Martin Bark <martin@barkynet.com>,
	Julien Grossholtz <julien.grossholtz@openest.io>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1] board/raspberrypi/config*.txt: remove failing 'dtoverlay=krnbt=on'
Date: Thu, 10 Aug 2023 00:10:10 +0200	[thread overview]
Message-ID: <20230810001010.55cc070a@gmx.net> (raw)
In-Reply-To: <20230809001212.0d61539b@windsurf>

Hello Thomas,

On Wed, 9 Aug 2023 00:12:12 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> On Tue,  8 Aug 2023 20:09:59 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > Remove failing 'dtoverlay=krnbt=on' from config.txt introduced with commit
> > 689b9ac439 ("package/rpi-firmware: rework boot/config file handling") [1] by
> > changing an dtoverlay option wrongly to an extra line (instead of changing
> > to an proper dtparam line), but as no one complained since 2021 just
>
> I'm failing to pase the "changing an dtoverlay option wrongly to an
> extra line (instead of changing to an proper dtparam line)". I'm
> confused by the "to an extra line".
>
> Do you mean that:
>
> dtoverlay=krnbt=on

To be precise the original was (and as documented here [1])

	dtoverlay=miniuart-bt,krnbt=on
>
> should have been:
>
> dtparam=krnbt=on

Yes (as documented here [2])...

Regards,
Peter

[1] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L2371
[2] https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213

>
> ?
>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot