Re: [Buildroot] [PATCH v2 1/1] configs/icnova-a20-adb4006: new defconfig

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Ludwig Kormann <ludwig.kormann@ict42.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] configs/icnova-a20-adb4006: new defconfig
Date: Tue, 8 Aug 2023 22:59:07 +0200	[thread overview]
Message-ID: <20230808225907.7afe6748@windsurf> (raw)
In-Reply-To: <20230628095825.905451-1-ludwig.kormann@ict42.de>

Hello Ludwig,

Thanks for your contribution!

On Wed, 28 Jun 2023 11:58:25 +0200
Ludwig Kormann <ludwig.kormann@ict42.de> wrote:

> Add a defconfig for ICnova A20 SomPi compute module on ADB4006
> development board with Allwinner A20 chip and 512MB/1GB RAM.
> 
> Board support package includes the following components:
> - mainline Linux kernel 6.1.35
> - mainline U-Boot 2023.04
> - custom dts & uboot defconfig
> - default packages from buildoot
> 
> https://wiki.in-circuit.de/index.php5?title=ICnova_ADB4006
> https://wiki.in-circuit.de/index.php5?title=ICnova_A20_SODIMM
> 
> changes in v2:
> - rebase on 2023.05
> - get dts reviewed on the linux mailing list and
> scheduled for kernel 6.5 [1]
> - uboot defconfig upstreaming in progress [2]

Changes between v1 and v2 have to go after the --- sign that follows
your Signed-off-by line. Indeed, we don't want such "changelog" to stay
forever in the commit log preserved in git history. However, the fact
that your board support was upstreamed in Linux and submitted to U-Boot
should have definitely been part of the commit log so I fixed that up.

> diff --git a/board/in-circuit/icnova-a20-adb4006/post-image.sh b/board/in-circuit/icnova-a20-adb4006/post-image.sh
> new file mode 100755
> index 0000000000..9cca1b1789
> --- /dev/null
> +++ b/board/in-circuit/icnova-a20-adb4006/post-image.sh
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"
> +GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg"
> +GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
> +
> +rm -rf "${GENIMAGE_TMP}"
> +
> +genimage                           \
> +	--rootpath "${TARGET_DIR}"     \
> +	--tmppath "${GENIMAGE_TMP}"    \
> +	--inputpath "${BINARIES_DIR}"  \
> +	--outputpath "${BINARIES_DIR}" \
> +	--config "${GENIMAGE_CFG}"
> +
> +exit $?

As suggested by Kilian, I dropped this and used
support/scripts/genimage.sh instead.

Applied to next with those changes. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot