Re: [Buildroot] [PATCH v2 1/1] configs/icnova-a20-adb4006: new defconfig

[Kilian Zinnecker via buildroot <buildroot@buildroot.org>]

Hello Ludwig, all,

> +++ b/board/in-circuit/icnova-a20-adb4006/post-image.sh
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"
> +GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg"
> +GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
> +
> +rm -rf "${GENIMAGE_TMP}"
> +
> +genimage                           \
> +	--rootpath "${TARGET_DIR}"     \
> +	--tmppath "${GENIMAGE_TMP}"    \
> +	--inputpath "${BINARIES_DIR}"  \
> +	--outputpath "${BINARIES_DIR}" \
> +	--config "${GENIMAGE_CFG}"
> +
> +exit $?

This seems to basically only invoke genimage, to create the image as defined in 
your genimage.cfg. There seems to be a script in buildroot, which does exactly 
this. See here: https://gitlab.com/buildroot.org/buildroot/-/blob/master/
support/scripts/genimage.sh
I recently came across this, when I looked at patches for the imxrt1050-evk 
and the Firefly roc_rk3399_pc, see here:

https://patchwork.ozlabs.org/project/buildroot/patch/20230102181603.3337480-1-Mr.Bossman075@gmail.com/
https://patchwork.ozlabs.org/project/buildroot/patch/20230710212151.574040-2-robertoxmed@gmail.com/

They seem to use the support/scripts/genimage.sh in their defconfigs with a 
parameter, e.g.:

BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/freescale/imxrt1050evk/genimage.cfg"

I myself have not done this, but you could maybe do something like this in the 
sun7i-a20-icnova-a20-adb4006_uboot_defconfig: 

BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/in-circuit/icnova-a20-adb4006/
genimage.cfg"

If this works, you could have one script less, i.e., remove the post-image.sh?

(I also do the same in my proposed Radxa Rock 5B patches and think about using 
the support genimage.sh script as well, but there it is a little bit trickier  
...)

Otherwise, to me your board support already looks very well. However, I am not 
a buildroot expert, so I can't really tell ;)

Best regards,
Kilian



_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot