Re: [Buildroot] [PATCH 1/1] package/grantlee: bump to 5.3.1

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Zoltan,

On Wed,  9 Aug 2023 14:38:47 +0200
Zoltan Gyarmati <zgyarmati@zgyarmati.de> wrote:

> Now it also selects
> BR2_PACKAGE_QT5DECLARATIVE
> BR2_PACKAGE_QT5DECLARATIVE_QUICK
> as the new version requires it.
> 
> Signed-off-by: Zoltan Gyarmati <zgyarmati@zgyarmati.de>

Are you sure that BR2_PACKAGE_QT5DECLARATIVE_QUICK is needed? From my
testing, and also reading of the CMakeLists.txt from grantlee, it seems
to not be needed. Could you check this, and send a v2?

Some other suggestions about grantlee, of course that should be handled
as separate patches:

- Grantlee is now also compatible with Qt6, so it would be good to
  support this

- It seems that Qt5Gui is only needed by the textdocument library,
  which can be disabled by -DBUILD_TEXTDOCUMENT=OFF. Perhaps we can
  make that optional?

- Generally speaking, Grantlee has a few options to compile or not
  compile certain parts of it:

option( BUILD_TEMPLATES "Build the Grantlee template library" TRUE )
option( BUILD_TEXTDOCUMENT "Build the Grantlee textdocument library" TRUE )
option( BUILD_MAIN_PLUGINS "Build the Grantlee Templates plugins" TRUE )
option( BUILD_I18N_PLUGIN "Build the Grantlee Templates i18n plugin" TRUE )

  Does it make sense to support some of them, or is Grantlee only
  useful with the full thing built?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot