[Buildroot] [PATCH 1/1] package/grantlee: bump to 5.3.1

[Buildroot] [PATCH 1/1] package/grantlee: bump to 5.3.1

[Zoltan Gyarmati]

Now it also selects
BR2_PACKAGE_QT5DECLARATIVE
BR2_PACKAGE_QT5DECLARATIVE_QUICK
as the new version requires it.

Signed-off-by: Zoltan Gyarmati <zgyarmati@zgyarmati.de>
---
 package/grantlee/Config.in     | 2 ++
 package/grantlee/grantlee.hash | 2 +-
 package/grantlee/grantlee.mk   | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/grantlee/Config.in b/package/grantlee/Config.in
index 779306bc2e..566c4c1d2e 100644
--- a/package/grantlee/Config.in
+++ b/package/grantlee/Config.in
@@ -3,6 +3,8 @@ config BR2_PACKAGE_GRANTLEE
 	depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5
 	select BR2_PACKAGE_QT5SCRIPT
 	select BR2_PACKAGE_QT5BASE_GUI
+	select BR2_PACKAGE_QT5DECLARATIVE
+	select BR2_PACKAGE_QT5DECLARATIVE_QUICK
 	help
 	  Qt implementation of the Django template framework
 
diff --git a/package/grantlee/grantlee.hash b/package/grantlee/grantlee.hash
index 6508aa70cc..57061fb03f 100644
--- a/package/grantlee/grantlee.hash
+++ b/package/grantlee/grantlee.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha256  139acee5746b957bdf1327ec0d97c604d4c0b9be42aec5d584297cb5ed6a990a  grantlee-5.2.0.tar.gz
+sha256  ba288ae9ed37ec0c3622ceb40ae1f7e1e6b2ea89216ad8587f0863d64be24f06  grantlee-5.3.1.tar.gz
 
 # Hash for license file
 sha256  a9bdde5616ecdd1e980b44f360600ee8783b1f99b8cc83a2beb163a0a390e861  COPYING.LIB
diff --git a/package/grantlee/grantlee.mk b/package/grantlee/grantlee.mk
index 7079679ca4..0b5c1e6fba 100644
--- a/package/grantlee/grantlee.mk
+++ b/package/grantlee/grantlee.mk
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-GRANTLEE_VERSION = 5.2.0
+GRANTLEE_VERSION = 5.3.1
 GRANTLEE_SITE = $(call github,steveire,grantlee,v$(GRANTLEE_VERSION))
 GRANTLEE_INSTALL_STAGING = YES
 GRANTLEE_LICENSE = LGPL-2.1+
 GRANTLEE_LICENSE_FILES = COPYING.LIB
-GRANTLEE_DEPENDENCIES = qt5base qt5script
+GRANTLEE_DEPENDENCIES = qt5base qt5script qt5declarative
 
 $(eval $(cmake-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/grantlee: bump to 5.3.1

[Thomas Petazzoni via buildroot]

Hello Zoltan,

On Wed,  9 Aug 2023 14:38:47 +0200
Zoltan Gyarmati <zgyarmati@zgyarmati.de> wrote:

> Now it also selects
> BR2_PACKAGE_QT5DECLARATIVE
> BR2_PACKAGE_QT5DECLARATIVE_QUICK
> as the new version requires it.
> 
> Signed-off-by: Zoltan Gyarmati <zgyarmati@zgyarmati.de>

Are you sure that BR2_PACKAGE_QT5DECLARATIVE_QUICK is needed? From my
testing, and also reading of the CMakeLists.txt from grantlee, it seems
to not be needed. Could you check this, and send a v2?

Some other suggestions about grantlee, of course that should be handled
as separate patches:

- Grantlee is now also compatible with Qt6, so it would be good to
  support this

- It seems that Qt5Gui is only needed by the textdocument library,
  which can be disabled by -DBUILD_TEXTDOCUMENT=OFF. Perhaps we can
  make that optional?

- Generally speaking, Grantlee has a few options to compile or not
  compile certain parts of it:

option( BUILD_TEMPLATES "Build the Grantlee template library" TRUE )
option( BUILD_TEXTDOCUMENT "Build the Grantlee textdocument library" TRUE )
option( BUILD_MAIN_PLUGINS "Build the Grantlee Templates plugins" TRUE )
option( BUILD_I18N_PLUGIN "Build the Grantlee Templates i18n plugin" TRUE )

  Does it make sense to support some of them, or is Grantlee only
  useful with the full thing built?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot