Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Roberto Medina <robertoxmed@gmail.com>
Cc: kilian.zinnecker@mail.de, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.
Date: Sat, 12 Aug 2023 21:58:57 +0200	[thread overview]
Message-ID: <20230812215857.6476eee8@windsurf> (raw)
In-Reply-To: <20230811162546.8088-2-robertoxmed@gmail.com>

Hello Roberto,

I've applied your patch to our next branch, with some very minor
updates.

First, I simplified the commit title to:

	configs/roc_rk3388_pc: new defconfig

See below for more comments.

On Fri, 11 Aug 2023 18:25:38 +0200
Roberto Medina <robertoxmed@gmail.com> wrote:

> * Uses a version 2.9 of TF-A which solves the building issue for this
>   board.
> * Increase the size of the ext2 partition to be able to create the final
>   image.
> * Bump and set the U-Boot version that was used for this configuration.
> * Bump and set the version of Linux to 6.1.45.
> * Some minor fixes in the post-build.sh script using `shellcheck`.

These details are the details of the changes between the v2 and v3 of
your patch, so they do not belong to the commit log, but they should
go...

> 
> Signed-off-by: Roberto Medina <robertoxmed@gmail.com>
> Tested-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> Reviewed-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
> ---

.... here.

>  DEVELOPERS                                |  4 +++
>  board/firefly/roc-rk3399-pc/extlinux.conf |  4 +++
>  board/firefly/roc-rk3399-pc/genimage.cfg  | 22 ++++++++++++
>  board/firefly/roc-rk3399-pc/post-build.sh |  5 +++
>  board/firefly/roc-rk3399-pc/readme.txt    | 40 +++++++++++++++++++++
>  configs/roc_pc_rk3399_defconfig           | 42 +++++++++++++++++++++++
>  6 files changed, 117 insertions(+)
>  create mode 100644 board/firefly/roc-rk3399-pc/extlinux.conf
>  create mode 100644 board/firefly/roc-rk3399-pc/genimage.cfg
>  create mode 100755 board/firefly/roc-rk3399-pc/post-build.sh
>  create mode 100644 board/firefly/roc-rk3399-pc/readme.txt
>  create mode 100644 configs/roc_pc_rk3399_defconfig
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 6ffa3ee693..5ebabd01cb 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2546,6 +2546,10 @@ F:	package/mhz/
>  N:	Robert Rose <robertroyrose@gmail.com>
>  F:	package/grpc/
>  
> +N:	Roberto Medina <robertoxmed@gmail.com>
> +F:	configs/roc_pc_rk3399_defconfig
> +F:	board/firefly/roc-rk3399

Alphabetic ordering was not correct here. And I added the final slash
for the directory, as suggested by Kilian.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot