Re: [Buildroot] [PATCH 1/1 v3] configs/roc_rk3399_pc: Bring back and update the configuration for the rockchip rk3399 built by firefly.

[Roberto Medina <robertoxmed@gmail.com>]

Hi Kilian,

Thanks for reviewing as usual.

On 8/11/23 21:02, Kilian Zinnecker wrote:
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index 6ffa3ee693..5ebabd01cb 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -2546,6 +2546,10 @@ F:	package/mhz/
>>   N:	Robert Rose <robertroyrose@gmail.com>
>>   F:	package/grpc/
>>
>> +N:	Roberto Medina <robertoxmed@gmail.com>
>> +F:	configs/roc_pc_rk3399_defconfig
>> +F:	board/firefly/roc-rk3399
> 
> I think when it comes to repositories (i.e., board/firefly/roc-rk3399) it is
> best practice to add a trailing space. I guess this way one can easily
> distinguish directories from single files.

Noted for the trailing slash.

>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.04"
> 
> I think 2022.04 is actually the current default version of buildroot. So
> unless you have reason to freeze it to this version on purpose (e.g., because
> older and newer versions are known to be not working with this board - which I
> don't believe is the case) you could simply omit these two lines.

Actually in v2 of this patch, Thomas requested to set a fixed version 
for U-Boot (mail from 08/08). Which made sense to me as TFA and Linux 
have a fixed version as well.

Best,
Roberto
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot