From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Yu Chien Peter Lin <peterlin@andestech.com>
Cc: ycliang@andestech.com, kilian.zinnecker@mail.de, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
Date: Mon, 14 Aug 2023 16:39:46 +0200 [thread overview]
Message-ID: <20230814163946.5bc5e75d@windsurf> (raw)
In-Reply-To: <20230814024834.11369-2-peterlin@andestech.com>
On Mon, 14 Aug 2023 10:48:34 +0800
Yu Chien Peter Lin <peterlin@andestech.com> wrote:
> The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension,
> so we select it to enable and use glibc by default.
Thanks for the patch. However, the commit log is not a proper
justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if
the hardware supports it, not because glibc needs it. If glibc needs
it, but the hardware doesn't support this instruction set extension, it
doesn't make sense to enable it.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-14 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 2:48 [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yu Chien Peter Lin
2023-08-14 2:48 ` [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform Yu Chien Peter Lin
2023-08-14 14:39 ` Thomas Petazzoni via buildroot [this message]
2023-08-15 1:10 ` Yu-Chien Peter Lin
2023-08-14 12:14 ` [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814163946.5bc5e75d@windsurf \
--to=buildroot@buildroot.org \
--cc=kilian.zinnecker@mail.de \
--cc=peterlin@andestech.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox