* [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei
@ 2023-08-14 2:48 Yu Chien Peter Lin
2023-08-14 2:48 ` [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform Yu Chien Peter Lin
2023-08-14 12:14 ` [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yann E. MORIN
0 siblings, 2 replies; 5+ messages in thread
From: Yu Chien Peter Lin @ 2023-08-14 2:48 UTC (permalink / raw)
To: buildroot; +Cc: Yu Chien Peter Lin, ycliang, kilian.zinnecker, thomas.petazzoni
Don't specify the ARCH_FLAGS of U-Boot, so both extensions can be
appended to -march when building w/ gcc-12.
Fixes:
- https://gitlab.com/buildroot.org/buildroot/-/jobs/4839059655
Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
---
configs/andes_ae350_45_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
index 998276635b..ef29ab6454 100644
--- a/configs/andes_ae350_45_defconfig
+++ b/configs/andes_ae350_45_defconfig
@@ -38,7 +38,6 @@ BR2_TARGET_UBOOT_NEEDS_OPENSBI=y
BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
BR2_TARGET_UBOOT_SPL=y
-BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc"
BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_GENIMAGE=y
BR2_PACKAGE_HOST_MTOOLS=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
2023-08-14 2:48 [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yu Chien Peter Lin
@ 2023-08-14 2:48 ` Yu Chien Peter Lin
2023-08-14 14:39 ` Thomas Petazzoni via buildroot
2023-08-14 12:14 ` [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yann E. MORIN
1 sibling, 1 reply; 5+ messages in thread
From: Yu Chien Peter Lin @ 2023-08-14 2:48 UTC (permalink / raw)
To: buildroot; +Cc: Yu Chien Peter Lin, ycliang, kilian.zinnecker, thomas.petazzoni
The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension,
so we select it to enable and use glibc by default.
Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
---
configs/andes_ae350_45_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
index ef29ab6454..4e4c38dc21 100644
--- a/configs/andes_ae350_45_defconfig
+++ b/configs/andes_ae350_45_defconfig
@@ -1,6 +1,7 @@
BR2_riscv=y
BR2_riscv_custom=y
BR2_RISCV_ISA_CUSTOM_RVM=y
+BR2_RISCV_ISA_CUSTOM_RVA=y
BR2_RISCV_ISA_CUSTOM_RVF=y
BR2_RISCV_ISA_CUSTOM_RVD=y
BR2_RISCV_ISA_CUSTOM_RVC=y
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
2023-08-14 2:48 ` [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform Yu Chien Peter Lin
@ 2023-08-14 14:39 ` Thomas Petazzoni via buildroot
2023-08-15 1:10 ` Yu-Chien Peter Lin
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-14 14:39 UTC (permalink / raw)
To: Yu Chien Peter Lin; +Cc: ycliang, kilian.zinnecker, buildroot
On Mon, 14 Aug 2023 10:48:34 +0800
Yu Chien Peter Lin <peterlin@andestech.com> wrote:
> The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension,
> so we select it to enable and use glibc by default.
Thanks for the patch. However, the commit log is not a proper
justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if
the hardware supports it, not because glibc needs it. If glibc needs
it, but the hardware doesn't support this instruction set extension, it
doesn't make sense to enable it.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform
2023-08-14 14:39 ` Thomas Petazzoni via buildroot
@ 2023-08-15 1:10 ` Yu-Chien Peter Lin
0 siblings, 0 replies; 5+ messages in thread
From: Yu-Chien Peter Lin @ 2023-08-15 1:10 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: ycliang, kilian.zinnecker, buildroot
On Mon, Aug 14, 2023 at 04:39:46PM +0200, Thomas Petazzoni wrote:
> On Mon, 14 Aug 2023 10:48:34 +0800
> Yu Chien Peter Lin <peterlin@andestech.com> wrote:
>
> > The BR2_PACKAGE_GLIBC_ARCH_SUPPORTS requires the RVA extension,
> > so we select it to enable and use glibc by default.
>
> Thanks for the patch. However, the commit log is not a proper
> justification. Indeed, BR2_RISCV_ISA_CUSTOM_RVA should be enabled if
> the hardware supports it, not because glibc needs it. If glibc needs
> it, but the hardware doesn't support this instruction set extension, it
> doesn't make sense to enable it.
No problem, will reword properly in the next patch.
Thanks!
Peter Lin
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei
2023-08-14 2:48 [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yu Chien Peter Lin
2023-08-14 2:48 ` [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform Yu Chien Peter Lin
@ 2023-08-14 12:14 ` Yann E. MORIN
1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2023-08-14 12:14 UTC (permalink / raw)
To: Yu Chien Peter Lin; +Cc: ycliang, kilian.zinnecker, thomas.petazzoni, buildroot
Yu Chien Peter Lin, All,
On 2023-08-14 10:48 +0800, Yu Chien Peter Lin spake thusly:
> Don't specify the ARCH_FLAGS of U-Boot, so both extensions can be
> appended to -march when building w/ gcc-12.
>
> Fixes:
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4839059655
>
> Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> configs/andes_ae350_45_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/andes_ae350_45_defconfig b/configs/andes_ae350_45_defconfig
> index 998276635b..ef29ab6454 100644
> --- a/configs/andes_ae350_45_defconfig
> +++ b/configs/andes_ae350_45_defconfig
> @@ -38,7 +38,6 @@ BR2_TARGET_UBOOT_NEEDS_OPENSBI=y
> BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
> BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
> BR2_TARGET_UBOOT_SPL=y
> -BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="ARCH_FLAGS=-march=rv64imafdc"
> BR2_PACKAGE_HOST_DOSFSTOOLS=y
> BR2_PACKAGE_HOST_GENIMAGE=y
> BR2_PACKAGE_HOST_MTOOLS=y
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-15 1:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-14 2:48 [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yu Chien Peter Lin
2023-08-14 2:48 ` [Buildroot] [PATCH 2/2] configs/andes_ae350_45: Select RVA for AE350 platform Yu Chien Peter Lin
2023-08-14 14:39 ` Thomas Petazzoni via buildroot
2023-08-15 1:10 ` Yu-Chien Peter Lin
2023-08-14 12:14 ` [Buildroot] [PATCH 1/2] configs/andes_ae350_45: Fix build failure caused by Zicsr and Zifencei Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox