From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: Eugene Tarassov <eugene@largest.net>,
Norbert Lange <nolange79@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/tcf-agent: fix uClibc-ng compile on ARM
Date: Thu, 17 Aug 2023 11:59:17 +0200 [thread overview]
Message-ID: <20230817115917.3e2b374b@windsurf> (raw)
In-Reply-To: <ZNryrsoZV6f+TZll@waldemar-brodkorb.de>
On Tue, 15 Aug 2023 05:36:14 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> > What is the situation with musl?
>
> Musl works fine with static and shared without this patch.
> How should a v2 look like?
Is there a reason why uClibc-ng doesn't support getauxval() with static
linking? If musl does it, probably it can be done?
Otherwise, if we want to stick to that, it could be:
# Some good explanation goes here
ifeq ($(BR2_STATIC_LIBS)$(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_ARM_INSTRUCTIONS_THUMB),yyy)
TCF_AGENT_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -marm"
endif
> > Also, shouldn't the horrible "# define USE_getauxval
> > (defined(__GLIBC__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 &&
> > __GLIBC_MINOR__ >= 16)) || (defined(__UCLIBC__) &&
> > defined(__HAVE_SHARED__)))" be turned into a proper CMake test ?
>
> That might be something upstream should do. :)
Well, we generally try to have upstreamable patches in Buildroot, and
the project seems relatively active
(https://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/log/), so
there is a good chance to get our patch merged.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-17 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 7:23 [Buildroot] [PATCH 2/2] package/tcf-agent: fix uClibc-ng compile on ARM Waldemar Brodkorb
2023-08-14 14:53 ` Thomas Petazzoni via buildroot
2023-08-15 3:36 ` Waldemar Brodkorb
2023-08-17 9:59 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817115917.3e2b374b@windsurf \
--to=buildroot@buildroot.org \
--cc=eugene@largest.net \
--cc=nolange79@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox