Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Waldemar Brodkorb <wbx@openadk.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Eugene Tarassov <eugene@largest.net>,
	Norbert Lange <nolange79@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/tcf-agent: fix uClibc-ng compile on ARM
Date: Tue, 15 Aug 2023 05:36:14 +0200	[thread overview]
Message-ID: <ZNryrsoZV6f+TZll@waldemar-brodkorb.de> (raw)
In-Reply-To: <20230814165343.2e3936c6@windsurf>

Hi Thomas,
Thomas Petazzoni wrote,

> On Sun, 13 Aug 2023 09:23:44 +0200
> Waldemar Brodkorb <wbx@openadk.org> wrote:
> 
> > +ifeq ($(BR2_STATIC_LIBS),y)
> > +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> > +TCF_AGENT_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -marm"
> > +endif
> > +endif
> 
> What is the situation with musl?

Musl works fine with static and shared without this patch.
How should a v2 look like? 
 
> With glibc, BR2_STATIC_LIBS=y is impossible.
> 
> But with musl, BR2_STATIC_LIBS=y is possible. Is getauxval() always
> supported on musl, regardless of static or shared?

Yes.
 
> Also, shouldn't the horrible "#  define USE_getauxval
> (defined(__GLIBC__) && (__GLIBC__ > 2 || (__GLIBC__ == 2 &&
> __GLIBC_MINOR__ >= 16)) || (defined(__UCLIBC__) &&
> defined(__HAVE_SHARED__)))" be turned into a proper CMake test ?

That might be something upstream should do. :)

best regards
 Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-15  3:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-13  7:23 [Buildroot] [PATCH 2/2] package/tcf-agent: fix uClibc-ng compile on ARM Waldemar Brodkorb
2023-08-14 14:53 ` Thomas Petazzoni via buildroot
2023-08-15  3:36   ` Waldemar Brodkorb [this message]
2023-08-17  9:59     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNryrsoZV6f+TZll@waldemar-brodkorb.de \
    --to=wbx@openadk.org \
    --cc=buildroot@buildroot.org \
    --cc=eugene@largest.net \
    --cc=nolange79@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox