* [Buildroot] [PATCH] package/gmp: guard riscv definition
@ 2023-08-24 5:02 Waldemar Brodkorb
2023-08-24 18:54 ` Thomas Petazzoni via buildroot
2023-09-13 15:53 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2023-08-24 5:02 UTC (permalink / raw)
To: buildroot
In commit 30997eaa65438a2ce726ad8a204ac5a36363f5c8 a mistake
was made. Guard the definition correctly.
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
package/gmp/gmp.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/gmp/gmp.mk b/package/gmp/gmp.mk
index 3b732dfa71..1ef4dd43a2 100644
--- a/package/gmp/gmp.mk
+++ b/package/gmp/gmp.mk
@@ -24,9 +24,11 @@ GMP_CONF_OPTS += --disable-assembly
endif
# GMP needs M extension for riscv assembly
+ifeq ($(BR2_riscv),y)
ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),)
GMP_CONF_OPTS += --disable-assembly
endif
+endif
ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
GMP_CONF_OPTS += --enable-cxx
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/gmp: guard riscv definition
2023-08-24 5:02 [Buildroot] [PATCH] package/gmp: guard riscv definition Waldemar Brodkorb
@ 2023-08-24 18:54 ` Thomas Petazzoni via buildroot
2023-09-13 15:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-24 18:54 UTC (permalink / raw)
To: Waldemar Brodkorb; +Cc: buildroot
On Thu, 24 Aug 2023 07:02:26 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> # GMP needs M extension for riscv assembly
> +ifeq ($(BR2_riscv),y)
> ifeq ($(BR2_RISCV_ISA_CUSTOM_RVM),)
Changed to:
+ifeq ($(BR2_riscv):$(BR2_RISCV_ISA_CUSTOM_RVM),y:)
and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/gmp: guard riscv definition
2023-08-24 5:02 [Buildroot] [PATCH] package/gmp: guard riscv definition Waldemar Brodkorb
2023-08-24 18:54 ` Thomas Petazzoni via buildroot
@ 2023-09-13 15:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2023-09-13 15:53 UTC (permalink / raw)
To: Waldemar Brodkorb; +Cc: buildroot
>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:
> In commit 30997eaa65438a2ce726ad8a204ac5a36363f5c8 a mistake
> was made. Guard the definition correctly.
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-13 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 5:02 [Buildroot] [PATCH] package/gmp: guard riscv definition Waldemar Brodkorb
2023-08-24 18:54 ` Thomas Petazzoni via buildroot
2023-09-13 15:53 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox