Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig
@ 2023-08-26 16:56 Romain Naour
  2023-08-26 16:56 ` [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38 Romain Naour
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Romain Naour @ 2023-08-26 16:56 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y
symbol was not removed. Since then this defconfig fail to build
in gitlab-ci due to invalid defconfig check.

  WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
        Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version)
and binutils 2.39+. But it should be backported up to 2023.02.
---
 configs/freescale_imx6qsabresd_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/freescale_imx6qsabresd_defconfig b/configs/freescale_imx6qsabresd_defconfig
index 86513d8072..dddfaf5228 100644
--- a/configs/freescale_imx6qsabresd_defconfig
+++ b/configs/freescale_imx6qsabresd_defconfig
@@ -37,7 +37,6 @@ BR2_PACKAGE_HOST_MTOOLS=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6qsabresd"
 BR2_TARGET_UBOOT_FORMAT_IMX=y
-BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
 BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,nxp-imx,uboot-imx,lf-5.10.y-1.0.0)/uboot-imx-lf-5.10.y-1.0.0.tar.gz"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38
  2023-08-26 16:56 [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Romain Naour
@ 2023-08-26 16:56 ` Romain Naour
  2023-08-26 18:06   ` Thomas Petazzoni via buildroot
  2023-08-26 18:06 ` [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Thomas Petazzoni via buildroot
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Romain Naour @ 2023-08-26 16:56 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour

Backport an upstream patch fixing the build with binutils >= 2.38
for riscv's for Zicsr and Zifencei.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949340
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949329

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
All four sipeed_maix* defconfigs sipeed_maix_bit_sdcard_defconfig,
sipeed_maix_dock_sdcard_defconfig, sipeed_maixduino_sdcard_defconfig
and sipeed_maix_go_sdcard_defconfig are using the same uboot version.
Only two were fixed by the previous commit ef4eea32261ed3f21af119936a080cb2fc8897fa
"configs/sipeed_maix_{bit, dock}_sdcard_defconfig: fix build with binutils >= 2.38"
---
 configs/sipeed_maix_go_sdcard_defconfig   | 1 +
 configs/sipeed_maixduino_sdcard_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/sipeed_maix_go_sdcard_defconfig b/configs/sipeed_maix_go_sdcard_defconfig
index 6c61e3aaaf..2bea0b97be 100644
--- a/configs/sipeed_maix_go_sdcard_defconfig
+++ b/configs/sipeed_maix_go_sdcard_defconfig
@@ -17,6 +17,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_19=y
 BR2_BINFMT_FLAT=y
 BR2_BINFMT_FLAT_ONE=y
 # BR2_TARGET_ENABLE_ROOT_LOGIN is not set
+BR2_GLOBAL_PATCH_DIR="board/canaan/k210-soc/patches"
 
 # Kernel
 BR2_LINUX_KERNEL=y
diff --git a/configs/sipeed_maixduino_sdcard_defconfig b/configs/sipeed_maixduino_sdcard_defconfig
index da8cbe45f9..db7896fadf 100644
--- a/configs/sipeed_maixduino_sdcard_defconfig
+++ b/configs/sipeed_maixduino_sdcard_defconfig
@@ -17,6 +17,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_19=y
 BR2_BINFMT_FLAT=y
 BR2_BINFMT_FLAT_ONE=y
 # BR2_TARGET_ENABLE_ROOT_LOGIN is not set
+BR2_GLOBAL_PATCH_DIR="board/canaan/k210-soc/patches"
 
 # Kernel
 BR2_LINUX_KERNEL=y
-- 
2.41.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig
  2023-08-26 16:56 [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Romain Naour
  2023-08-26 16:56 ` [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38 Romain Naour
@ 2023-08-26 18:06 ` Thomas Petazzoni via buildroot
  2023-08-26 18:18 ` Fabio Estevam
  2023-09-13 18:55 ` Peter Korsgaard
  3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-26 18:06 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

On Sat, 26 Aug 2023 18:56:27 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y
> symbol was not removed. Since then this defconfig fail to build
> in gitlab-ci due to invalid defconfig check.
> 
>   WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
>         Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y
> 
> [1] dd42b159a5f752921ee602530d289c810ad7ee51
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> This defconfig will fail anyway due to too old ATF package (pre V2.9 version)
> and binutils 2.39+. But it should be backported up to 2023.02.
> ---
>  configs/freescale_imx6qsabresd_defconfig | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38
  2023-08-26 16:56 ` [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38 Romain Naour
@ 2023-08-26 18:06   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-08-26 18:06 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

On Sat, 26 Aug 2023 18:56:28 +0200
Romain Naour <romain.naour@gmail.com> wrote:

> Backport an upstream patch fixing the build with binutils >= 2.38
> for riscv's for Zicsr and Zifencei.
> 
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949340
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949329
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> All four sipeed_maix* defconfigs sipeed_maix_bit_sdcard_defconfig,
> sipeed_maix_dock_sdcard_defconfig, sipeed_maixduino_sdcard_defconfig
> and sipeed_maix_go_sdcard_defconfig are using the same uboot version.
> Only two were fixed by the previous commit ef4eea32261ed3f21af119936a080cb2fc8897fa
> "configs/sipeed_maix_{bit, dock}_sdcard_defconfig: fix build with binutils >= 2.38"
> ---
>  configs/sipeed_maix_go_sdcard_defconfig   | 1 +
>  configs/sipeed_maixduino_sdcard_defconfig | 1 +
>  2 files changed, 2 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig
  2023-08-26 16:56 [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Romain Naour
  2023-08-26 16:56 ` [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38 Romain Naour
  2023-08-26 18:06 ` [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Thomas Petazzoni via buildroot
@ 2023-08-26 18:18 ` Fabio Estevam
  2023-08-26 19:23   ` Romain Naour
  2023-09-13 18:55 ` Peter Korsgaard
  3 siblings, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2023-08-26 18:18 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

Hi Romain,

On Sat, Aug 26, 2023 at 1:56 PM Romain Naour <romain.naour@gmail.com> wrote:
>
> While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y

ATF?

I think you meant:

"While switching the kernel repository from codeaurora to github"

> symbol was not removed. Since then this defconfig fail to build
> in gitlab-ci due to invalid defconfig check.
>
>   WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
>         Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y
>
> [1] dd42b159a5f752921ee602530d289c810ad7ee51
>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> This defconfig will fail anyway due to too old ATF package (pre V2.9 version)
> and binutils 2.39+. But it should be backported up to 2023.02.

I am confused by this statement as this defconfig does not use ATF.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig
  2023-08-26 18:18 ` Fabio Estevam
@ 2023-08-26 19:23   ` Romain Naour
  0 siblings, 0 replies; 7+ messages in thread
From: Romain Naour @ 2023-08-26 19:23 UTC (permalink / raw)
  To: Fabio Estevam, Romain Naour; +Cc: buildroot

Hello Fabio,

Le 26/08/2023 à 20:18, Fabio Estevam a écrit :
> Hi Romain,
> 
> On Sat, Aug 26, 2023 at 1:56 PM Romain Naour <romain.naour@gmail.com> wrote:
>>
>> While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y
> 
> ATF?

My bad, I was looking at other imx/freescale defconfig while working on this
one. I've read BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y (I don't know how...)

> 
> I think you meant:
> 
> "While switching the kernel repository from codeaurora to github"

Indeed.

> 
>> symbol was not removed. Since then this defconfig fail to build
>> in gitlab-ci due to invalid defconfig check.
>>
>>   WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
>>         Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y
>>
>> [1] dd42b159a5f752921ee602530d289c810ad7ee51
>>
>> Fixes:
>> https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>> This defconfig will fail anyway due to too old ATF package (pre V2.9 version)
>> and binutils 2.39+. But it should be backported up to 2023.02.
> 
> I am confused by this statement as this defconfig does not use ATF.

Me too now, I should double check commits made late in the evening before
sending it to the mailing list.

I did a full build without any other issue. Still this patch needs to be backported.

Best regards,
Romain


> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig
  2023-08-26 16:56 [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Romain Naour
                   ` (2 preceding siblings ...)
  2023-08-26 18:18 ` Fabio Estevam
@ 2023-09-13 18:55 ` Peter Korsgaard
  3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2023-09-13 18:55 UTC (permalink / raw)
  To: Romain Naour; +Cc: buildroot

>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:

 > While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y
 > symbol was not removed. Since then this defconfig fail to build
 > in gitlab-ci due to invalid defconfig check.

 >   WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
 >         Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

 > [1] dd42b159a5f752921ee602530d289c810ad7ee51

 > Fixes:
 > https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

 > Signed-off-by: Romain Naour <romain.naour@gmail.com>
 > ---
 > This defconfig will fail anyway due to too old ATF package (pre V2.9 version)
 > and binutils 2.39+. But it should be backported up to 2023.02.

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-09-13 18:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-26 16:56 [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Romain Naour
2023-08-26 16:56 ` [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38 Romain Naour
2023-08-26 18:06   ` Thomas Petazzoni via buildroot
2023-08-26 18:06 ` [Buildroot] [PATCH] configs/freescale_imx6qsabresd_defconfig: fix defconfig Thomas Petazzoni via buildroot
2023-08-26 18:18 ` Fabio Estevam
2023-08-26 19:23   ` Romain Naour
2023-09-13 18:55 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox