Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error
@ 2023-09-19  8:10 Jamie Gibbons via buildroot
  2023-09-19  8:41 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Jamie Gibbons via buildroot @ 2023-09-19  8:10 UTC (permalink / raw)
  To: buildroot
  Cc: Conor Dooley, Nicolas Ferre, Ludovic Desroches, Thomas Petazzoni,
	Valentina Fernandez Alanis, Jamie Gibbons

Build is failing with an unrecognised opcode error due to missing
`zicsr` extension requirement. This is introduced with GCC version 12.
All our current defconfigs use GCC version 11. Add GCC version 11
kconfig to fix this build error and align with our downstream
Buildroot-External defconfigs.

Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>
---
 configs/microchip_mpfs_icicle_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
index 54a4d55a5f..c003f70798 100644
--- a/configs/microchip_mpfs_icicle_defconfig
+++ b/configs/microchip_mpfs_icicle_defconfig
@@ -1,7 +1,7 @@
 BR2_riscv=y
-BR2_riscv_g=y
 BR2_RISCV_ISA_RVC=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
+BR2_GCC_VERSION_11_X=y
 BR2_TARGET_GENERIC_HOSTNAME="mpfs_icicle"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/microchip/mpfs_icicle/post-image.sh"
 BR2_LINUX_KERNEL=y
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error
  2023-09-19  8:10 [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error Jamie Gibbons via buildroot
@ 2023-09-19  8:41 ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-09-19  8:41 UTC (permalink / raw)
  To: Jamie Gibbons via buildroot
  Cc: Valentina Fernandez Alanis, Jamie Gibbons, Ludovic Desroches,
	Conor Dooley, Nicolas Ferre

Hello Jamie,

On Tue, 19 Sep 2023 09:10:12 +0100
Jamie Gibbons via buildroot <buildroot@buildroot.org> wrote:

> Build is failing with an unrecognised opcode error due to missing
> `zicsr` extension requirement. This is introduced with GCC version 12.
> All our current defconfigs use GCC version 11. Add GCC version 11
> kconfig to fix this build error and align with our downstream
> Buildroot-External defconfigs.
> 
> Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>

Hm, we really want to fix this the proper, aka make this work with GCC
12+. Indeed as soon as GCC 14.x lands, we will drop support for GCC
11.x, so the solution proposed here really isn't suitable :-/

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error
@ 2023-10-02 10:53 Jamie Gibbons via buildroot
  2023-11-01 10:52 ` Jamie.Gibbons--- via buildroot
  2023-11-01 12:56 ` Yann E. MORIN
  0 siblings, 2 replies; 5+ messages in thread
From: Jamie Gibbons via buildroot @ 2023-10-02 10:53 UTC (permalink / raw)
  To: buildroot
  Cc: Conor Dooley, Nicolas Ferre, Ludovic Desroches, Thomas Petazzoni,
	Valentina Fernandez Alanis, Jamie Gibbons

Build is failing with an unrecognised opcode error due to missing
`zicsr` extension requirement. This is introduced with GCC version 12.
When binutils was updated to v2.38 they updated to the default ISA spec
version 20191213. In this version the original i extension split into i,
Zicsr and Zifencei. A fix for this has been added since U-Boot version
2022.01 to detect new Zicsr and Zifencei extensions and enable it when needed
therefore, an updated U-Boot tag to our latest 2023.09 release will fix
this as in our latest release we have updated to U-Boot version 2023.07.
Update the kernel verion in line with the U-Boot release version to
ensure compatiblities and latest features and fixes are included.
Remove riscv_g selection as it is now selected by default.

Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>
---
 configs/microchip_mpfs_icicle_defconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
index 54a4d55a5f..1af7a3c474 100644
--- a/configs/microchip_mpfs_icicle_defconfig
+++ b/configs/microchip_mpfs_icicle_defconfig
@@ -1,12 +1,11 @@
 BR2_riscv=y
-BR2_riscv_g=y
 BR2_RISCV_ISA_RVC=y
 BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 BR2_TARGET_GENERIC_HOSTNAME="mpfs_icicle"
 BR2_ROOTFS_POST_IMAGE_SCRIPT="board/microchip/mpfs_icicle/post-image.sh"
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
-BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,linux4microchip,linux,linux-6.1-mchp+fpga)/linux4microchip+fpga-2023.06.tar.gz"
+BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,linux4microchip,linux,linux-6.1-mchp+fpga)/linux4microchip+fpga-2023.09.tar.gz"
 BR2_LINUX_KERNEL_DEFCONFIG="mpfs"
 BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/linux.fragment"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
@@ -16,7 +15,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
-BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-soc,u-boot)linux4microchip+fpga-2023.06.tar.gz"
+BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-soc,u-boot)linux4microchip+fpga-2023.09.tar.gz"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="microchip_mpfs_icicle"
 BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/uboot-fragment-rootfs.config"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error
  2023-10-02 10:53 Jamie Gibbons via buildroot
@ 2023-11-01 10:52 ` Jamie.Gibbons--- via buildroot
  2023-11-01 12:56 ` Yann E. MORIN
  1 sibling, 0 replies; 5+ messages in thread
From: Jamie.Gibbons--- via buildroot @ 2023-11-01 10:52 UTC (permalink / raw)
  To: buildroot
  Cc: Valentina.FernandezAlanis, Ludovic.Desroches, Nicolas.Ferre,
	thomas.petazzoni, Conor.Dooley

Hi all,

Is there anything missing/stopping this patch from being merged? It
fixes the reported microchip_mpfs_icicle_defconfig build error.

Thanks,
Jamie.

On Mon, 2023-10-02 at 11:53 +0100, Jamie Gibbons wrote:
> Build is failing with an unrecognised opcode error due to missing
> `zicsr` extension requirement. This is introduced with GCC version 12.
> When binutils was updated to v2.38 they updated to the default ISA
> spec
> version 20191213. In this version the original i extension split into
> i,
> Zicsr and Zifencei. A fix for this has been added since U-Boot version
> 2022.01 to detect new Zicsr and Zifencei extensions and enable it when
> needed
> therefore, an updated U-Boot tag to our latest 2023.09 release will
> fix
> this as in our latest release we have updated to U-Boot version
> 2023.07.
> Update the kernel verion in line with the U-Boot release version to
> ensure compatiblities and latest features and fixes are included.
> Remove riscv_g selection as it is now selected by default.
> 
> Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>
> ---
>  configs/microchip_mpfs_icicle_defconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/configs/microchip_mpfs_icicle_defconfig
> b/configs/microchip_mpfs_icicle_defconfig
> index 54a4d55a5f..1af7a3c474 100644
> --- a/configs/microchip_mpfs_icicle_defconfig
> +++ b/configs/microchip_mpfs_icicle_defconfig
> @@ -1,12 +1,11 @@
>  BR2_riscv=y
> -BR2_riscv_g=y
>  BR2_RISCV_ISA_RVC=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
>  BR2_TARGET_GENERIC_HOSTNAME="mpfs_icicle"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/microchip/mpfs_icicle/post-
> image.sh"
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call
> github,linux4microchip,linux,linux-6.1-
> mchp+fpga)/linux4microchip+fpga-2023.06.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call
> github,linux4microchip,linux,linux-6.1-
> mchp+fpga)/linux4microchip+fpga-2023.09.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="mpfs"
>  BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/l
> inux.fragment"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -16,7 +15,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> -BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-
> soc,u-boot)linux4microchip+fpga-2023.06.tar.gz"
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-
> soc,u-boot)linux4microchip+fpga-2023.09.tar.gz"
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="microchip_mpfs_icicle"
>  BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/u
> boot-fragment-rootfs.config"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error
  2023-10-02 10:53 Jamie Gibbons via buildroot
  2023-11-01 10:52 ` Jamie.Gibbons--- via buildroot
@ 2023-11-01 12:56 ` Yann E. MORIN
  1 sibling, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2023-11-01 12:56 UTC (permalink / raw)
  To: Jamie Gibbons
  Cc: Ludovic Desroches, Nicolas Ferre, Conor Dooley, Thomas Petazzoni,
	buildroot, Valentina Fernandez Alanis

Jamie, All,

On 2023-10-02 11:53 +0100, Jamie Gibbons via buildroot spake thusly:
> Build is failing with an unrecognised opcode error due to missing
> `zicsr` extension requirement. This is introduced with GCC version 12.
> When binutils was updated to v2.38 they updated to the default ISA spec
> version 20191213. In this version the original i extension split into i,
> Zicsr and Zifencei. A fix for this has been added since U-Boot version
> 2022.01 to detect new Zicsr and Zifencei extensions and enable it when needed
> therefore, an updated U-Boot tag to our latest 2023.09 release will fix
> this as in our latest release we have updated to U-Boot version 2023.07.
> Update the kernel verion in line with the U-Boot release version to
> ensure compatiblities and latest features and fixes are included.
> Remove riscv_g selection as it is now selected by default.
> 
> Signed-off-by: Jamie Gibbons <jamie.gibbons@microchip.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  configs/microchip_mpfs_icicle_defconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
> index 54a4d55a5f..1af7a3c474 100644
> --- a/configs/microchip_mpfs_icicle_defconfig
> +++ b/configs/microchip_mpfs_icicle_defconfig
> @@ -1,12 +1,11 @@
>  BR2_riscv=y
> -BR2_riscv_g=y
>  BR2_RISCV_ISA_RVC=y
>  BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
>  BR2_TARGET_GENERIC_HOSTNAME="mpfs_icicle"
>  BR2_ROOTFS_POST_IMAGE_SCRIPT="board/microchip/mpfs_icicle/post-image.sh"
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> -BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,linux4microchip,linux,linux-6.1-mchp+fpga)/linux4microchip+fpga-2023.06.tar.gz"
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,linux4microchip,linux,linux-6.1-mchp+fpga)/linux4microchip+fpga-2023.09.tar.gz"
>  BR2_LINUX_KERNEL_DEFCONFIG="mpfs"
>  BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/linux.fragment"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
> @@ -16,7 +15,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> -BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-soc,u-boot)linux4microchip+fpga-2023.06.tar.gz"
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,polarfire-soc,u-boot)linux4microchip+fpga-2023.09.tar.gz"
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="microchip_mpfs_icicle"
>  BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/microchip/mpfs_icicle/uboot-fragment-rootfs.config"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-01 12:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19  8:10 [Buildroot] [PATCH 1/1] configs/microchip_mpfs_icicle_defconfig: fix zicsr build error Jamie Gibbons via buildroot
2023-09-19  8:41 ` Thomas Petazzoni via buildroot
  -- strict thread matches above, loose matches on Subject: below --
2023-10-02 10:53 Jamie Gibbons via buildroot
2023-11-01 10:52 ` Jamie.Gibbons--- via buildroot
2023-11-01 12:56 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox