Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/mxt-app: new package
@ 2023-09-19 12:55 kazemi.ms
  2023-09-19 13:19 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 6+ messages in thread
From: kazemi.ms @ 2023-09-19 12:55 UTC (permalink / raw)
  To: buildroot; +Cc: Saeed Kazemi, Thomas Petazzoni

From: Saeed Kazemi <kazemi.ms@gmail.com>

mxt-app is a utility for managing Atmel maXTouch touch controllers
and other devices that support Atmel Object Based Protocol.

Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>
---
 package/Config.in            |  1 +
 package/mxt-app/Config.in    |  8 ++++++++
 package/mxt-app/mxt-app.hash |  2 ++
 package/mxt-app/mxt-app.mk   | 20 ++++++++++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 package/mxt-app/Config.in
 create mode 100644 package/mxt-app/mxt-app.hash
 create mode 100644 package/mxt-app/mxt-app.mk

diff --git a/package/Config.in b/package/Config.in
index e8dbadadf3..e8d39b74b8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -556,6 +556,7 @@ endmenu
 	source "package/mhz/Config.in"
 	source "package/minicom/Config.in"
 	source "package/msr-tools/Config.in"
+	source "package/mxt-app/Config.in"
 	source "package/nanocom/Config.in"
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
new file mode 100644
index 0000000000..7e8a5f4901
--- /dev/null
+++ b/package/mxt-app/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_MXT_APP
+	bool "mxt-app"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  mxt-app is a utility for managing Atmel maXTouch touch controllers
+	  and other devices that support Atmel Object Based Protocol.
+
+	  https://github.com/atmel-maxtouch/mxt-app/
diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
new file mode 100644
index 0000000000..abf20c728a
--- /dev/null
+++ b/package/mxt-app/mxt-app.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256  3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722  v1.36.tar.gz
diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
new file mode 100644
index 0000000000..626cd352fc
--- /dev/null
+++ b/package/mxt-app/mxt-app.mk
@@ -0,0 +1,20 @@
+################################################################################
+#
+# mxt-app
+#
+################################################################################
+
+MXT_APP_VERSION = 1.36
+MXT_APP_SOURCE = v$(MXT_APP_VERSION).tar.gz
+MXT_APP_SITE = https://github.com/atmel-maxtouch/mxt-app/archive/refs/tags
+MXT_APP_LICENSE = Atmel License
+MXT_APP_LICENSE_FILES = LICENSE
+MXT_APP_DEPENDENCIES = libusb
+MXT_APP_INSTALL_STAGING = YES
+MXT_APP_AUTORECONF = YES
+MXT_APP_CONF_OPTS = --enable-debug
+
+MXT_APP_CXXFLAGS = $(TARGET_CXXFLAGS)
+MXT_APP_CONF_ENV = CXXFLAGS="$(MXT_APP_CXXFLAGS)"
+
+$(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mxt-app: new package
  2023-09-19 12:55 [Buildroot] [PATCH 1/1] package/mxt-app: new package kazemi.ms
@ 2023-09-19 13:19 ` Thomas Petazzoni via buildroot
  2023-09-19 19:54   ` Saeed Kazemi
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-09-19 13:19 UTC (permalink / raw)
  To: kazemi.ms; +Cc: buildroot

Hello,

On Tue, 19 Sep 2023 14:55:42 +0200
kazemi.ms@gmail.com wrote:

> From: Saeed Kazemi <kazemi.ms@gmail.com>
> 
> mxt-app is a utility for managing Atmel maXTouch touch controllers
> and other devices that support Atmel Object Based Protocol.
> 
> Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>

Thanks for this contribution! This looks pretty good, but I have a few
comments below.

> ---
>  package/Config.in            |  1 +
>  package/mxt-app/Config.in    |  8 ++++++++
>  package/mxt-app/mxt-app.hash |  2 ++
>  package/mxt-app/mxt-app.mk   | 20 ++++++++++++++++++++
>  4 files changed, 31 insertions(+)
>  create mode 100644 package/mxt-app/Config.in
>  create mode 100644 package/mxt-app/mxt-app.hash
>  create mode 100644 package/mxt-app/mxt-app.mk

Could you add an entry in the DEVELOPERS file for this package?

> diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
> new file mode 100644
> index 0000000000..7e8a5f4901
> --- /dev/null
> +++ b/package/mxt-app/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_MXT_APP
> +	bool "mxt-app"
> +	select BR2_PACKAGE_LIBUSB

You need to replicate the "depends on" from libusb:

        depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb


> +	help
> +	  mxt-app is a utility for managing Atmel maXTouch touch controllers
> +	  and other devices that support Atmel Object Based Protocol.
> +
> +	  https://github.com/atmel-maxtouch/mxt-app/

And add a Config.in comment:

comment "mxt-app needs a toolchain w/ threads, gcc >= 4.9"
        depends on !BR2_TOOLCHAIN_HAS_THREADS || \
                !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9


> diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
> new file mode 100644
> index 0000000000..abf20c728a
> --- /dev/null
> +++ b/package/mxt-app/mxt-app.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256  3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722  v1.36.tar.gz

We need the hash of the license file to be present.

> diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
> new file mode 100644
> index 0000000000..626cd352fc
> --- /dev/null
> +++ b/package/mxt-app/mxt-app.mk
> @@ -0,0 +1,20 @@
> +################################################################################
> +#
> +# mxt-app
> +#
> +################################################################################
> +
> +MXT_APP_VERSION = 1.36
> +MXT_APP_SOURCE = v$(MXT_APP_VERSION).tar.gz
> +MXT_APP_SITE = https://github.com/atmel-maxtouch/mxt-app/archive/refs/tags

Could you use the github macro instead?

MXT_APP_VERSION = 1.36
MXT_APP_SITE = $(call github,atmel-maxtouch,mxt-app,v$(MXT_APP_VERSION))

you will to adjust the hash file accordingly.

> +MXT_APP_LICENSE = Atmel License

The license is actually BSD-2-Clause

> +MXT_APP_LICENSE_FILES = LICENSE
> +MXT_APP_DEPENDENCIES = libusb
> +MXT_APP_INSTALL_STAGING = YES
> +MXT_APP_AUTORECONF = YES
> +MXT_APP_CONF_OPTS = --enable-debug

Why --enable-debug by default?

> +MXT_APP_CXXFLAGS = $(TARGET_CXXFLAGS)
> +MXT_APP_CONF_ENV = CXXFLAGS="$(MXT_APP_CXXFLAGS)"

I'm not sure what's the purpose of those two lines. CXXFLAGS are
already passed by the autotools-package infrastructure in the
environment of the configure script, so this seems redundant.

Could you rework the patch to take into account those suggestions, and
send an updated version?

Also, make sure to:

(1) Run "make check-package" to validate the coding style

(2) Use utils/test-pkg to validate that the package builds fine

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/mxt-app: new package
@ 2023-09-19 19:35 kazemi.ms
  2024-07-12 20:48 ` Arnout Vandecappelle via buildroot
  0 siblings, 1 reply; 6+ messages in thread
From: kazemi.ms @ 2023-09-19 19:35 UTC (permalink / raw)
  To: buildroot; +Cc: Saeed Kazemi, Thomas Petazzoni

From: Saeed Kazemi <kazemi.ms@gmail.com>

mxt-app is a utility for managing Atmel maXTouch touch controllers
and other devices that support Atmel Object Based Protocol.

Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>
---
 DEVELOPERS                   |  3 +++
 package/Config.in            |  1 +
 package/mxt-app/Config.in    | 20 ++++++++++++++++++++
 package/mxt-app/mxt-app.hash |  3 +++
 package/mxt-app/mxt-app.mk   | 19 +++++++++++++++++++
 5 files changed, 46 insertions(+)
 create mode 100644 package/mxt-app/Config.in
 create mode 100644 package/mxt-app/mxt-app.hash
 create mode 100644 package/mxt-app/mxt-app.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index e8b78a8d46..19d637d847 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2604,6 +2604,9 @@ F:	package/agent-proxy/
 N:	Ryan Wilkins <ryan@deadfrog.net>
 F:	package/biosdevname/
 
+N:	Saeed Kazemi <kazemi.ms@gmail.com>
+F:	package/mxt-app/
+
 N:	Sam Lancia <sam@gpsm.co.uk>
 F:	package/lrzip/
 
diff --git a/package/Config.in b/package/Config.in
index e8dbadadf3..e8d39b74b8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -556,6 +556,7 @@ endmenu
 	source "package/mhz/Config.in"
 	source "package/minicom/Config.in"
 	source "package/msr-tools/Config.in"
+	source "package/mxt-app/Config.in"
 	source "package/nanocom/Config.in"
 	source "package/neard/Config.in"
 	source "package/nvidia-driver/Config.in"
diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
new file mode 100644
index 0000000000..2b153901de
--- /dev/null
+++ b/package/mxt-app/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_MXT_APP
+	bool "mxt-app"
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
+	select BR2_PACKAGE_LIBUSB
+	help
+	  mxt-app is a utility for managing Atmel maXTouch touch
+	  controllers and other devices that support Atmel Object Based
+	  Protocol.
+
+	  https://github.com/atmel-maxtouch/mxt-app/
+
+config BR2_PACKAGE_MXT_APP_DEBUG
+	bool "mxt-app debugging"
+	help
+	  Compile mxt-app with debug enabled
+
+comment "mxt-app needs a toolchain w/ threads, gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
new file mode 100644
index 0000000000..b7851cea37
--- /dev/null
+++ b/package/mxt-app/mxt-app.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256  3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722  mxt-app-1.36.tar.gz
+sha256  3682b125a40a4da00b6ab69bdbd38c25ed4beae69b3fe32458d2e32638477c4c  LICENSE
diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
new file mode 100644
index 0000000000..da0aa65328
--- /dev/null
+++ b/package/mxt-app/mxt-app.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# mxt-app
+#
+################################################################################
+
+MXT_APP_VERSION = 1.36
+MXT_APP_SITE = $(call github,atmel-maxtouch,mxt-app,v$(MXT_APP_VERSION))
+MXT_APP_LICENSE = BSD-2-Clause
+MXT_APP_LICENSE_FILES = LICENSE
+MXT_APP_DEPENDENCIES = libusb
+MXT_APP_INSTALL_STAGING = YES
+MXT_APP_AUTORECONF = YES
+
+ifeq ($(BR2_PACKAGE_MXT_APP_DEBUG),y)
+MXT_APP_CONF_OPTS += --enable-debug
+endif
+
+$(eval $(autotools-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mxt-app: new package
  2023-09-19 13:19 ` Thomas Petazzoni via buildroot
@ 2023-09-19 19:54   ` Saeed Kazemi
  0 siblings, 0 replies; 6+ messages in thread
From: Saeed Kazemi @ 2023-09-19 19:54 UTC (permalink / raw)
  To: Thomas Petazzoni; +Cc: buildroot


[-- Attachment #1.1: Type: text/plain, Size: 4180 bytes --]

Hello,
Thanks for your feedback.

I applied your suggestions and also added an option for enabling debug
(disable by default)

Thanks,
Saeed

On Tue, Sep 19, 2023 at 15:19 Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:

> Hello,
>
> On Tue, 19 Sep 2023 14:55:42 +0200
> kazemi.ms@gmail.com wrote:
>
> > From: Saeed Kazemi <kazemi.ms@gmail.com>
> >
> > mxt-app is a utility for managing Atmel maXTouch touch controllers
> > and other devices that support Atmel Object Based Protocol.
> >
> > Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>
>
> Thanks for this contribution! This looks pretty good, but I have a few
> comments below.
>
> > ---
> >  package/Config.in            |  1 +
> >  package/mxt-app/Config.in    |  8 ++++++++
> >  package/mxt-app/mxt-app.hash |  2 ++
> >  package/mxt-app/mxt-app.mk   | 20 ++++++++++++++++++++
> >  4 files changed, 31 insertions(+)
> >  create mode 100644 package/mxt-app/Config.in
> >  create mode 100644 package/mxt-app/mxt-app.hash
> >  create mode 100644 package/mxt-app/mxt-app.mk
>
> Could you add an entry in the DEVELOPERS file for this package?
>
> > diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
> > new file mode 100644
> > index 0000000000..7e8a5f4901
> > --- /dev/null
> > +++ b/package/mxt-app/Config.in
> > @@ -0,0 +1,8 @@
> > +config BR2_PACKAGE_MXT_APP
> > +     bool "mxt-app"
> > +     select BR2_PACKAGE_LIBUSB
>
> You need to replicate the "depends on" from libusb:
>
>         depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
>         depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
>
>
> > +     help
> > +       mxt-app is a utility for managing Atmel maXTouch touch
> controllers
> > +       and other devices that support Atmel Object Based Protocol.
> > +
> > +       https://github.com/atmel-maxtouch/mxt-app/
>
> And add a Config.in comment:
>
> comment "mxt-app needs a toolchain w/ threads, gcc >= 4.9"
>         depends on !BR2_TOOLCHAIN_HAS_THREADS || \
>                 !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>
>
> > diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
> > new file mode 100644
> > index 0000000000..abf20c728a
> > --- /dev/null
> > +++ b/package/mxt-app/mxt-app.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> 3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722
> v1.36.tar.gz
>
> We need the hash of the license file to be present.
>
> > diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
> > new file mode 100644
> > index 0000000000..626cd352fc
> > --- /dev/null
> > +++ b/package/mxt-app/mxt-app.mk
> > @@ -0,0 +1,20 @@
> >
> +################################################################################
> > +#
> > +# mxt-app
> > +#
> >
> +################################################################################
> > +
> > +MXT_APP_VERSION = 1.36
> > +MXT_APP_SOURCE = v$(MXT_APP_VERSION).tar.gz
> > +MXT_APP_SITE =
> https://github.com/atmel-maxtouch/mxt-app/archive/refs/tags
>
> Could you use the github macro instead?
>
> MXT_APP_VERSION = 1.36
> MXT_APP_SITE = $(call github,atmel-maxtouch,mxt-app,v$(MXT_APP_VERSION))
>
> you will to adjust the hash file accordingly.
>
> > +MXT_APP_LICENSE = Atmel License
>
> The license is actually BSD-2-Clause
>
> > +MXT_APP_LICENSE_FILES = LICENSE
> > +MXT_APP_DEPENDENCIES = libusb
> > +MXT_APP_INSTALL_STAGING = YES
> > +MXT_APP_AUTORECONF = YES
> > +MXT_APP_CONF_OPTS = --enable-debug
>
> Why --enable-debug by default?
>
> > +MXT_APP_CXXFLAGS = $(TARGET_CXXFLAGS)
> > +MXT_APP_CONF_ENV = CXXFLAGS="$(MXT_APP_CXXFLAGS)"
>
> I'm not sure what's the purpose of those two lines. CXXFLAGS are
> already passed by the autotools-package infrastructure in the
> environment of the configure script, so this seems redundant.
>
> Could you rework the patch to take into account those suggestions, and
> send an updated version?
>
> Also, make sure to:
>
> (1) Run "make check-package" to validate the coding style
>
> (2) Use utils/test-pkg to validate that the package builds fine
>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 6132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mxt-app: new package
  2023-09-19 19:35 kazemi.ms
@ 2024-07-12 20:48 ` Arnout Vandecappelle via buildroot
  2024-07-12 20:49   ` Arnout Vandecappelle via buildroot
  0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-07-12 20:48 UTC (permalink / raw)
  To: kazemi.ms, buildroot; +Cc: Thomas Petazzoni



On 19/09/2023 21:35, kazemi.ms@gmail.com wrote:
> From: Saeed Kazemi <kazemi.ms@gmail.com>
> 
> mxt-app is a utility for managing Atmel maXTouch touch controllers
> and other devices that support Atmel Object Based Protocol.
> 
> Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   DEVELOPERS                   |  3 +++
>   package/Config.in            |  1 +
>   package/mxt-app/Config.in    | 20 ++++++++++++++++++++
>   package/mxt-app/mxt-app.hash |  3 +++
>   package/mxt-app/mxt-app.mk   | 19 +++++++++++++++++++
>   5 files changed, 46 insertions(+)
>   create mode 100644 package/mxt-app/Config.in
>   create mode 100644 package/mxt-app/mxt-app.hash
>   create mode 100644 package/mxt-app/mxt-app.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index e8b78a8d46..19d637d847 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2604,6 +2604,9 @@ F:	package/agent-proxy/
>   N:	Ryan Wilkins <ryan@deadfrog.net>
>   F:	package/biosdevname/
>   
> +N:	Saeed Kazemi <kazemi.ms@gmail.com>
> +F:	package/mxt-app/
> +
>   N:	Sam Lancia <sam@gpsm.co.uk>
>   F:	package/lrzip/
>   
> diff --git a/package/Config.in b/package/Config.in
> index e8dbadadf3..e8d39b74b8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -556,6 +556,7 @@ endmenu
>   	source "package/mhz/Config.in"
>   	source "package/minicom/Config.in"
>   	source "package/msr-tools/Config.in"
> +	source "package/mxt-app/Config.in"
>   	source "package/nanocom/Config.in"
>   	source "package/neard/Config.in"
>   	source "package/nvidia-driver/Config.in"
> diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
> new file mode 100644
> index 0000000000..2b153901de
> --- /dev/null
> +++ b/package/mxt-app/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_MXT_APP
> +	bool "mxt-app"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
> +	select BR2_PACKAGE_LIBUSB
> +	help
> +	  mxt-app is a utility for managing Atmel maXTouch touch
> +	  controllers and other devices that support Atmel Object Based
> +	  Protocol.
> +
> +	  https://github.com/atmel-maxtouch/mxt-app/
> +
> +config BR2_PACKAGE_MXT_APP_DEBUG
> +	bool "mxt-app debugging"
> +	help
> +	  Compile mxt-app with debug enabled
> +
> +comment "mxt-app needs a toolchain w/ threads, gcc >= 4.9"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
> new file mode 100644
> index 0000000000..b7851cea37
> --- /dev/null
> +++ b/package/mxt-app/mxt-app.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722  mxt-app-1.36.tar.gz
> +sha256  3682b125a40a4da00b6ab69bdbd38c25ed4beae69b3fe32458d2e32638477c4c  LICENSE
> diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
> new file mode 100644
> index 0000000000..da0aa65328
> --- /dev/null
> +++ b/package/mxt-app/mxt-app.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# mxt-app
> +#
> +################################################################################
> +
> +MXT_APP_VERSION = 1.36
> +MXT_APP_SITE = $(call github,atmel-maxtouch,mxt-app,v$(MXT_APP_VERSION))
> +MXT_APP_LICENSE = BSD-2-Clause
> +MXT_APP_LICENSE_FILES = LICENSE
> +MXT_APP_DEPENDENCIES = libusb
> +MXT_APP_INSTALL_STAGING = YES
> +MXT_APP_AUTORECONF = YES
> +
> +ifeq ($(BR2_PACKAGE_MXT_APP_DEBUG),y)
> +MXT_APP_CONF_OPTS += --enable-debug
> +endif
> +
> +$(eval $(autotools-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/mxt-app: new package
  2024-07-12 20:48 ` Arnout Vandecappelle via buildroot
@ 2024-07-12 20:49   ` Arnout Vandecappelle via buildroot
  0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-07-12 20:49 UTC (permalink / raw)
  To: kazemi.ms, buildroot; +Cc: Thomas Petazzoni


[-- Attachment #1.1: Type: text/plain, Size: 4298 bytes --]


On 12/07/2024 22:48, Arnout Vandecappelle wrote:
>
>
> On 19/09/2023 21:35, kazemi.ms@gmail.com wrote:
>> From: Saeed Kazemi <kazemi.ms@gmail.com>
>>
>> mxt-app is a utility for managing Atmel maXTouch touch controllers
>> and other devices that support Atmel Object Based Protocol.
>>
>> Signed-off-by: Saeed Kazemi <kazemi.ms@gmail.com>
>
>  Applied to master, thanks.

  Forgot to mention the changes I still made:

     - drop BR2_PACKAGE_MXT_APP_DEBUG option, instead use
       BR2_ENABLE_RUNTIME_DEBUG;
     - also explicitly disable debug;
     - add comment to explain AUTORECONF.


  Regards,
  Arnout

>
>  Regards,
>  Arnout
>
>> ---
>>   DEVELOPERS                   |  3 +++
>>   package/Config.in            |  1 +
>>   package/mxt-app/Config.in    | 20 ++++++++++++++++++++
>>   package/mxt-app/mxt-app.hash |  3 +++
>>   package/mxt-app/mxt-app.mk   | 19 +++++++++++++++++++
>>   5 files changed, 46 insertions(+)
>>   create mode 100644 package/mxt-app/Config.in
>>   create mode 100644 package/mxt-app/mxt-app.hash
>>   create mode 100644 package/mxt-app/mxt-app.mk
>>
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index e8b78a8d46..19d637d847 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -2604,6 +2604,9 @@ F:    package/agent-proxy/
>>   N:    Ryan Wilkins <ryan@deadfrog.net>
>>   F:    package/biosdevname/
>>   +N:    Saeed Kazemi <kazemi.ms@gmail.com>
>> +F:    package/mxt-app/
>> +
>>   N:    Sam Lancia <sam@gpsm.co.uk>
>>   F:    package/lrzip/
>>   diff --git a/package/Config.in b/package/Config.in
>> index e8dbadadf3..e8d39b74b8 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -556,6 +556,7 @@ endmenu
>>       source "package/mhz/Config.in"
>>       source "package/minicom/Config.in"
>>       source "package/msr-tools/Config.in"
>> +    source "package/mxt-app/Config.in"
>>       source "package/nanocom/Config.in"
>>       source "package/neard/Config.in"
>>       source "package/nvidia-driver/Config.in"
>> diff --git a/package/mxt-app/Config.in b/package/mxt-app/Config.in
>> new file mode 100644
>> index 0000000000..2b153901de
>> --- /dev/null
>> +++ b/package/mxt-app/Config.in
>> @@ -0,0 +1,20 @@
>> +config BR2_PACKAGE_MXT_APP
>> +    bool "mxt-app"
>> +    depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
>> +    depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
>> +    select BR2_PACKAGE_LIBUSB
>> +    help
>> +      mxt-app is a utility for managing Atmel maXTouch touch
>> +      controllers and other devices that support Atmel Object Based
>> +      Protocol.
>> +
>> + https://github.com/atmel-maxtouch/mxt-app/
>> +
>> +config BR2_PACKAGE_MXT_APP_DEBUG
>> +    bool "mxt-app debugging"
>> +    help
>> +      Compile mxt-app with debug enabled
>> +
>> +comment "mxt-app needs a toolchain w/ threads, gcc >= 4.9"
>> +    depends on !BR2_TOOLCHAIN_HAS_THREADS || \
>> +        !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>> diff --git a/package/mxt-app/mxt-app.hash b/package/mxt-app/mxt-app.hash
>> new file mode 100644
>> index 0000000000..b7851cea37
>> --- /dev/null
>> +++ b/package/mxt-app/mxt-app.hash
>> @@ -0,0 +1,3 @@
>> +# Locally calculated
>> +sha256 3639720ae1ea033bd982d68c5cab84432ce046fe14a66d9b2de07f115b642722 
>> mxt-app-1.36.tar.gz
>> +sha256 3682b125a40a4da00b6ab69bdbd38c25ed4beae69b3fe32458d2e32638477c4c LICENSE
>> diff --git a/package/mxt-app/mxt-app.mk b/package/mxt-app/mxt-app.mk
>> new file mode 100644
>> index 0000000000..da0aa65328
>> --- /dev/null
>> +++ b/package/mxt-app/mxt-app.mk
>> @@ -0,0 +1,19 @@
>> +################################################################################ 
>>
>> +#
>> +# mxt-app
>> +#
>> +################################################################################ 
>>
>> +
>> +MXT_APP_VERSION = 1.36
>> +MXT_APP_SITE = $(call github,atmel-maxtouch,mxt-app,v$(MXT_APP_VERSION))
>> +MXT_APP_LICENSE = BSD-2-Clause
>> +MXT_APP_LICENSE_FILES = LICENSE
>> +MXT_APP_DEPENDENCIES = libusb
>> +MXT_APP_INSTALL_STAGING = YES
>> +MXT_APP_AUTORECONF = YES
>> +
>> +ifeq ($(BR2_PACKAGE_MXT_APP_DEBUG),y)
>> +MXT_APP_CONF_OPTS += --enable-debug
>> +endif
>> +
>> +$(eval $(autotools-package))

[-- Attachment #1.2: Type: text/html, Size: 7594 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-12 20:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-19 12:55 [Buildroot] [PATCH 1/1] package/mxt-app: new package kazemi.ms
2023-09-19 13:19 ` Thomas Petazzoni via buildroot
2023-09-19 19:54   ` Saeed Kazemi
  -- strict thread matches above, loose matches on Subject: below --
2023-09-19 19:35 kazemi.ms
2024-07-12 20:48 ` Arnout Vandecappelle via buildroot
2024-07-12 20:49   ` Arnout Vandecappelle via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox