* [Buildroot] [PATCH v2, 1/1] package/openvpn: dco needs headers >= 4.16
@ 2023-09-20 21:12 Fabrice Fontaine
2023-09-21 12:25 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2023-09-20 21:12 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
NLMSGERR_ATTR_MAX has been added in kernel 4.16 with
https://github.com/torvalds/linux/commit/dc2b9f19e3bdaa87a7c3d123b8bba8a42d96d942
resulting in the following build failure since bump to version 2.6.4 in
commit a46ac2346558d05afe405dda3730169df4b677d2 and
https://github.com/OpenVPN/openvpn/commit/e34437c26b764851555e4acbe2ccca6bec235c7e:
dco_linux.c: In function 'ovpn_nl_cb_error':
dco_linux.c:303:27: error: 'NLMSGERR_ATTR_MAX' undeclared (first use in this function); did you mean '__CTRL_ATTR_MAX'?
struct nlattr *tb_msg[NLMSGERR_ATTR_MAX + 1];
^~~~~~~~~~~~~~~~~
__CTRL_ATTR_MAX
Fixes:
- http://autobuild.buildroot.org/results/69b9737913ac0b5cd2c117d526602874da3ee487
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Thomas Petazzoni):
- Only disable dco with headers < 4.16
package/openvpn/openvpn.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/openvpn/openvpn.mk b/package/openvpn/openvpn.mk
index 12c090ba3e..619a22c3b3 100644
--- a/package/openvpn/openvpn.mk
+++ b/package/openvpn/openvpn.mk
@@ -16,7 +16,7 @@ OPENVPN_CONF_OPTS = \
$(if $(BR2_STATIC_LIBS),--disable-plugins)
OPENVPN_CONF_ENV = NETSTAT=/bin/netstat
-ifeq ($(BR2_PACKAGE_LIBNL),y)
+ifeq ($(BR2_PACKAGE_LIBNL)$(BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_16),yy)
OPENVPN_CONF_OPTS += --enable-dco
OPENVPN_DEPENDENCIES += libnl
else
--
2.40.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-21 12:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-20 21:12 [Buildroot] [PATCH v2, 1/1] package/openvpn: dco needs headers >= 4.16 Fabrice Fontaine
2023-09-21 12:25 ` Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox