Re: [Buildroot] [PATCH v2] package/nodejs: fix parallel build

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Jens, All,

On 2023-09-23 18:04 +0200, Jens Maus via buildroot spake thusly:
> In ninja-based nodejs builds performing parallel builds using "make -jX"
> is not working during buildroot initiated builds because the JOBS
> variable is not set in the MAKE_OPTS variables in nodejs.mk. This commit
> remedies the issue by setting JOBS to BR2_JLEVEL.

I was very confused that nodejs would not build in parallel; that would
have made for very, very,very long builds. And indeed, it does build in
parallel, in fact.

However, what it does, is use as many CPUs as are available, without
accounting for the value set by the user in BR2_JLEVEL, thus
overshooting the limits set by the user.

So, I reworded the whoe commit log to explain that.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Jens Maus <mail@jens-maus.de>
> 
> ---
> Changes v1 -> v2:
>   - removed unrelated v8-qemu-wrapper.in change (Yann)
>   - revised change summary (Yann)
>   - removed unnecessary top-level Makefile modifications (Yann)
> 
> Signed-off-by: Jens Maus <mail@jens-maus.de>
> ---
>  package/nodejs/nodejs.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index fe629ada21..4e70bd71a3 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -46,14 +46,16 @@ HOST_NODEJS_MAKE_OPTS = \
>  	CXXFLAGS="$(HOST_NODEJS_CXXFLAGS)" \
>  	LDFLAGS.host="$(HOST_LDFLAGS)" \
>  	NO_LOAD=cctest.target.mk \
> -	PATH=$(@D)/bin:$(BR_PATH)
> +	PATH=$(@D)/bin:$(BR_PATH) \
> +	JOBS=$(BR2_JLEVEL)
>  
>  NODEJS_MAKE_OPTS = \
>  	$(TARGET_CONFIGURE_OPTS) \
>  	NO_LOAD=cctest.target.mk \
>  	PATH=$(@D)/bin:$(BR_PATH) \
>  	LDFLAGS="$(NODEJS_LDFLAGS)" \
> -	LD="$(TARGET_CXX)"
> +	LD="$(TARGET_CXX)" \
> +	JOBS=$(BR2_JLEVEL)
>  
>  # nodejs's build system uses python which can be a symlink to an unsupported
>  # python version (e.g. python 3.10 with nodejs 14.18.1). We work around this by
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot