From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jens Maus <mail@jens-maus.de>
Cc: Daniel Price <daniel.price@gmail.com>,
Martin Bark <martin@barkynet.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nodejs: fix cross-compile builds
Date: Sun, 24 Sep 2023 18:36:04 +0200 [thread overview]
Message-ID: <20230924163604.GP1469982@scaer> (raw)
In-Reply-To: <20230923105932.1865002-1-mail@jens-maus.de>
Jens, All,
On 2023-09-23 12:59 +0200, Jens Maus via buildroot spake thusly:
> When nodejs is build a qemu wrapper script is used to execute
> some programs built for the target in user-mode emulation. However, in
> some constellations this causes the build to fail because libraries from
> the build host are used rather than from the target staging directory.
> This has been already reported [1] and throughoutly investigate [2].
> A commonly used fix for this issue is to explicitly use LD_LIBRARY_PATH
> to make sure that the correct runtime libraries are preferred rather
> than using libraries from the build host.
Compared to the in-depth analysis that Thomas did, the above was very,
very light. It did not even explain the core of the issue ("in some
constellations" is very vague, when Thomas explaned exactly what is
going on).
For such a difficult issue, we do want to carry the explanations in the
repository, when a remote URL may disapear any time.
So, I did duplicate most of Thomas analysis, and just tweaked it ever so
slightly so that it fits better as a commit log.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> [1] https://bugs.busybox.net/show_bug.cgi?id=14366
> [2] https://lore.kernel.org/buildroot/20221031213926.50d3c778@windsurf/
>
> Signed-off-by: Jens Maus <mail@jens-maus.de>
> ---
> package/nodejs/v8-qemu-wrapper.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/nodejs/v8-qemu-wrapper.in b/package/nodejs/v8-qemu-wrapper.in
> index e1083f47f7..48222d089b 100644
> --- a/package/nodejs/v8-qemu-wrapper.in
> +++ b/package/nodejs/v8-qemu-wrapper.in
> @@ -5,5 +5,6 @@
> exec @QEMU_USER@ -r @TOOLCHAIN_HEADERS_VERSION@ \
> @QEMU_USERMODE_ARGS@ \
> -L "${STAGING_DIR}/" \
> + -E LD_LIBRARY_PATH="${STAGING_DIR}/lib:${STAGING_DIR}/usr/lib/" \
> "$@"
>
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-24 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 9:39 [Buildroot] [PATCH] package/nodejs: fix parallel build Jens Maus via buildroot
2023-09-23 10:09 ` Yann E. MORIN
2023-09-23 11:07 ` Jens Maus via buildroot
2023-09-23 16:20 ` Jens Maus via buildroot
2023-09-23 10:59 ` [Buildroot] [PATCH 1/1] package/nodejs: fix cross-compile builds Jens Maus via buildroot
2023-09-24 16:36 ` Yann E. MORIN [this message]
2023-09-27 11:46 ` Peter Korsgaard
2023-09-23 16:04 ` [Buildroot] [PATCH v2] package/nodejs: fix parallel build Jens Maus via buildroot
2023-09-24 9:56 ` Yann E. MORIN
2023-09-26 8:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230924163604.GP1469982@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=mail@jens-maus.de \
--cc=martin@barkynet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox