[Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Fabrice Fontaine]

PPPD_DROP_INTERNAL_IF_PPOL2TP_H is not needed since bump to version
2.4.6 in commit 49b239ab20e632792a6c61173ba830cdc2128ebf and
https://github.com/ppp-project/ppp/commit/c41092dd4c49267f232f6cba3d31c6c68bfdf68d

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pppd/pppd.mk | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/package/pppd/pppd.mk b/package/pppd/pppd.mk
index d9d6244f10..25d017a84f 100644
--- a/package/pppd/pppd.mk
+++ b/package/pppd/pppd.mk
@@ -37,15 +37,6 @@ PPPD_DEPENDENCIES += libpcap
 PPPD_MAKE_OPTS += FILTER=y
 endif
 
-# pppd bundles some but not all of the needed kernel headers. The embedded
-# if_pppol2tp.h is unfortunately not compatible with kernel headers > 2.6.34,
-# and has been part of the kernel headers since 2.6.23, so drop it
-define PPPD_DROP_INTERNAL_IF_PPOL2TP_H
-	$(RM) $(@D)/include/linux/if_pppol2tp.h
-endef
-
-PPPD_POST_EXTRACT_HOOKS += PPPD_DROP_INTERNAL_IF_PPOL2TP_H
-
 # pppd defaults to /etc/ppp/resolv.conf, which not be writable and is
 # definitely not useful since the C library only uses
 # /etc/resolv.conf. Therefore, we change pppd to use /etc/resolv.conf
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Yann E. MORIN]

Fabrice, All,

On 2023-09-24 18:29 +0200, Fabrice Fontaine spake thusly:
> PPPD_DROP_INTERNAL_IF_PPOL2TP_H is not needed since bump to version
> 2.4.6 in commit 49b239ab20e632792a6c61173ba830cdc2128ebf and
> https://github.com/ppp-project/ppp/commit/c41092dd4c49267f232f6cba3d31c6c68bfdf68d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/pppd/pppd.mk | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/package/pppd/pppd.mk b/package/pppd/pppd.mk
> index d9d6244f10..25d017a84f 100644
> --- a/package/pppd/pppd.mk
> +++ b/package/pppd/pppd.mk
> @@ -37,15 +37,6 @@ PPPD_DEPENDENCIES += libpcap
>  PPPD_MAKE_OPTS += FILTER=y
>  endif
>  
> -# pppd bundles some but not all of the needed kernel headers. The embedded
> -# if_pppol2tp.h is unfortunately not compatible with kernel headers > 2.6.34,
> -# and has been part of the kernel headers since 2.6.23, so drop it
> -define PPPD_DROP_INTERNAL_IF_PPOL2TP_H
> -	$(RM) $(@D)/include/linux/if_pppol2tp.h
> -endef
> -
> -PPPD_POST_EXTRACT_HOOKS += PPPD_DROP_INTERNAL_IF_PPOL2TP_H
> -
>  # pppd defaults to /etc/ppp/resolv.conf, which not be writable and is
>  # definitely not useful since the C library only uses
>  # /etc/resolv.conf. Therefore, we change pppd to use /etc/resolv.conf
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > PPPD_DROP_INTERNAL_IF_PPOL2TP_H is not needed since bump to version
 > 2.4.6 in commit 49b239ab20e632792a6c61173ba830cdc2128ebf and
 > https://github.com/ppp-project/ppp/commit/c41092dd4c49267f232f6cba3d31c6c68bfdf68d

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Bernd Kuhls]

Am Sun, 24 Sep 2023 18:29:09 +0200 schrieb Fabrice Fontaine:

> PPPD_DROP_INTERNAL_IF_PPOL2TP_H is not needed since bump to version
> 2.4.6 in commit 49b239ab20e632792a6c61173ba830cdc2128ebf and
> https://github.com/ppp-project/ppp/commit/
c41092dd4c49267f232f6cba3d31c6c68bfdf68d

Hi Fabrice,

your patch is part of my patch bumping pppd to 2.5.0:
https://patchwork.ozlabs.org/project/buildroot/patch/
20230726060041.4434-1-bernd@kuhls.net/

Regards, Bernd

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pppd: drop PPPD_DROP_INTERNAL_IF_PPOL2TP_H

[Yann E. MORIN]

Bernd, All,

On 2023-09-24 19:20 +0200, Bernd Kuhls spake thusly:
> Am Sun, 24 Sep 2023 18:29:09 +0200 schrieb Fabrice Fontaine:
> 
> > PPPD_DROP_INTERNAL_IF_PPOL2TP_H is not needed since bump to version
> > 2.4.6 in commit 49b239ab20e632792a6c61173ba830cdc2128ebf and
> > https://github.com/ppp-project/ppp/commit/
> c41092dd4c49267f232f6cba3d31c6c68bfdf68d
> 
> Hi Fabrice,
> 
> your patch is part of my patch bumping pppd to 2.5.0:
> https://patchwork.ozlabs.org/project/buildroot/patch/
> 20230726060041.4434-1-bernd@kuhls.net/

But the hooks is already not needed for 2.4.9, so it is not related to
the bump from 2.4.9 to 2.5.0, so we want it as a separate change
(because it can then be backported if needed).

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot