[Buildroot] [PATCH 1/1] package/pkg-kernel-module: add BR2_MAKE_HOST_DEPENDENCY

[Buildroot] [PATCH 1/1] package/pkg-kernel-module: add BR2_MAKE_HOST_DEPENDENCY

[Sergey Bobrenok via buildroot]

From: Alexey Romanov <avromanov@sberdevices.ru>

Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to
$(BR2_MAKE) to avoid build issue with kernel version >= 6.2 and GNU
Make version < 3.82. However, the same issue is actual for kernel
modules as well.

Using $(BR2_MAKE) should guarantee a consistent behavior between
kernel and kernel-modules builds.

Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
Signed-off-by: Sergey Bobrenok <SIBobrenok@sberdevices.ru>
---
 package/pkg-kernel-module.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/pkg-kernel-module.mk b/package/pkg-kernel-module.mk
index fcd6b8bc29..ae7a09114e 100644
--- a/package/pkg-kernel-module.mk
+++ b/package/pkg-kernel-module.mk
@@ -50,11 +50,12 @@ LINUX_NEEDS_MODULES = y
 endif
 
 # The kernel must be built first.
-$(2)_DEPENDENCIES += linux
+$(2)_DEPENDENCIES += linux \
+    $$(BR2_MAKE_HOST_DEPENDENCY)
 
 # This is only defined in some infrastructures (e.g. autotools, cmake),
 # but not in others (e.g. generic). So define it here as well.
-$(2)_MAKE ?= $$(MAKE)
+$(2)_MAKE ?= $$(BR2_MAKE)
 
 # If not specified, consider the source of the kernel module to be at
 # the root of the package.
-- 
2.24.3 (Apple Git-128)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pkg-kernel-module: add BR2_MAKE_HOST_DEPENDENCY

[Yann E. MORIN]

Sergey, All,

On 2023-10-24 18:30 +0300, Sergey Bobrenok via buildroot spake thusly:
> From: Alexey Romanov <avromanov@sberdevices.ru>
> 
> Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to
> $(BR2_MAKE) to avoid build issue with kernel version >= 6.2 and GNU
> Make version < 3.82. However, the same issue is actual for kernel
> modules as well.
> 
> Using $(BR2_MAKE) should guarantee a consistent behavior between
> kernel and kernel-modules builds.
> 
> Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
> Signed-off-by: Sergey Bobrenok <SIBobrenok@sberdevices.ru>
> ---
>  package/pkg-kernel-module.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/pkg-kernel-module.mk b/package/pkg-kernel-module.mk
> index fcd6b8bc29..ae7a09114e 100644
> --- a/package/pkg-kernel-module.mk
> +++ b/package/pkg-kernel-module.mk
> @@ -50,11 +50,12 @@ LINUX_NEEDS_MODULES = y
>  endif
>  
>  # The kernel must be built first.
> -$(2)_DEPENDENCIES += linux
> +$(2)_DEPENDENCIES += linux \
> +    $$(BR2_MAKE_HOST_DEPENDENCY)

With multi-line assignments, each value should be on its own line. Also,
indentation should be with TAB, not spaces.

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  # This is only defined in some infrastructures (e.g. autotools, cmake),
>  # but not in others (e.g. generic). So define it here as well.
> -$(2)_MAKE ?= $$(MAKE)
> +$(2)_MAKE ?= $$(BR2_MAKE)
>  
>  # If not specified, consider the source of the kernel module to be at
>  # the root of the package.
> -- 
> 2.24.3 (Apple Git-128)
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pkg-kernel-module: add BR2_MAKE_HOST_DEPENDENCY

[Peter Korsgaard]

>>>>> "Sergey" == Sergey Bobrenok via buildroot <buildroot@buildroot.org> writes:

 > From: Alexey Romanov <avromanov@sberdevices.ru>
 > Commit 0b9efc991f ("linux: use BR2_MAKE") switched LINUX_MAKE to
 > $(BR2_MAKE) to avoid build issue with kernel version >= 6.2 and GNU
 > Make version < 3.82. However, the same issue is actual for kernel
 > modules as well.

 > Using $(BR2_MAKE) should guarantee a consistent behavior between
 > kernel and kernel-modules builds.

 > Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
 > Signed-off-by: Sergey Bobrenok <SIBobrenok@sberdevices.ru>

Committed to 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot