From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: michal.simek@amd.com, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] configs/zynq_zc702_defconfig: new defconfig
Date: Tue, 31 Oct 2023 12:12:22 +0100 [thread overview]
Message-ID: <20231031121222.1dfa4035@booty> (raw)
In-Reply-To: <20231018111357.2898095-1-neal.frager@amd.com>
Hi Neal,
On Wed, 18 Oct 2023 12:13:57 +0100
Neal Frager <neal.frager@amd.com> wrote:
> This patch adds support for Xilinx Zynq ZC702 starter kit.
>
> ZC702 features can be found here:
> https://www.xilinx.com/products/boards-and-kits/ek-z7-zc702-g.html
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
This patch looks very clean, however I have a question. The zc702
config you are adding is identical to the existing one for the zc706
except for the device tree:
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="zynq-zc706"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="zynq-zc702"
-BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynq-zc706"
+BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynq-zc702"
However, exactly because it is so similar, I am not sure about the
usefulness of having a large number of (from the build system
perspective) very similar configurations, where a user can simply 'sed
s/zc706/zc702/' to work on a different board.
I'm wondering whether we could have a unique defconfig that builds
artifacts able to boot on both boards. This probably build down to
whether the hardware components involved in the boot process are
similar enough to allow U-Boot to boot with the same embedded device
tree for both boards. At a quick glance the two dts files appear very
similar.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-10-31 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 11:13 [Buildroot] [PATCH v2 1/1] configs/zynq_zc702_defconfig: new defconfig Neal Frager via buildroot
2023-10-31 11:12 ` Luca Ceresoli via buildroot [this message]
2023-10-31 12:12 ` Frager, Neal via buildroot
2023-10-31 12:34 ` Thomas Petazzoni via buildroot
[not found] ` <8a0d97bb-2fe5-4e09-8e95-b928a431ce1e@amd.com>
2023-10-31 13:30 ` Frager, Neal via buildroot
2023-10-31 16:39 ` Peter Korsgaard
2023-11-13 17:10 ` Luca Ceresoli via buildroot
2023-11-13 21:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031121222.1dfa4035@booty \
--to=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox