Re: [Buildroot] [PATCH] configs/friendlyarm_nanopi_neo2_defconfig: new board

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Scott, All,

On 2023-10-31 16:49 +0800, Scott Fan spake thusly:
> Add support for the FriendlyARM NanoPi NEO2 with mainline components:
>   - U-Boot 2023.10
>   - Linux 6.1.60

Funny, we removed a defconfig for that board a year ago, almost
day-for-day:
    24bb61071269  configs/friendlyarm_nanopi_neo2: remove defconfig

It's OK to re-add a new, fixed defconfig, though!

> Board's wiki page:
>   - https://wiki.friendlyelec.com/wiki/index.php/NanoPi_NEO2
> 
> Signed-off-by: Scott Fan <fancp2007@gmail.com>
> ---
[--SNIP--]
> diff --git a/board/friendlyarm/nanopi-neo2/post-build.sh b/board/friendlyarm/nanopi-neo2/post-build.sh
> new file mode 100755
> index 0000000000..0ee47013f1
> --- /dev/null
> +++ b/board/friendlyarm/nanopi-neo2/post-build.sh
> @@ -0,0 +1,8 @@
> +#!/bin/sh
> +
> +BOARD_DIR="$(dirname $0)"

    $ ./utils-docker-run make check-package
    board/friendlyarm/nanopi-neo2/post-build.sh:0: run 'shellcheck' and fix the warnings

    $ ./utils/docker-run shellcheck board/friendlyarm/nanopi-neo2/post-build.sh
    In board/friendlyarm/nanopi-neo2/post-build.sh line 3:
    BOARD_DIR="$(dirname $0)"
                         ^-- SC2086: Double quote to prevent globbing and word splitting.

> diff --git a/board/friendlyarm/nanopi-neo2/readme.txt b/board/friendlyarm/nanopi-neo2/readme.txt
> new file mode 100644
> index 0000000000..50795a1cfb
> --- /dev/null
> +++ b/board/friendlyarm/nanopi-neo2/readme.txt
> @@ -0,0 +1,34 @@
[--SNIP--]
> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> +  $ sudo sync

No need for sudo to run sync

[--SNIP--]
> diff --git a/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch b/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch
> new file mode 100644
> index 0000000000..b2edd9fb37
> --- /dev/null
> +++ b/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch

    $ ./utils-docker-run make check-package
    board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: use name <number>-<description>.patch (http://nightly.buildroot.org/#_providing_patches)
    board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
    board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)

Also, you need to provide a git-formatted patch, with a proper subject,
a proper commit log, and as reported above, your signed-off, and the
upstream status of this patch.

[--SNIP--]
> diff --git a/configs/friendlyarm_nanopi_neo2_defconfig b/configs/friendlyarm_nanopi_neo2_defconfig
> new file mode 100644
> index 0000000000..a88bf8957c
> --- /dev/null
> +++ b/configs/friendlyarm_nanopi_neo2_defconfig
> @@ -0,0 +1,48 @@
> +BR2_aarch64=y
> +BR2_cortex_a53=y
> +BR2_ARM_FPU_VFPV4=y
> +
> +# Linux headers same as kernel, a 6.1 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
> +
> +# Firmware
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y

ATF is a bootloader, and as such, we want to use a pinned version, not
the latest one, so as for uboot:
    BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
    BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE=v2.7

Care to fix all of those, and respin, please?

Regards,
Yann E. MORIN.

> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.10"
> +BR2_TARGET_UBOOT_PATCH="board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi_neo2"
> +BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/friendlyarm/nanopi-neo2/uboot/fit_spl.fragment"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> +BR2_TARGET_UBOOT_FORMAT_ITB=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.60"
> +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-h5-nanopi-neo2"
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +
> +# Filesystem
> +BR2_TARGET_GENERIC_ISSUE="Welcome to FriendlyARM NanoPi NEO2"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopi-neo2/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopi-neo2/genimage.cfg"
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot