Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Scott Fan <fancp2007@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] configs/friendlyarm_nanopi_neo2_defconfig: new board
Date: Wed, 1 Nov 2023 11:36:50 +0100	[thread overview]
Message-ID: <20231101103650.GF2568@scaer> (raw)
In-Reply-To: <CAFkzVZZGyZqQ8VOghjjP_7Wv0xgBj9ezKG97muw0aGCVA+xA=w@mail.gmail.com>

Scott, All,

On 2023-11-01 08:53 +0800, Scott Fan spake thusly:
> I can fix those above questions, but there is one thing that might be
> a little troublesome,
> the fit_spl_atf_its.patch file was made from me, not from upstream.

The "Upstream:" tag is meant to represent the status of the patch,
whether you backported an upstream commit, or grabbed a pending patch
(from upstream mailing list, pull-request...), or whether you wrote and
submitted the patch; see the manual (as reported by check-package) for
the details:
    https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation

> Should i submit the change to upstream first, then re-make patch with the
> upstream status of it?

It would indeed be nice to upstream this change, because it is not
specific to Buildroot. In which case, the Upstream tag would point to
the upstream PR or mailing list post.

Regards,
Yann E. MORIN.

> Scott Fan
> 
> On Wed, Nov 1, 2023 at 5:14 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> >
> > Scott, All,
> >
> > On 2023-10-31 16:49 +0800, Scott Fan spake thusly:
> > > Add support for the FriendlyARM NanoPi NEO2 with mainline components:
> > >   - U-Boot 2023.10
> > >   - Linux 6.1.60
> >
> > Funny, we removed a defconfig for that board a year ago, almost
> > day-for-day:
> >     24bb61071269  configs/friendlyarm_nanopi_neo2: remove defconfig
> >
> > It's OK to re-add a new, fixed defconfig, though!
> >
> > > Board's wiki page:
> > >   - https://wiki.friendlyelec.com/wiki/index.php/NanoPi_NEO2
> > >
> > > Signed-off-by: Scott Fan <fancp2007@gmail.com>
> > > ---
> > [--SNIP--]
> > > diff --git a/board/friendlyarm/nanopi-neo2/post-build.sh b/board/friendlyarm/nanopi-neo2/post-build.sh
> > > new file mode 100755
> > > index 0000000000..0ee47013f1
> > > --- /dev/null
> > > +++ b/board/friendlyarm/nanopi-neo2/post-build.sh
> > > @@ -0,0 +1,8 @@
> > > +#!/bin/sh
> > > +
> > > +BOARD_DIR="$(dirname $0)"
> >
> >     $ ./utils-docker-run make check-package
> >     board/friendlyarm/nanopi-neo2/post-build.sh:0: run 'shellcheck' and fix the warnings
> >
> >     $ ./utils/docker-run shellcheck board/friendlyarm/nanopi-neo2/post-build.sh
> >     In board/friendlyarm/nanopi-neo2/post-build.sh line 3:
> >     BOARD_DIR="$(dirname $0)"
> >                          ^-- SC2086: Double quote to prevent globbing and word splitting.
> >
> > > diff --git a/board/friendlyarm/nanopi-neo2/readme.txt b/board/friendlyarm/nanopi-neo2/readme.txt
> > > new file mode 100644
> > > index 0000000000..50795a1cfb
> > > --- /dev/null
> > > +++ b/board/friendlyarm/nanopi-neo2/readme.txt
> > > @@ -0,0 +1,34 @@
> > [--SNIP--]
> > > +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX
> > > +  $ sudo sync
> >
> > No need for sudo to run sync
> >
> > [--SNIP--]
> > > diff --git a/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch b/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch
> > > new file mode 100644
> > > index 0000000000..b2edd9fb37
> > > --- /dev/null
> > > +++ b/board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch
> >
> >     $ ./utils-docker-run make check-package
> >     board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: use name <number>-<description>.patch (http://nightly.buildroot.org/#_providing_patches)
> >     board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: missing Signed-off-by in the header (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
> >     board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch:0: missing Upstream in the header (http://nightly.buildroot.org/#_additional_patch_documentation)
> >
> > Also, you need to provide a git-formatted patch, with a proper subject,
> > a proper commit log, and as reported above, your signed-off, and the
> > upstream status of this patch.
> >
> > [--SNIP--]
> > > diff --git a/configs/friendlyarm_nanopi_neo2_defconfig b/configs/friendlyarm_nanopi_neo2_defconfig
> > > new file mode 100644
> > > index 0000000000..a88bf8957c
> > > --- /dev/null
> > > +++ b/configs/friendlyarm_nanopi_neo2_defconfig
> > > @@ -0,0 +1,48 @@
> > > +BR2_aarch64=y
> > > +BR2_cortex_a53=y
> > > +BR2_ARM_FPU_VFPV4=y
> > > +
> > > +# Linux headers same as kernel, a 6.1 series
> > > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
> > > +
> > > +# Firmware
> > > +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> > > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
> > > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
> >
> > ATF is a bootloader, and as such, we want to use a pinned version, not
> > the latest one, so as for uboot:
> >     BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
> >     BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE=v2.7
> >
> > Care to fix all of those, and respin, please?
> >
> > Regards,
> > Yann E. MORIN.
> >
> > > +# Bootloader
> > > +BR2_TARGET_UBOOT=y
> > > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> > > +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> > > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.10"
> > > +BR2_TARGET_UBOOT_PATCH="board/friendlyarm/nanopi-neo2/uboot/fit_spl_atf_its.patch"
> > > +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="nanopi_neo2"
> > > +BR2_TARGET_UBOOT_CONFIG_FRAGMENT_FILES="board/friendlyarm/nanopi-neo2/uboot/fit_spl.fragment"
> > > +BR2_TARGET_UBOOT_NEEDS_DTC=y
> > > +BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> > > +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> > > +BR2_TARGET_UBOOT_FORMAT_ITB=y
> > > +BR2_TARGET_UBOOT_SPL=y
> > > +BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
> > > +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
> > > +
> > > +# Kernel
> > > +BR2_LINUX_KERNEL=y
> > > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> > > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.60"
> > > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-h5-nanopi-neo2"
> > > +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> > > +
> > > +# Filesystem
> > > +BR2_TARGET_GENERIC_ISSUE="Welcome to FriendlyARM NanoPi NEO2"
> > > +BR2_TARGET_ROOTFS_EXT2=y
> > > +BR2_TARGET_ROOTFS_EXT2_4=y
> > > +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > > +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > > +BR2_PACKAGE_HOST_GENIMAGE=y
> > > +BR2_PACKAGE_HOST_MTOOLS=y
> > > +BR2_ROOTFS_POST_BUILD_SCRIPT="board/friendlyarm/nanopi-neo2/post-build.sh"
> > > +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> > > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/friendlyarm/nanopi-neo2/genimage.cfg"
> > > --
> > > 2.25.1
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
> > --
> > .-----------------.--------------------.------------------.--------------------.
> > |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> > | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> > | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> > '------------------------------^-------^------------------^--------------------'

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-01 10:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-31  8:49 [Buildroot] [PATCH] configs/friendlyarm_nanopi_neo2_defconfig: new board Scott Fan
2023-10-31 21:14 ` Yann E. MORIN
2023-10-31 21:27   ` Yann E. MORIN
2023-11-01  0:53   ` Scott Fan
2023-11-01 10:36     ` Yann E. MORIN [this message]
2023-11-01  1:34 ` Scott Fan
  -- strict thread matches above, loose matches on Subject: below --
2023-11-01  1:31 Scott Fan
2023-11-04 19:23 [Buildroot] [PATCH v4] " Scott Fan
2023-12-08  0:34 ` [Buildroot] [PATCH] " Scott Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231101103650.GF2568@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fancp2007@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox