* [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51
@ 2023-10-17 11:08 Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 2/4] package/openrc: add linux-pam support Adam Duskett
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Adam Duskett @ 2023-10-17 11:08 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Adam Duskett, Michał Łyszczek
OpenRC has not been updated for quite some time, and much has changed.
- Convert to a meson package.
- Update the license hash as the year has changed from 2015 to 2023.
- Introduce one new patch:
- 0007-allow-setting-rc_libexecdir-path.patch: Introduces the previous
behavior of setting the rc directory to /usr/libexec/rc.
(Upstream: Upstream: https://github.com/OpenRC/openrc/pull/443)
- Install the sysv-rcs script in the new OPENRC_INSTALL_SYSV_RCS_SCRIPT
post install hook as the OPENRC_BUILD_CMDS define no longer exists.
Tested with tests.init.test_openrc all tests pass.
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
v4 -> v5: bump to 0.51
....in-change-run-lock-from-root-uucp-t.patch | 2 +-
...-add-agetty.tty-1-6-if-MKSYSVINIT-ye.patch | 35 ++++++++-------
...lso-create-run-lock-subsys-directory.patch | 2 +-
...007-allow-setting-rc_libexecdir-path.patch | 44 +++++++++++++++++++
package/openrc/openrc.hash | 4 +-
package/openrc/openrc.mk | 40 ++++++-----------
6 files changed, 80 insertions(+), 47 deletions(-)
create mode 100644 package/openrc/0007-allow-setting-rc_libexecdir-path.patch
diff --git a/package/openrc/0002-sh-init.sh.Linux.in-change-run-lock-from-root-uucp-t.patch b/package/openrc/0002-sh-init.sh.Linux.in-change-run-lock-from-root-uucp-t.patch
index 457fbacb5b..2f0a81bbd3 100644
--- a/package/openrc/0002-sh-init.sh.Linux.in-change-run-lock-from-root-uucp-t.patch
+++ b/package/openrc/0002-sh-init.sh.Linux.in-change-run-lock-from-root-uucp-t.patch
@@ -22,7 +22,7 @@ diff --git a/sh/init.sh.Linux.in b/sh/init.sh.Linux.in
index 222bbd3b..7f1a88db 100644
--- a/sh/init.sh.Linux.in
+++ b/sh/init.sh.Linux.in
-@@ -85,7 +85,7 @@ fi
+@@ -83,7 +83,7 @@ fi
fi
checkpath -d "$RC_SVCDIR"
diff --git a/package/openrc/0005-runlevels-do-not-add-agetty.tty-1-6-if-MKSYSVINIT-ye.patch b/package/openrc/0005-runlevels-do-not-add-agetty.tty-1-6-if-MKSYSVINIT-ye.patch
index 733506ada9..42f77ffdea 100644
--- a/package/openrc/0005-runlevels-do-not-add-agetty.tty-1-6-if-MKSYSVINIT-ye.patch
+++ b/package/openrc/0005-runlevels-do-not-add-agetty.tty-1-6-if-MKSYSVINIT-ye.patch
@@ -8,27 +8,28 @@ Also tty[1-6] may not exist (e.g. embedded devices with serial consoles
only).
Signed-off-by: Carlos Santos <unixmania@gmail.com>
+[Adam: update for 0.50]
+Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
- runlevels/Makefile | 6 ------
+ tools/meson_runlevels.sh | 6 ------
1 file changed, 6 deletions(-)
-diff --git a/runlevels/Makefile b/runlevels/Makefile
-index 73843d8b..dbfb59ca 100644
---- a/runlevels/Makefile
-+++ b/runlevels/Makefile
-@@ -90,12 +90,6 @@ install:
- fi; \
- ln -snf ${INITDIR}/"$$x" ${SHUTDOWNDIR}/"$$x" || exit $$?; done \
- fi
-- if test "${MKSYSVINIT}" = yes && test "${OS}" = Linux; then \
-- for x in tty1 tty2 tty3 tty4 tty5 tty6; do \
-- ln -snf ${INITDIR}/agetty ${DESTDIR}/${INITDIR}/"agetty.$$x" || exit $$?; \
-- ln -snf ${INITDIR}/agetty.$$x ${DEFAULTDIR}/"agetty.$$x" || exit $$?; \
-- done; \
-- fi
-
- check test::
+diff --git a/tools/meson_runlevels.sh b/tools/meson_runlevels.sh
+index 1473d4e..eee256b 100755
+--- a/tools/meson_runlevels.sh
++++ b/tools/meson_runlevels.sh
+@@ -91,11 +91,5 @@ if ! test -d "${DESTDIR}${shutdowndir}"; then
+ ln -snf "${init_d_dir}/$x" "${DESTDIR}${shutdowndir}/$x"
+ done
+ fi
+-if test "${sysvinit}" = yes && test "${os}" = Linux; then \
+- for x in tty1 tty2 tty3 tty4 tty5 tty6; do
+- ln -snf "${init_d_dir}/agetty" "${DESTDIR}/${init_d_dir}/agetty.$x"
+- ln -snf "${init_d_dir}/agetty.$x" "${DESTDIR}/${defaultdir}/agetty.$x"
+- done;
+-fi
+ ln -snf "${rc_libexecdir}"/sh/functions.sh "${DESTDIR}/${init_d_dir}"
--
2.18.2
diff --git a/package/openrc/0006-Also-create-run-lock-subsys-directory.patch b/package/openrc/0006-Also-create-run-lock-subsys-directory.patch
index cf592a88b0..ad78a4b8f7 100644
--- a/package/openrc/0006-Also-create-run-lock-subsys-directory.patch
+++ b/package/openrc/0006-Also-create-run-lock-subsys-directory.patch
@@ -15,7 +15,7 @@ diff --git a/sh/init.sh.Linux.in b/sh/init.sh.Linux.in
index e8afc1fb..662ab223 100644
--- a/sh/init.sh.Linux.in
+++ b/sh/init.sh.Linux.in
-@@ -82,7 +82,7 @@ elif ! mountinfo -q /run; then
+@@ -83,7 +83,7 @@ elif ! mountinfo -q /run; then
fi
checkpath -d "$RC_SVCDIR"
diff --git a/package/openrc/0007-allow-setting-rc_libexecdir-path.patch b/package/openrc/0007-allow-setting-rc_libexecdir-path.patch
new file mode 100644
index 0000000000..a11c789275
--- /dev/null
+++ b/package/openrc/0007-allow-setting-rc_libexecdir-path.patch
@@ -0,0 +1,44 @@
+From 89c42e7e0d8d5913789a76b007ed6a0c43078c63 Mon Sep 17 00:00:00 2001
+From: artoo <artoo@artixlinux.org>
+Date: Wed, 8 Sep 2021 22:41:58 +0200
+Subject: [PATCH] allow setting rc_libexecdir path
+
+ - Allow to change the rc dir name of the rc_libexecdir path
+ - Introduce a librcdir option for override with value 'rc'
+
+Upstream: https://github.com/OpenRC/openrc/pull/443
+
+Signed-off-by: artoo <artoo@artixlinux.org>
+[Adam: update for 0.50]
+Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
+---
+ meson.build | 2 +-
+ meson_options.txt | 2 ++
+ 2 files changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 5b3f8fa..40d4be1 100644
+--- a/meson.build
++++ b/meson.build
+@@ -102,7 +102,7 @@ if os == 'Linux' and libexecdir == 'libexec'
+ libexecdir = 'lib'
+ endif
+ libexecdir = rootprefix / libexecdir
+-rc_libexecdir = libexecdir / 'rc'
++rc_libexecdir = libexecdir / get_option('librcdir')
+ rc_bindir = rc_libexecdir / 'bin'
+ rc_sbindir = rc_libexecdir / 'sbin'
+ rc_shdir = rc_libexecdir / 'sh'
+diff --git a/meson_options.txt b/meson_options.txt
+index 2c74152..d2f67e4 100644
+--- a/meson_options.txt
++++ b/meson_options.txt
+@@ -37,3 +37,5 @@ option('termcap', type : 'combo',
+ description : 'the termcap library to use')
+ option('zsh-completions', type : 'boolean',
+ description : 'install zsh completions')
++option('librcdir', type : 'string', value : 'rc',
++ description : 'default location of rc libexec dir')
+--
+2.41.0
+
diff --git a/package/openrc/openrc.hash b/package/openrc/openrc.hash
index 4fcfa9132f..698acf4978 100644
--- a/package/openrc/openrc.hash
+++ b/package/openrc/openrc.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 968e81743a1de7a2348590b3b3286d6af5baf96da28fa1e6364e24f8203fc3b6 openrc-0.43.3.tar.gz
-sha256 96862463f4e77e2508e4fc2c83773fd24807cb699368b63fd93a5e2b466dd624 LICENSE
+sha256 4ec46f2729c77c4387146b491c4d121f5cba48bff2f0aeaff99895dcda5cea85 openrc-0.51.tar.gz
+sha256 6ac2bf77510808fbec7dc86cbfbca98dfc4c6b47dc99e4ca77b5370e097d8e70 LICENSE
diff --git a/package/openrc/openrc.mk b/package/openrc/openrc.mk
index 1d4e70f712..8cc488a081 100644
--- a/package/openrc/openrc.mk
+++ b/package/openrc/openrc.mk
@@ -4,7 +4,7 @@
#
################################################################################
-OPENRC_VERSION = 0.43.3
+OPENRC_VERSION = 0.51
OPENRC_SITE = $(call github,OpenRC,openrc,$(OPENRC_VERSION))
OPENRC_LICENSE = BSD-2-Clause
OPENRC_LICENSE_FILES = LICENSE
@@ -12,39 +12,27 @@ OPENRC_CPE_ID_VENDOR = openrc_project
OPENRC_DEPENDENCIES = ncurses
-# set LIBNAME so openrc puts files in proper directories and sets proper
-# paths in installed files. Since in buildroot /lib64 and /lib32 always
-# points to /lib, it's safe to hardcode it to "lib"
-OPENRC_MAKE_OPTS = \
- LIBNAME=lib \
- LIBEXECDIR=/usr/libexec/rc \
- MKPKGCONFIG=no \
- MKSYSVINIT=yes \
- BRANDING="Buildroot $(BR2_VERSION_FULL)" \
- CC=$(TARGET_CC)
-
-ifeq ($(BR2_SHARED_LIBS),y)
-OPENRC_MAKE_OPTS += MKSTATICLIBS=no
-else
-OPENRC_MAKE_OPTS += MKSTATICLIBS=yes
-endif
+OPENRC_CONF_OPTS = \
+ -Dos=Linux \
+ -Dpam=false \
+ -Dlibrcdir=/usr/libexec/rc \
+ -Dpkgconfig=false \
+ -Dsysvinit=true \
+ -Drootprefix=/ \
+ -Dbranding="\"Buildroot $(BR2_VERSION_FULL)\""
ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
-OPENRC_MAKE_OPTS += MKSELINUX=yes
+OPENRC_CONF_OPTS += -Dselinux=enabled
OPENRC_DEPENDENCIES += libselinux
else
-OPENRC_MAKE_OPTS += MKSELINUX=no
+OPENRC_CONF_OPTS += -Dselinux=disabled
endif
-define OPENRC_BUILD_CMDS
- $(MAKE) $(OPENRC_MAKE_OPTS) -C $(@D)
-endef
-
-define OPENRC_INSTALL_TARGET_CMDS
- $(MAKE) $(OPENRC_MAKE_OPTS) DESTDIR=$(TARGET_DIR) -C $(@D) install
+define OPENRC_INSTALL_SYSV_RCS_SCRIPT
$(INSTALL) -D -m 0755 $(OPENRC_PKGDIR)/sysv-rcs \
$(TARGET_DIR)/etc/init.d/sysv-rcs
endef
+OPENRC_POST_INSTALL_TARGET_HOOKS += OPENRC_INSTALL_SYSV_RCS_SCRIPT
ifeq ($(BR2_PACKAGE_KBD),)
# keymaps and save-keymaps require kbd_mode and dumpkeys, respectively, so
@@ -90,4 +78,4 @@ endef
OPENRC_TARGET_FINALIZE_HOOKS += OPENRC_SET_GETTY
endif # BR2_TARGET_GENERIC_GETTY
-$(eval $(generic-package))
+$(eval $(meson-package))
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v5 2/4] package/openrc: add linux-pam support
2023-10-17 11:08 [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Adam Duskett
@ 2023-10-17 11:08 ` Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 3/4] package/openrc: add bash-completion support Adam Duskett
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Adam Duskett @ 2023-10-17 11:08 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Adam Duskett, Michał Łyszczek
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
package/openrc/openrc.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/openrc/openrc.mk b/package/openrc/openrc.mk
index 8cc488a081..908b44190a 100644
--- a/package/openrc/openrc.mk
+++ b/package/openrc/openrc.mk
@@ -14,7 +14,6 @@ OPENRC_DEPENDENCIES = ncurses
OPENRC_CONF_OPTS = \
-Dos=Linux \
- -Dpam=false \
-Dlibrcdir=/usr/libexec/rc \
-Dpkgconfig=false \
-Dsysvinit=true \
@@ -28,6 +27,13 @@ else
OPENRC_CONF_OPTS += -Dselinux=disabled
endif
+ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
+OPENRC_CONF_OPTS += -Dpam=true
+OPENRC_DEPENDENCIES += linux-pam
+else
+OPENRC_CONF_OPTS += -Dpam=false
+endif
+
define OPENRC_INSTALL_SYSV_RCS_SCRIPT
$(INSTALL) -D -m 0755 $(OPENRC_PKGDIR)/sysv-rcs \
$(TARGET_DIR)/etc/init.d/sysv-rcs
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH v5 3/4] package/openrc: add bash-completion support
2023-10-17 11:08 [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 2/4] package/openrc: add linux-pam support Adam Duskett
@ 2023-10-17 11:08 ` Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 4/4] package/openrc: add split-user support Adam Duskett
2023-11-01 18:14 ` [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Thomas Petazzoni via buildroot
3 siblings, 0 replies; 5+ messages in thread
From: Adam Duskett @ 2023-10-17 11:08 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Adam Duskett, Michał Łyszczek
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
package/openrc/openrc.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/openrc/openrc.mk b/package/openrc/openrc.mk
index 908b44190a..e3f51d45d1 100644
--- a/package/openrc/openrc.mk
+++ b/package/openrc/openrc.mk
@@ -20,6 +20,12 @@ OPENRC_CONF_OPTS = \
-Drootprefix=/ \
-Dbranding="\"Buildroot $(BR2_VERSION_FULL)\""
+ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
+OPENRC_CONF_OPTS += -Dbash-completions=true
+else
+OPENRC_CONF_OPTS += -Dbash-completions=false
+endif
+
ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
OPENRC_CONF_OPTS += -Dselinux=enabled
OPENRC_DEPENDENCIES += libselinux
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v5 4/4] package/openrc: add split-user support
2023-10-17 11:08 [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 2/4] package/openrc: add linux-pam support Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 3/4] package/openrc: add bash-completion support Adam Duskett
@ 2023-10-17 11:08 ` Adam Duskett
2023-11-01 18:14 ` [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Thomas Petazzoni via buildroot
3 siblings, 0 replies; 5+ messages in thread
From: Adam Duskett @ 2023-10-17 11:08 UTC (permalink / raw)
To: buildroot; +Cc: Eric Le Bihan, Adam Duskett, Michał Łyszczek
Also, introduce a new test in support/testing/tests/init/test_openrc.py that
ensures split-user support works properly.
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
V2 -> V3: Fixed inverse logic [Yann.]
V3 -> V4: Add missing test
package/openrc/openrc.mk | 6 ++++++
support/testing/tests/init/test_openrc.py | 12 ++++++++++++
2 files changed, 18 insertions(+)
diff --git a/package/openrc/openrc.mk b/package/openrc/openrc.mk
index e3f51d45d1..63aec7615e 100644
--- a/package/openrc/openrc.mk
+++ b/package/openrc/openrc.mk
@@ -40,6 +40,12 @@ else
OPENRC_CONF_OPTS += -Dpam=false
endif
+ifeq ($(BR2_ROOTFS_MERGED_USR),y)
+OPENRC_CONF_OPTS += -Dsplit-usr=false
+else
+OPENRC_CONF_OPTS += -Dsplit-usr=true
+endif
+
define OPENRC_INSTALL_SYSV_RCS_SCRIPT
$(INSTALL) -D -m 0755 $(OPENRC_PKGDIR)/sysv-rcs \
$(TARGET_DIR)/etc/init.d/sysv-rcs
diff --git a/support/testing/tests/init/test_openrc.py b/support/testing/tests/init/test_openrc.py
index c6ade7676d..c60e079bfa 100644
--- a/support/testing/tests/init/test_openrc.py
+++ b/support/testing/tests/init/test_openrc.py
@@ -44,3 +44,15 @@ class TestInitSystemOpenrcRwFull(InitSystemOpenrcBase):
def test_run(self):
self.start_emulator("ext2")
self.check_init()
+
+class TestInitSystemOpenrcMergedUsrFull(InitSystemOpenrcBase):
+ config = InitSystemOpenrcBase.config + \
+ """
+ BR2_ROOTFS_MERGED_USR=y
+ BR2_SYSTEM_DHCP="eth0"
+ BR2_TARGET_ROOTFS_EXT2=y
+ """
+
+ def test_run(self):
+ self.start_emulator("ext2")
+ self.check_init()
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51
2023-10-17 11:08 [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Adam Duskett
` (2 preceding siblings ...)
2023-10-17 11:08 ` [Buildroot] [PATCH v5 4/4] package/openrc: add split-user support Adam Duskett
@ 2023-11-01 18:14 ` Thomas Petazzoni via buildroot
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-01 18:14 UTC (permalink / raw)
To: Adam Duskett; +Cc: Eric Le Bihan, Michał Łyszczek, buildroot
On Tue, 17 Oct 2023 13:08:06 +0200
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> OpenRC has not been updated for quite some time, and much has changed.
>
> - Convert to a meson package.
>
> - Update the license hash as the year has changed from 2015 to 2023.
>
> - Introduce one new patch:
>
> - 0007-allow-setting-rc_libexecdir-path.patch: Introduces the previous
> behavior of setting the rc directory to /usr/libexec/rc.
> (Upstream: Upstream: https://github.com/OpenRC/openrc/pull/443)
>
> - Install the sysv-rcs script in the new OPENRC_INSTALL_SYSV_RCS_SCRIPT
> post install hook as the OPENRC_BUILD_CMDS define no longer exists.
>
> Tested with tests.init.test_openrc all tests pass.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> v4 -> v5: bump to 0.51
Series applied to master, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-11-01 18:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-17 11:08 [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 2/4] package/openrc: add linux-pam support Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 3/4] package/openrc: add bash-completion support Adam Duskett
2023-10-17 11:08 ` [Buildroot] [PATCH v5 4/4] package/openrc: add split-user support Adam Duskett
2023-11-01 18:14 ` [Buildroot] [PATCH v5 1/4] package/openrc: bump version to 0.51 Thomas Petazzoni via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox