Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Colin Foster <colin.foster@in-advantage.com>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package: python-tftpy: add python-tftpy package
Date: Wed, 1 Nov 2023 23:10:19 +0100	[thread overview]
Message-ID: <20231101231019.4e297333@windsurf> (raw)
In-Reply-To: <20231024214108.1602700-1-colin.foster@in-advantage.com>

Hello Colin,

On Tue, 24 Oct 2023 16:41:08 -0500
Colin Foster <colin.foster@in-advantage.com> wrote:

> tftpy is described as a pure Python impelemtation of the Trivial FTP
> protocol. Add support for this package.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>

Thanks for your contribution, which I have applied, after doing a few
changes (see below). 

One thing that would be really good to add is a small test case for
this package, in support/testing/. You can have a look at all the
support/testing/tests/package/test_python* tests for some examples on
how to do this.

>  package/Config.in                      |  1 +
>  package/python-tftpy/Config.in         |  7 +++++++
>  package/python-tftpy/python-tftpy.hash |  3 +++
>  package/python-tftpy/python-tftpy.mk   | 15 +++++++++++++++
>  4 files changed, 26 insertions(+)

Entry in the DEVELOPERS file was missing.


> +PYTHON_TFTPY_VERSION = 0.8.2
> +PYTHON_TFTPY_SITE_METHOD = git
> +PYTHON_TFTPY_SITE = https://github.com/msoulier/tftpy.git

I switched to using the github macro instead:

+PYTHON_TFTPY_VERSION = 0.8.2
+PYTHON_TFTPY_SITE = $(call github,msoulier,tftpy,$(PYTHON_TFTPY_VERSION))
+PYTHON_TFTPY_LICENSE = MIT

Applied with those changes. Thanks again!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-01 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-24 21:41 [Buildroot] [PATCH] package: python-tftpy: add python-tftpy package Colin Foster
2023-11-01 22:10 ` Thomas Petazzoni via buildroot [this message]
2023-12-01 14:02   ` Colin Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231101231019.4e297333@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=colin.foster@in-advantage.com \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox