[Buildroot] [PATCH] package: python-tftpy: add python-tftpy package

[Buildroot] [PATCH] package: python-tftpy: add python-tftpy package

[Colin Foster]

tftpy is described as a pure Python impelemtation of the Trivial FTP
protocol. Add support for this package.

Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
---
 package/Config.in                      |  1 +
 package/python-tftpy/Config.in         |  7 +++++++
 package/python-tftpy/python-tftpy.hash |  3 +++
 package/python-tftpy/python-tftpy.mk   | 15 +++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/python-tftpy/Config.in
 create mode 100644 package/python-tftpy/python-tftpy.hash
 create mode 100644 package/python-tftpy/python-tftpy.mk

diff --git a/package/Config.in b/package/Config.in
index 4e489c4706..fa75fbdaa9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1337,6 +1337,7 @@ menu "External python modules"
 	source "package/python-termcolor/Config.in"
 	source "package/python-terminaltables/Config.in"
 	source "package/python-texttable/Config.in"
+	source "package/python-tftpy/Config.in"
 	source "package/python-thrift/Config.in"
 	source "package/python-tinycss2/Config.in"
 	source "package/python-tinyrpc/Config.in"
diff --git a/package/python-tftpy/Config.in b/package/python-tftpy/Config.in
new file mode 100644
index 0000000000..ef21ac58de
--- /dev/null
+++ b/package/python-tftpy/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_TFTPY
+	bool "python-tftpy"
+	help
+	  tftpy is a pure Python implementation of the
+	  Trivial FTP protocol.
+
+	  https://github.com/msoulier/tftpy
diff --git a/package/python-tftpy/python-tftpy.hash b/package/python-tftpy/python-tftpy.hash
new file mode 100644
index 0000000000..86f0415cc3
--- /dev/null
+++ b/package/python-tftpy/python-tftpy.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256  ae359356106dfc4301e7fd66684302f7cadcb8ec9da7d10b7e42ffd16d611aec  python-tftpy-0.8.2-br1.tar.gz
+sha256  4616f0c71e62ce2e0f6cdd3aef6d3c285f8730c9304b88a9f3ce3f14c2e6f756  LICENSE
diff --git a/package/python-tftpy/python-tftpy.mk b/package/python-tftpy/python-tftpy.mk
new file mode 100644
index 0000000000..9479aedb3e
--- /dev/null
+++ b/package/python-tftpy/python-tftpy.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-tftpy
+#
+################################################################################
+
+PYTHON_TFTPY_VERSION = 0.8.2
+PYTHON_TFTPY_SITE_METHOD = git
+PYTHON_TFTPY_SITE = https://github.com/msoulier/tftpy.git
+PYTHON_TFTPY_LICENSE = MIT
+PYTHON_TFTPY_LICENSE_FILES = LICENSE.txt
+
+PYTHON_TFTPY_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package: python-tftpy: add python-tftpy package

[Thomas Petazzoni via buildroot]

Hello Colin,

On Tue, 24 Oct 2023 16:41:08 -0500
Colin Foster <colin.foster@in-advantage.com> wrote:

> tftpy is described as a pure Python impelemtation of the Trivial FTP
> protocol. Add support for this package.
> 
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>

Thanks for your contribution, which I have applied, after doing a few
changes (see below). 

One thing that would be really good to add is a small test case for
this package, in support/testing/. You can have a look at all the
support/testing/tests/package/test_python* tests for some examples on
how to do this.

>  package/Config.in                      |  1 +
>  package/python-tftpy/Config.in         |  7 +++++++
>  package/python-tftpy/python-tftpy.hash |  3 +++
>  package/python-tftpy/python-tftpy.mk   | 15 +++++++++++++++
>  4 files changed, 26 insertions(+)

Entry in the DEVELOPERS file was missing.


> +PYTHON_TFTPY_VERSION = 0.8.2
> +PYTHON_TFTPY_SITE_METHOD = git
> +PYTHON_TFTPY_SITE = https://github.com/msoulier/tftpy.git

I switched to using the github macro instead:

+PYTHON_TFTPY_VERSION = 0.8.2
+PYTHON_TFTPY_SITE = $(call github,msoulier,tftpy,$(PYTHON_TFTPY_VERSION))
+PYTHON_TFTPY_LICENSE = MIT

Applied with those changes. Thanks again!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package: python-tftpy: add python-tftpy package

[Colin Foster]

Hi Thomas,

On Wed, Nov 01, 2023 at 11:10:19PM +0100, Thomas Petazzoni wrote:
> Hello Colin,
> 
> On Tue, 24 Oct 2023 16:41:08 -0500
> Colin Foster <colin.foster@in-advantage.com> wrote:
> 
> > tftpy is described as a pure Python impelemtation of the Trivial FTP
> > protocol. Add support for this package.
> > 
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> 
> Thanks for your contribution, which I have applied, after doing a few
> changes (see below). 
> 
> One thing that would be really good to add is a small test case for
> this package, in support/testing/. You can have a look at all the
> support/testing/tests/package/test_python* tests for some examples on
> how to do this.

Thanks for this! It turns out I need to re-test my email filter, as this
response got lumped in with all the rest of the Buildroot emails I get.
The real responses can sneak by.

> Entry in the DEVELOPERS file was missing.
> I switched to using the github macro instead:

I anticipate spending more time in Buildroot in the future, so hopefully
these fixups you need to make become fewer and fewer.


Colin Foster
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot