From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/pppd: disable for sparc and sparc64 architectures
Date: Wed, 1 Nov 2023 23:39:31 +0100 [thread overview]
Message-ID: <20231101233931.25d66334@windsurf> (raw)
In-Reply-To: <20231015204753.5775-1-bernd@kuhls.net>
On Sun, 15 Oct 2023 22:47:53 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> diff --git a/package/pppd/Config.in b/package/pppd/Config.in
> index 88c2180a9b..3ff8123aab 100644
> --- a/package/pppd/Config.in
> +++ b/package/pppd/Config.in
> @@ -1,5 +1,6 @@
> config BR2_PACKAGE_PPPD
> bool "pppd"
> + depends on !BR2_sparc64 && !BR2_sparc
If we wanted to merge that, it should be:
config BR2_PACKAGE_PPPD_ARCH_SUPPORTS
bool
default y if !BR2_sparc64 && !BR2_sparc
However, it's never nice to have to do something like this. Has this
issue been reported to upstream pppd?
Also, it seems like the ppp package in Debian builds on sparc64, see
https://packages.debian.org/sid/ppp. How do they achieve this? I
haven't spotted a particular patch/quirk (but I looked quickly).
In
https://github.com/ppp-project/ppp/blob/master/pppd/termios_linux.h#L14,
the pppd code base is definitely playing with fire. I'm not sure what
they are trying to do, but they know that the inclusion of kernel
headers will cause some redefinition... Perhaps something to discuss
with ppp upstream first.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-01 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 20:47 [Buildroot] [PATCH 1/1] package/pppd: disable for sparc and sparc64 architectures Bernd Kuhls
2023-11-01 22:39 ` Thomas Petazzoni via buildroot [this message]
2024-07-12 19:17 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101233931.25d66334@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox