Re: [Buildroot] [PATCH 1/1] package/pppd: disable for sparc and sparc64 architectures

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bernd,

On Wed, 1 Nov 2023 23:39:31 +0100
Thomas Petazzoni via buildroot <buildroot@buildroot.org> wrote:

> If we wanted to merge that, it should be:
> 
> config BR2_PACKAGE_PPPD_ARCH_SUPPORTS
> 	bool
> 	default y if !BR2_sparc64 && !BR2_sparc
> 
> However, it's never nice to have to do something like this. Has this
> issue been reported to upstream pppd?
> 
> Also, it seems like the ppp package in Debian builds on sparc64, see
> https://packages.debian.org/sid/ppp. How do they achieve this? I
> haven't spotted a particular patch/quirk (but I looked quickly).
> 
> In
> https://github.com/ppp-project/ppp/blob/master/pppd/termios_linux.h#L14,
> the pppd code base is definitely playing with fire. I'm not sure what
> they are trying to do, but they know that the inclusion of kernel
> headers will cause some redefinition... Perhaps something to discuss
> with ppp upstream first.

I finally took some time, narrowed down the issue, and wrote a
work-around. The real fix was in fact done very recently in the Linux
kernel, but it will only appear in Linux 6.10, so we need a workaround
for toolchains that use headers < 6.10.

See my commit at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/b162aab7c6da6b45dc5ba9ad30b59b4362e2dc2e

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot