* [Buildroot] [PATCH 2/5] package/flutter-engine: bump version to 3.13.9
2023-11-02 18:54 [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Adam Duskett
@ 2023-11-02 18:54 ` Adam Duskett
2023-11-03 19:28 ` Thomas Petazzoni via buildroot
2023-11-02 18:54 ` [Buildroot] [PATCH 3/5] package/flutter-engine: use impeller rendering engine Adam Duskett
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Adam Duskett @ 2023-11-02 18:54 UTC (permalink / raw)
To: buildroot; +Cc: Adam Duskett
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
package/flutter-engine/flutter-engine.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/flutter-engine/flutter-engine.mk b/package/flutter-engine/flutter-engine.mk
index 942b07786b..4701c1f536 100644
--- a/package/flutter-engine/flutter-engine.mk
+++ b/package/flutter-engine/flutter-engine.mk
@@ -21,7 +21,7 @@
#
# There is no hash provided, as the gn binary (used for configuration) relies
# on the .git directories. As such, a reproducible tarball is not possible.
-FLUTTER_ENGINE_VERSION = 3.13.4
+FLUTTER_ENGINE_VERSION = 3.13.9
# There is nothing for Buildroot to download. This is handled by gclient.
FLUTTER_ENGINE_SITE =
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 3/5] package/flutter-engine: use impeller rendering engine
2023-11-02 18:54 [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Adam Duskett
2023-11-02 18:54 ` [Buildroot] [PATCH 2/5] package/flutter-engine: " Adam Duskett
@ 2023-11-02 18:54 ` Adam Duskett
2023-11-03 19:29 ` Thomas Petazzoni via buildroot
2023-11-02 18:54 ` [Buildroot] [PATCH 4/5] package/flutter-pi: bump version to 8f4e9726a18b32822b6e7faf19c044f88bded570 Adam Duskett
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Adam Duskett @ 2023-11-02 18:54 UTC (permalink / raw)
To: buildroot; +Cc: Adam Duskett
From: https://docs.flutter.dev/perf/impeller
Impeller provides a new rendering runtime for Flutter. The Flutter team’s
believes this solves Flutter’s early-onset jank issue. Impeller precompiles a
smaller, simpler set of shaders at Engine build time so they don’t compile at
runtime.
Impeller has the following objectives:
- Predictable performance: Impeller compiles all shaders and reflection
offline at build time. It builds all pipeline state objects upfront.
The engine controls caching and caches explicitly.
- Instrumentable: Impeller tags and labels all graphics resources like
textures, and buffers. It can capture and persist animations to disk
without affecting per-frame rendering performance.
- Portable: Flutter doesn’t tie Impeller to a specific client rendering API.
You can author shaders once and convert them to backend-specific formats as
necessary.
- Leverages modern graphics APIs: Impeller uses, but doesn’t depend on,
features available in modern APIs like Metal and Vulkan.
- Leverages concurrency: Impeller can distribute single-frame workloads
across multiple threads if necessary.
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
package/flutter-engine/flutter-engine.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/flutter-engine/flutter-engine.mk b/package/flutter-engine/flutter-engine.mk
index 4701c1f536..32aaa1cccf 100644
--- a/package/flutter-engine/flutter-engine.mk
+++ b/package/flutter-engine/flutter-engine.mk
@@ -124,6 +124,7 @@ endif
ifeq ($(BR2_PACKAGE_HAS_LIBGLES),y)
FLUTTER_ENGINE_DEPENDENCIES += libgles
+FLUTTER_ENGINE_CONF_OPTS += --enable-impeller-opengles
endif
ifeq ($(BR2_PACKAGE_LIBGLFW),y)
@@ -142,7 +143,7 @@ endif
# There is no --disable-vulkan option
ifeq ($(BR2_PACKAGE_MESA3D_VULKAN_DRIVER),y)
-FLUTTER_ENGINE_CONF_OPTS += --enable-vulkan
+FLUTTER_ENGINE_CONF_OPTS += --enable-vulkan --enable-impeller-vulkan
endif
ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_LIBXCB),yy)
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* [Buildroot] [PATCH 4/5] package/flutter-pi: bump version to 8f4e9726a18b32822b6e7faf19c044f88bded570
2023-11-02 18:54 [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Adam Duskett
2023-11-02 18:54 ` [Buildroot] [PATCH 2/5] package/flutter-engine: " Adam Duskett
2023-11-02 18:54 ` [Buildroot] [PATCH 3/5] package/flutter-engine: use impeller rendering engine Adam Duskett
@ 2023-11-02 18:54 ` Adam Duskett
2023-11-03 19:30 ` Thomas Petazzoni via buildroot
2023-11-02 18:54 ` [Buildroot] [PATCH 5/5] package/flutter-pi: add charset converter plugin option Adam Duskett
2023-11-03 19:28 ` [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Thomas Petazzoni via buildroot
4 siblings, 1 reply; 9+ messages in thread
From: Adam Duskett @ 2023-11-02 18:54 UTC (permalink / raw)
To: buildroot; +Cc: Adam Duskett
- Drop upstream 0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
- Disable new charset converter plugin.
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
...er_surface-properly-fallback-to-surf.patch | 59 -------------------
package/flutter-pi/flutter-pi.hash | 2 +-
package/flutter-pi/flutter-pi.mk | 3 +-
3 files changed, 3 insertions(+), 61 deletions(-)
delete mode 100644 package/flutter-pi/0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
diff --git a/package/flutter-pi/0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch b/package/flutter-pi/0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
deleted file mode 100644
index 7a1a49b3d4..0000000000
--- a/package/flutter-pi/0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
+++ /dev/null
@@ -1,59 +0,0 @@
-From 856f9849763535d62ed01b538ba23905875c93f4 Mon Sep 17 00:00:00 2001
-From: "Yann E. MORIN" <yann.morin.1998@free.fr>
-Date: Tue, 26 Sep 2023 20:31:17 +0200
-Subject: [PATCH] src/egl_gbm_render_surface: properly fallback to surface with
- no modifier
-
-In 869fa7fcfbeb, we added a fallback to be able to create an EGL sruface
-when the driver do not support modifiers, like the llvmpipe software
-renderer (or like some proprietary drivers, like the MALI ones), as
-reported in #269 [0].
-
-However, in c6537673c9b6, there was a big overhaul of renderer
-infrastructure. That commit lost the with-modifiers code path and only
-kept the without-modifiers fallback one (i.e. it only kept the call to
-gbm_surface_create(), not to gbm_surface_create_with_modifiers()).
-
-Then in b0d09f5032a4, the with-modifier code path was re-instated, but
-in a way that made it exclusive with the without-modifiers one. That is,
-the without-modifiers code path was not a fallback to when the other
-failed.
-
-Re-instate the fallback mechanism as intiially implemented.
-
-[0] https://github.com/ardera/flutter-pi/issues/269
-
-Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
-Upstream: https://github.com/ardera/flutter-pi/pull/367
----
- src/egl_gbm_render_surface.c | 6 ++++--
- 1 file changed, 4 insertions(+), 2 deletions(-)
-
-diff --git a/src/egl_gbm_render_surface.c b/src/egl_gbm_render_surface.c
-index ce9e5e7..8a58667 100644
---- a/src/egl_gbm_render_surface.c
-+++ b/src/egl_gbm_render_surface.c
-@@ -146,6 +146,7 @@ static int egl_gbm_render_surface_init(
- }
- #endif
-
-+ gbm_surface = NULL;
- if (allowed_modifiers != NULL) {
- gbm_surface = gbm_surface_create_with_modifiers(
- gbm_device,
-@@ -158,9 +159,10 @@ static int egl_gbm_render_surface_init(
- if (gbm_surface == NULL) {
- ok = errno;
- LOG_ERROR("Couldn't create GBM surface for rendering. gbm_surface_create_with_modifiers: %s\n", strerror(ok));
-- return ok;
-+ LOG_ERROR("Will retry without modifiers\n");
- }
-- } else {
-+ }
-+ if (gbm_surface == NULL) {
- gbm_surface = gbm_surface_create(
- gbm_device,
- size.x,
---
-2.25.1
-
diff --git a/package/flutter-pi/flutter-pi.hash b/package/flutter-pi/flutter-pi.hash
index f7148963a4..bb8f52c608 100644
--- a/package/flutter-pi/flutter-pi.hash
+++ b/package/flutter-pi/flutter-pi.hash
@@ -1,3 +1,3 @@
# Locally calculated
-sha256 e4af79c8f53c15913f52a83a221f099a2a750d023a0bc4560d0db6f15def79a2 flutter-pi-d62e84350d2869b3ec1dfb1af21bfe234c4b817f-br1.tar.gz
+sha256 ecb1557020afc22b30a4361230a4ed09be2493d420fed5e89cd93698a008a2fd flutter-pi-8f4e9726a18b32822b6e7faf19c044f88bded570-br1.tar.gz
sha256 b34df9d3e1b4e5d1ba70b1740ec74b69f1189b44efd0c96b898b074ef8db1c70 LICENSE
diff --git a/package/flutter-pi/flutter-pi.mk b/package/flutter-pi/flutter-pi.mk
index 27f140c177..491c074e13 100644
--- a/package/flutter-pi/flutter-pi.mk
+++ b/package/flutter-pi/flutter-pi.mk
@@ -4,7 +4,7 @@
#
################################################################################
-FLUTTER_PI_VERSION = d62e84350d2869b3ec1dfb1af21bfe234c4b817f
+FLUTTER_PI_VERSION = 8f4e9726a18b32822b6e7faf19c044f88bded570
FLUTTER_PI_SITE = https://github.com/ardera/flutter-pi.git
FLUTTER_PI_SITE_METHOD = git
FLUTTER_PI_LICENSE = MIT
@@ -27,6 +27,7 @@ FLUTTER_PI_CONF_OPTS = \
-DENABLE_VULKAN=OFF \
-DFILESYSTEM_LAYOUT=meta-flutter \
-DLINT_EGL_HEADERS=OFF \
+ -DBUILD_CHARSET_CONVERTER_PLUGIN=OFF \
-DTRY_BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN=OFF \
-DTRY_BUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN=OFF \
-DTRY_ENABLE_OPENGL=OFF \
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH 4/5] package/flutter-pi: bump version to 8f4e9726a18b32822b6e7faf19c044f88bded570
2023-11-02 18:54 ` [Buildroot] [PATCH 4/5] package/flutter-pi: bump version to 8f4e9726a18b32822b6e7faf19c044f88bded570 Adam Duskett
@ 2023-11-03 19:30 ` Thomas Petazzoni via buildroot
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-03 19:30 UTC (permalink / raw)
To: Adam Duskett; +Cc: buildroot
On Thu, 2 Nov 2023 12:54:10 -0600
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> - Drop upstream 0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
> - Disable new charset converter plugin.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> ...er_surface-properly-fallback-to-surf.patch | 59 -------------------
> package/flutter-pi/flutter-pi.hash | 2 +-
> package/flutter-pi/flutter-pi.mk | 3 +-
> 3 files changed, 3 insertions(+), 61 deletions(-)
> delete mode 100644 package/flutter-pi/0001-src-egl_gbm_render_surface-properly-fallback-to-surf.patch
I don't get the same hash:
ERROR: expected: ecb1557020afc22b30a4361230a4ed09be2493d420fed5e89cd93698a008a2fd
ERROR: got : e76b06bb5e93546b16c85f1f9e01c71a550cb05909e16b67eb0b03690ea38e6f
Could you double check?
I marked this patch and PATCH 5/5 as Changes Requested.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 5/5] package/flutter-pi: add charset converter plugin option
2023-11-02 18:54 [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Adam Duskett
` (2 preceding siblings ...)
2023-11-02 18:54 ` [Buildroot] [PATCH 4/5] package/flutter-pi: bump version to 8f4e9726a18b32822b6e7faf19c044f88bded570 Adam Duskett
@ 2023-11-02 18:54 ` Adam Duskett
2023-11-03 19:28 ` [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Thomas Petazzoni via buildroot
4 siblings, 0 replies; 9+ messages in thread
From: Adam Duskett @ 2023-11-02 18:54 UTC (permalink / raw)
To: buildroot; +Cc: Adam Duskett
Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
---
package/flutter-pi/Config.in | 7 +++++++
package/flutter-pi/flutter-pi.mk | 7 ++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/package/flutter-pi/Config.in b/package/flutter-pi/Config.in
index ecebfad89b..45b6b4faef 100644
--- a/package/flutter-pi/Config.in
+++ b/package/flutter-pi/Config.in
@@ -23,6 +23,13 @@ if BR2_PACKAGE_FLUTTER_PI
comment "plugins"
+config BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN
+ bool "charset converter"
+ help
+ Adds platform-side implementation of charset_converter plugin.
+
+ See: https://pub.dev/packages/charset_converter
+
config BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN
bool "gstreamer audio player"
depends on BR2_PACKAGE_HAS_LIBGLES
diff --git a/package/flutter-pi/flutter-pi.mk b/package/flutter-pi/flutter-pi.mk
index 491c074e13..8bf25da008 100644
--- a/package/flutter-pi/flutter-pi.mk
+++ b/package/flutter-pi/flutter-pi.mk
@@ -27,7 +27,6 @@ FLUTTER_PI_CONF_OPTS = \
-DENABLE_VULKAN=OFF \
-DFILESYSTEM_LAYOUT=meta-flutter \
-DLINT_EGL_HEADERS=OFF \
- -DBUILD_CHARSET_CONVERTER_PLUGIN=OFF \
-DTRY_BUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN=OFF \
-DTRY_BUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN=OFF \
-DTRY_ENABLE_OPENGL=OFF \
@@ -43,6 +42,12 @@ else
FLUTTER_PI_CONF_OPTS += -DLTO=OFF
endif
+ifeq ($(BR2_PACKAGE_FLUTTER_PI_CHARSET_CONVERTER_PLUGIN),y)
+FLUTTER_PI_CONF_OPTS += -DBUILD_CHARSET_CONVERTER_PLUGIN=ON
+else
+FLUTTER_PI_CONF_OPTS += -DBUILD_CHARSET_CONVERTER_PLUGIN=OFF
+endif
+
ifeq ($(BR2_PACKAGE_FLUTTER_PI_GSTREAMER_AUDIO_PLAYER_PLUGIN),y)
FLUTTER_PI_DEPENDENCIES += gstreamer1 gst1-plugins-base
FLUTTER_PI_CONF_OPTS += -DBUILD_GSTREAMER_AUDIO_PLAYER_PLUGIN=ON
--
2.41.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9
2023-11-02 18:54 [Buildroot] [PATCH 1/5] package/flutter-sdk-bin: bump version to 3.13.9 Adam Duskett
` (3 preceding siblings ...)
2023-11-02 18:54 ` [Buildroot] [PATCH 5/5] package/flutter-pi: add charset converter plugin option Adam Duskett
@ 2023-11-03 19:28 ` Thomas Petazzoni via buildroot
4 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-03 19:28 UTC (permalink / raw)
To: Adam Duskett; +Cc: buildroot
On Thu, 2 Nov 2023 12:54:07 -0600
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> package/flutter-sdk-bin/flutter-sdk-bin.hash | 2 +-
> package/flutter-sdk-bin/flutter-sdk-bin.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 9+ messages in thread