[Buildroot] [PATCH 1/7] configs/pine64_defconfig: bump Linux version to 6.1 Linux Kernel and Header version upgraded to 6.1.50 LTS

[Buildroot] [PATCH 1/7] configs/pine64_defconfig: bump Linux version to 6.1 Linux Kernel and Header version upgraded to 6.1.50 LTS

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 configs/pine64_defconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
index c454114d2a..e2549628ee 100644
--- a/configs/pine64_defconfig
+++ b/configs/pine64_defconfig
@@ -2,8 +2,8 @@ BR2_aarch64=y
 BR2_cortex_a53=y
 BR2_ARM_FPU_VFPV4=y
 
-# Linux headers same as kernel, a 5.0 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_0=y
+# Linux headers same as kernel, a 6.1 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 
 # Firmware
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
@@ -32,7 +32,7 @@ BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/pine64/pine64/boot.cmd"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.0"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.1.60"
 BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="allwinner/sun50i-a64-pine64"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/7] configs/pine64_defconfig: bump ATF version to v2.9

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 configs/pine64_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
index e2549628ee..8d2324260c 100644
--- a/configs/pine64_defconfig
+++ b/configs/pine64_defconfig
@@ -8,7 +8,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_1=y
 # Firmware
 BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7"
+BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.9"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/7] configs/pine64_defconfig: bump Uboot version to 2023.04

[Javad Rahimipetroudi]

The Uboot version has upgraded to 2023.04.
Furthermore, the custom itb was no longer required. So it has been deleted.

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 configs/pine64_defconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
index 8d2324260c..b567462f5d 100644
--- a/configs/pine64_defconfig
+++ b/configs/pine64_defconfig
@@ -16,15 +16,17 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.01"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"
 BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pine64_plus"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
 BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
 BR2_TARGET_UBOOT_SPL=y
-BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
+BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
+BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
 BR2_PACKAGE_HOST_UBOOT_TOOLS=y
 BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT=y
 BR2_PACKAGE_HOST_UBOOT_TOOLS_BOOT_SCRIPT_SOURCE="board/pine64/pine64/boot.cmd"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/7] configs/pine64_defconfig: bump Uboot version to 2023.04

[Thomas Petazzoni via buildroot]

On Sat,  4 Nov 2023 10:54:54 +0330
Javad Rahimipetroudi <javad321javad@gmail.com> wrote:

> The Uboot version has upgraded to 2023.04.
> Furthermore, the custom itb was no longer required. So it has been deleted.

Where is it deleted? I don't see anything related in this commit.

> diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
> index 8d2324260c..b567462f5d 100644
> --- a/configs/pine64_defconfig
> +++ b/configs/pine64_defconfig
> @@ -16,15 +16,17 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.01"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2023.04"
>  BR2_TARGET_UBOOT_BOARD_DEFCONFIG="pine64_plus"
>  BR2_TARGET_UBOOT_NEEDS_DTC=y
>  BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>  BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
>  BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
>  BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
>  BR2_TARGET_UBOOT_SPL=y
> -BR2_TARGET_UBOOT_SPL_NAME="spl/sunxi-spl.bin"
> +BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"

These should most likely have some explanations in the commit log.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 4/7] configs/pine64_defconfig: add dynamic mdev To add networking support, dynamic mdev is required to load network drivers.

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 configs/pine64_defconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
index b567462f5d..5cb4b4a0b5 100644
--- a/configs/pine64_defconfig
+++ b/configs/pine64_defconfig
@@ -42,9 +42,13 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
 
 # Filesystem
 BR2_TARGET_GENERIC_ISSUE="Welcome to PINE64"
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_SYSTEM_DHCP="eth0"
+
 BR2_TARGET_ROOTFS_EXT2=y
 BR2_TARGET_ROOTFS_EXT2_4=y
-BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
+
 BR2_PACKAGE_HOST_GENIMAGE=y
 BR2_PACKAGE_HOST_MTOOLS=y
 BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 4/7] configs/pine64_defconfig: add dynamic mdev To add networking support, dynamic mdev is required to load network drivers.

[Thomas Petazzoni via buildroot]

Hello,

The commit title is too long.

On Sat,  4 Nov 2023 10:54:55 +0330
Javad Rahimipetroudi <javad321javad@gmail.com> wrote:

> Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
> ---
>  configs/pine64_defconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
> index b567462f5d..5cb4b4a0b5 100644
> --- a/configs/pine64_defconfig
> +++ b/configs/pine64_defconfig
> @@ -42,9 +42,13 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
>  
>  # Filesystem
>  BR2_TARGET_GENERIC_ISSUE="Welcome to PINE64"
> +BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
> +BR2_SYSTEM_DHCP="eth0"
> +
>  BR2_TARGET_ROOTFS_EXT2=y
>  BR2_TARGET_ROOTFS_EXT2_4=y
> -BR2_PACKAGE_HOST_DOSFSTOOLS=y

Why are you removing this package?

> +BR2_TARGET_ROOTFS_EXT2_SIZE="128M"

This is not explained in the commit log. Why does the size needs to be
increased? Is it because the Linux 6.1 kernel is bigger, and has more
kernel modules? If so, this change should be together with the kernel
update.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 5/7] configs/pine64_defconfig: remove unnecessary configs

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 configs/pine64_defconfig | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/configs/pine64_defconfig b/configs/pine64_defconfig
index 5cb4b4a0b5..c58bb12d94 100644
--- a/configs/pine64_defconfig
+++ b/configs/pine64_defconfig
@@ -1,5 +1,4 @@
 BR2_aarch64=y
-BR2_cortex_a53=y
 BR2_ARM_FPU_VFPV4=y
 
 # Linux headers same as kernel, a 6.1 series
@@ -10,7 +9,7 @@ BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.9"
 BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="sun50i_a64"
-BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31=y
+
 
 # Bootloader
 BR2_TARGET_UBOOT=y
@@ -22,8 +21,6 @@ BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_PYLIBFDT=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
-BR2_TARGET_UBOOT_FORMAT_CUSTOM=y
-BR2_TARGET_UBOOT_FORMAT_CUSTOM_NAME="u-boot.itb"
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="u-boot-sunxi-with-spl.bin"
 BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="SCP=/dev/null"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 6/7] board/pine64/genimage.cfg: rename uboot bin image The generated image name modified according to uboot output

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 board/pine64/pine64/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/pine64/genimage.cfg
index 06b4ed1056..37ebe5ea6e 100644
--- a/board/pine64/pine64/genimage.cfg
+++ b/board/pine64/pine64/genimage.cfg
@@ -16,7 +16,7 @@ image sdcard.img {
 
 	partition spl {
 		in-partition-table = "no"
-		image = "sunxi-spl.bin"
+		image = "u-boot-sunxi-with-spl.bin"
 		offset = 8K
 	}
 
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 6/7] board/pine64/genimage.cfg: rename uboot bin image The generated image name modified according to uboot output

[Thomas Petazzoni via buildroot]

On Sat,  4 Nov 2023 10:54:57 +0330
Javad Rahimipetroudi <javad321javad@gmail.com> wrote:

> Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
> ---
>  board/pine64/pine64/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/pine64/genimage.cfg
> index 06b4ed1056..37ebe5ea6e 100644
> --- a/board/pine64/pine64/genimage.cfg
> +++ b/board/pine64/pine64/genimage.cfg
> @@ -16,7 +16,7 @@ image sdcard.img {
>  
>  	partition spl {
>  		in-partition-table = "no"
> -		image = "sunxi-spl.bin"
> +		image = "u-boot-sunxi-with-spl.bin"

This should go together with the U-Boot update, otherwise your series
is not bisectable.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 7/7] board/pine64/genimage.cfg: remove unnecessary partition for itb For minimal booting, uboot.itf is no longer required, so the correspondig partition deleted.

[Javad Rahimipetroudi]

Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
---
 board/pine64/pine64/genimage.cfg | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/pine64/genimage.cfg
index 37ebe5ea6e..23b02973dd 100644
--- a/board/pine64/pine64/genimage.cfg
+++ b/board/pine64/pine64/genimage.cfg
@@ -20,13 +20,6 @@ image sdcard.img {
 		offset = 8K
 	}
 
-	partition u-boot {
-		in-partition-table = "no"
-		image = "u-boot.itb"
-		offset = 40K
-		size = 1M # 1MB - 40KB
-	}
-
 	partition boot {
 		partition-type = 0xC
 		bootable = "true"
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 7/7] board/pine64/genimage.cfg: remove unnecessary partition for itb For minimal booting, uboot.itf is no longer required, so the correspondig partition deleted.

[Thomas Petazzoni via buildroot]

Hello,

Commit title is too long. You need to have a short title, then an empty
new line, then a longer commit log, potentially in multiple paragraphs,
that explains in more details what is happening.

On Sat,  4 Nov 2023 10:54:58 +0330
Javad Rahimipetroudi <javad321javad@gmail.com> wrote:

> Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
> ---
>  board/pine64/pine64/genimage.cfg | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/pine64/genimage.cfg
> index 37ebe5ea6e..23b02973dd 100644
> --- a/board/pine64/pine64/genimage.cfg
> +++ b/board/pine64/pine64/genimage.cfg
> @@ -20,13 +20,6 @@ image sdcard.img {
>  		offset = 8K
>  	}
>  
> -	partition u-boot {
> -		in-partition-table = "no"
> -		image = "u-boot.itb"
> -		offset = 40K
> -		size = 1M # 1MB - 40KB
> -	}

Not sure where this should go. Together with the U-Boot update,
probably, as it's following the U-Boot update that there's no longer
any u-boot.itb? But then, where is U-Boot stored now?

Overall, your patch series is not correctly split into logical patches
that each do one thing, but do it completely. Your series is not
bisectable, which also isn't good.

Could you rework your patch series according to those comments, and
submit a new version?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 7/7] board/pine64/genimage.cfg: remove unnecessary partition for itb For minimal booting, uboot.itf is no longer required, so the correspondig partition deleted.

[Javad Rahimipetroudi]

Hello Thomas,
Thanks fot your feedback.

On Sat, Nov 4, 2023 at 5:10 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> Commit title is too long. You need to have a short title, then an empty
> new line, then a longer commit log, potentially in multiple paragraphs,
> that explains in more details what is happening.
>
> On Sat,  4 Nov 2023 10:54:58 +0330
> Javad Rahimipetroudi <javad321javad@gmail.com> wrote:
>
> > Signed-off-by: Javad Rahimipetroudi <javad321javad@gmail.com>
> > ---
> >  board/pine64/pine64/genimage.cfg | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/board/pine64/pine64/genimage.cfg b/board/pine64/pine64/genimage.cfg
> > index 37ebe5ea6e..23b02973dd 100644
> > --- a/board/pine64/pine64/genimage.cfg
> > +++ b/board/pine64/pine64/genimage.cfg
> > @@ -20,13 +20,6 @@ image sdcard.img {
> >               offset = 8K
> >       }
> >
> > -     partition u-boot {
> > -             in-partition-table = "no"
> > -             image = "u-boot.itb"
> > -             offset = 40K
> > -             size = 1M # 1MB - 40KB
> > -     }
>
> Not sure where this should go. Together with the U-Boot update,
> probably, as it's following the U-Boot update that there's no longer
> any u-boot.itb? But then, where is U-Boot stored now?
>
> Overall, your patch series is not correctly split into logical patches
> that each do one thing, but do it completely. Your series is not
> bisectable, which also isn't good.
>
> Could you rework your patch series according to those comments, and
> submit a new version?
Sure, I will rework on the patch to merge the related changes in a single patch.
>
> Thanks a lot,
>
Thanks for your feedback on my patch series. I acknowledge your
comments and will rework the series to address the issues you've
raised. I will split the patches into logical and complete ones and
make sure the commit title is short and the commit log is detailed.

I will submit a new version of the patch series once I'm done with the changes.

Thanks again for your feedback.

Best regards,
Javad
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.comHi Thomas,
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot