Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot
@ 2023-10-15 21:05 Bernd Kuhls
  2023-10-15 22:09 ` Yegor Yefremov via buildroot
  2023-11-04 14:02 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Bernd Kuhls @ 2023-10-15 21:05 UTC (permalink / raw)
  To: buildroot

Upstream tarball does not include several header files leading to build
errors with older kernels. For details see:
https://patchwork.kernel.org/project/netdevbpf/patch/20231005163053.1800218-1-florian.fainelli@broadcom.com/

Switch _SITE to git snapshot and add _AUTORECONF = YES which needs
host-pkgconf to fix subsequent configure error:

./configure: line 4723: PKG_PROG_PKG_CONFIG: command not found

./configure: line 5055: syntax error near unexpected token `MNL,'
./configure: line 5055: `    PKG_CHECK_MODULES(MNL, libmnl)'

Fixes:
http://autobuild.buildroot.net/results/69e/69e01b7f370920630d132fc43a40104fa5b3959f/

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/ethtool/ethtool.hash | 3 +--
 package/ethtool/ethtool.mk   | 7 +++++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/package/ethtool/ethtool.hash b/package/ethtool/ethtool.hash
index 8d2bf58420..812e4dd8d1 100644
--- a/package/ethtool/ethtool.hash
+++ b/package/ethtool/ethtool.hash
@@ -1,5 +1,4 @@
-# From https://www.kernel.org/pub/software/network/ethtool/sha256sums.asc
-sha256  814171ea4b8026b081c0741dbbf32e6968311483ecf64711232faec2ac70a14c  ethtool-6.5.tar.xz
 # Locally calculated
+sha256  b1f5fa66f71c3bab9daeacbd77e010b52c47df0a711b216847f78405f3299189  ethtool-6.5.tar.gz
 sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
 sha256  5d632934396f90c82dfebe3c9512648bbb6333b406113d0cd331b0e0aa2d34a1  LICENSE
diff --git a/package/ethtool/ethtool.mk b/package/ethtool/ethtool.mk
index 94d14b123b..ee710e0021 100644
--- a/package/ethtool/ethtool.mk
+++ b/package/ethtool/ethtool.mk
@@ -5,8 +5,11 @@
 ################################################################################
 
 ETHTOOL_VERSION = 6.5
-ETHTOOL_SOURCE = ethtool-$(ETHTOOL_VERSION).tar.xz
-ETHTOOL_SITE = $(BR2_KERNEL_MIRROR)/software/network/ethtool
+ETHTOOL_SITE = https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/snapshot
+# needed only for autoreconf
+ETHTOOL_DEPENDENCIES = host-pkgconf
+# GIT version, shipped without configure
+ETHTOOL_AUTORECONF = YES
 ETHTOOL_LICENSE = GPL-2.0
 ETHTOOL_LICENSE_FILES = LICENSE COPYING
 ETHTOOL_CPE_ID_VENDOR = kernel
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot
  2023-10-15 21:05 [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot Bernd Kuhls
@ 2023-10-15 22:09 ` Yegor Yefremov via buildroot
  2023-11-04 14:02 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Yegor Yefremov via buildroot @ 2023-10-15 22:09 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

On Sun, Oct 15, 2023 at 11:06 PM Bernd Kuhls <bernd@kuhls.net> wrote:
>
> Upstream tarball does not include several header files leading to build
> errors with older kernels. For details see:
> https://patchwork.kernel.org/project/netdevbpf/patch/20231005163053.1800218-1-florian.fainelli@broadcom.com/
>
> Switch _SITE to git snapshot and add _AUTORECONF = YES which needs
> host-pkgconf to fix subsequent configure error:
>
> ./configure: line 4723: PKG_PROG_PKG_CONFIG: command not found
>
> ./configure: line 5055: syntax error near unexpected token `MNL,'
> ./configure: line 5055: `    PKG_CHECK_MODULES(MNL, libmnl)'
>
> Fixes:
> http://autobuild.buildroot.net/results/69e/69e01b7f370920630d132fc43a40104fa5b3959f/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>

> ---
>  package/ethtool/ethtool.hash | 3 +--
>  package/ethtool/ethtool.mk   | 7 +++++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/package/ethtool/ethtool.hash b/package/ethtool/ethtool.hash
> index 8d2bf58420..812e4dd8d1 100644
> --- a/package/ethtool/ethtool.hash
> +++ b/package/ethtool/ethtool.hash
> @@ -1,5 +1,4 @@
> -# From https://www.kernel.org/pub/software/network/ethtool/sha256sums.asc
> -sha256  814171ea4b8026b081c0741dbbf32e6968311483ecf64711232faec2ac70a14c  ethtool-6.5.tar.xz
>  # Locally calculated
> +sha256  b1f5fa66f71c3bab9daeacbd77e010b52c47df0a711b216847f78405f3299189  ethtool-6.5.tar.gz
>  sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
>  sha256  5d632934396f90c82dfebe3c9512648bbb6333b406113d0cd331b0e0aa2d34a1  LICENSE
> diff --git a/package/ethtool/ethtool.mk b/package/ethtool/ethtool.mk
> index 94d14b123b..ee710e0021 100644
> --- a/package/ethtool/ethtool.mk
> +++ b/package/ethtool/ethtool.mk
> @@ -5,8 +5,11 @@
>  ################################################################################
>
>  ETHTOOL_VERSION = 6.5
> -ETHTOOL_SOURCE = ethtool-$(ETHTOOL_VERSION).tar.xz
> -ETHTOOL_SITE = $(BR2_KERNEL_MIRROR)/software/network/ethtool
> +ETHTOOL_SITE = https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/snapshot
> +# needed only for autoreconf
> +ETHTOOL_DEPENDENCIES = host-pkgconf
> +# GIT version, shipped without configure
> +ETHTOOL_AUTORECONF = YES
>  ETHTOOL_LICENSE = GPL-2.0
>  ETHTOOL_LICENSE_FILES = LICENSE COPYING
>  ETHTOOL_CPE_ID_VENDOR = kernel
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot
  2023-10-15 21:05 [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot Bernd Kuhls
  2023-10-15 22:09 ` Yegor Yefremov via buildroot
@ 2023-11-04 14:02 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-04 14:02 UTC (permalink / raw)
  To: Bernd Kuhls; +Cc: buildroot

On Sun, 15 Oct 2023 23:05:48 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> Upstream tarball does not include several header files leading to build
> errors with older kernels. For details see:
> https://patchwork.kernel.org/project/netdevbpf/patch/20231005163053.1800218-1-florian.fainelli@broadcom.com/
> 
> Switch _SITE to git snapshot and add _AUTORECONF = YES which needs
> host-pkgconf to fix subsequent configure error:
> 
> ./configure: line 4723: PKG_PROG_PKG_CONFIG: command not found
> 
> ./configure: line 5055: syntax error near unexpected token `MNL,'
> ./configure: line 5055: `    PKG_CHECK_MODULES(MNL, libmnl)'
> 
> Fixes:
> http://autobuild.buildroot.net/results/69e/69e01b7f370920630d132fc43a40104fa5b3959f/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  package/ethtool/ethtool.hash | 3 +--
>  package/ethtool/ethtool.mk   | 7 +++++--
>  2 files changed, 6 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-04 14:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-15 21:05 [Buildroot] [PATCH 1/1] package/ethtool: switch to git snapshot Bernd Kuhls
2023-10-15 22:09 ` Yegor Yefremov via buildroot
2023-11-04 14:02 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox