Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/libnvme: fix python build
@ 2023-10-02 16:53 Fabrice Fontaine
  2023-10-02 17:20 ` Giulio Benetti
  2023-11-04 20:50 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2023-10-02 16:53 UTC (permalink / raw)
  To: buildroot; +Cc: Giulio Benetti, Fabrice Fontaine

Fix the following build failure raised since the addition of the package
in commit cd7bc6b1c410514765c51821bb8d843f136fea4a:

Program python3 found: YES (/home/autobuild/autobuild/instance-6/output-1/host/bin/python3)
Program swig found: NO

../output-1/build/libnvme-1.5/libnvme/meson.build:15:11: ERROR: Program 'swig' not found or not executable

Fixes:
 - http://autobuild.buildroot.org/results/3cb05b4939eb7d1ce0460088c365402ffcd6b13b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libnvme/libnvme.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
index 71885e198c..c8984093d0 100644
--- a/package/libnvme/libnvme.mk
+++ b/package/libnvme/libnvme.mk
@@ -11,7 +11,7 @@ LIBNVME_LICENSE_FILES = COPYING
 LIBNVME_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_PYTHON3),y)
-LIBNVME_DEPENDENCIES += python3
+LIBNVME_DEPENDENCIES += host-swig python3
 LIBNVME_CONF_OPTS += -Dpython=enabled
 else
 LIBNVME_CONF_OPTS += -Dpython=disabled
-- 
2.40.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libnvme: fix python build
  2023-10-02 16:53 [Buildroot] [PATCH 1/1] package/libnvme: fix python build Fabrice Fontaine
@ 2023-10-02 17:20 ` Giulio Benetti
  2023-11-04 20:50 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Giulio Benetti @ 2023-10-02 17:20 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

Hi Fabrice,

> Il giorno 2 ott 2023, alle ore 18:54, Fabrice Fontaine <fontaine.fabrice@gmail.com> ha scritto:
> 
> Fix the following build failure raised since the addition of the package
> in commit cd7bc6b1c410514765c51821bb8d843f136fea4a:
> 
> Program python3 found: YES (/home/autobuild/autobuild/instance-6/output-1/host/bin/python3)
> Program swig found: NO
> 
> ../output-1/build/libnvme-1.5/libnvme/meson.build:15:11: ERROR: Program 'swig' not found or not executable
> 
> Fixes:
> - http://autobuild.buildroot.org/results/3cb05b4939eb7d1ce0460088c365402ffcd6b13b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thank you for fixing
Giulio

> ---
> package/libnvme/libnvme.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libnvme/libnvme.mk b/package/libnvme/libnvme.mk
> index 71885e198c..c8984093d0 100644
> --- a/package/libnvme/libnvme.mk
> +++ b/package/libnvme/libnvme.mk
> @@ -11,7 +11,7 @@ LIBNVME_LICENSE_FILES = COPYING
> LIBNVME_INSTALL_STAGING = YES
> 
> ifeq ($(BR2_PACKAGE_PYTHON3),y)
> -LIBNVME_DEPENDENCIES += python3
> +LIBNVME_DEPENDENCIES += host-swig python3
> LIBNVME_CONF_OPTS += -Dpython=enabled
> else
> LIBNVME_CONF_OPTS += -Dpython=disabled
> --
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/libnvme: fix python build
  2023-10-02 16:53 [Buildroot] [PATCH 1/1] package/libnvme: fix python build Fabrice Fontaine
  2023-10-02 17:20 ` Giulio Benetti
@ 2023-11-04 20:50 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2023-11-04 20:50 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: Giulio Benetti, buildroot

On Mon,  2 Oct 2023 18:53:45 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since the addition of the package
> in commit cd7bc6b1c410514765c51821bb8d843f136fea4a:
> 
> Program python3 found: YES (/home/autobuild/autobuild/instance-6/output-1/host/bin/python3)
> Program swig found: NO
> 
> ../output-1/build/libnvme-1.5/libnvme/meson.build:15:11: ERROR: Program 'swig' not found or not executable
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/3cb05b4939eb7d1ce0460088c365402ffcd6b13b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libnvme/libnvme.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sorry, I did not notice this patch from you, and merged a similar patch
from Giulio submitted later. Sorry about this :/

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-04 20:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-02 16:53 [Buildroot] [PATCH 1/1] package/libnvme: fix python build Fabrice Fontaine
2023-10-02 17:20 ` Giulio Benetti
2023-11-04 20:50 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox