From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Daniel Price <daniel.price@gmail.com>,
Martin Bark <martin@barkynet.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
Date: Tue, 7 Nov 2023 22:39:25 +0100 [thread overview]
Message-ID: <20231107213925.GL229059@scaer> (raw)
In-Reply-To: <20231105142405.71631-1-giulio.benetti@benettiengineering.com>
Giulio, All,
On 2023-11-05 15:24 +0100, Giulio Benetti spake thusly:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
I have extended the commit log drastically, to explain the situation is
more details, and why we decided to just ignore the issue.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
>
> define NODEJS_SRC_INSTALL_STAGING_CMDS
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-07 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
2023-11-06 9:32 ` Yegor Yefremov via buildroot
2023-11-06 19:13 ` Marcus Hoffmann via buildroot
2023-11-07 21:39 ` Yann E. MORIN [this message]
2023-11-10 17:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231107213925.GL229059@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox