* [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
@ 2023-11-05 14:24 Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Giulio Benetti @ 2023-11-05 14:24 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Martin Bark, Thomas Petazzoni, Daniel Price
At the moment check-bin-arch script finds NodeJS modules containing
prebuilt binaries for different architectures and build fails.
So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
index 6fb550f158..8f934202b0 100644
--- a/package/nodejs/nodejs-src/nodejs-src.mk
+++ b/package/nodejs/nodejs-src/nodejs-src.mk
@@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
# help in diagnosing the problem.
$(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
endef
+
+# Exclude prebuilt binaries with different architectures and OS from check
+NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
endif
define NODEJS_SRC_INSTALL_STAGING_CMDS
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
@ 2023-11-05 14:27 ` Giulio Benetti
2023-11-06 9:32 ` Yegor Yefremov via buildroot
2023-11-06 19:13 ` Marcus Hoffmann via buildroot
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Giulio Benetti @ 2023-11-05 14:27 UTC (permalink / raw)
To: buildroot; +Cc: Martin Bark, Thomas Petazzoni, Daniel Price
On 05/11/23 15:24, Giulio Benetti wrote:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr>
--
Giulio Benetti
CEO&CTO@Benetti Engineering sas
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
>
> define NODEJS_SRC_INSTALL_STAGING_CMDS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
2023-11-05 14:27 ` Giulio Benetti
@ 2023-11-06 9:32 ` Yegor Yefremov via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Yegor Yefremov via buildroot @ 2023-11-06 9:32 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Daniel Price, Martin Bark, Thomas Petazzoni, buildroot
On Sun, Nov 5, 2023 at 3:28 PM Giulio Benetti
<giulio.benetti@benettiengineering.com> wrote:
>
> On 05/11/23 15:24, Giulio Benetti wrote:
> > At the moment check-bin-arch script finds NodeJS modules containing
> > prebuilt binaries for different architectures and build fails.
> > So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> > NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
> >
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Suggested-by: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> --
> Giulio Benetti
> CEO&CTO@Benetti Engineering sas
>
> > ---
> > package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> > index 6fb550f158..8f934202b0 100644
> > --- a/package/nodejs/nodejs-src/nodejs-src.mk
> > +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> > @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> > # help in diagnosing the problem.
> > $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> > endef
> > +
> > +# Exclude prebuilt binaries with different architectures and OS from check
> > +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> > endif
> >
> > define NODEJS_SRC_INSTALL_STAGING_CMDS
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
@ 2023-11-06 19:13 ` Marcus Hoffmann via buildroot
2023-11-07 21:39 ` Yann E. MORIN
2023-11-10 17:39 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Marcus Hoffmann via buildroot @ 2023-11-06 19:13 UTC (permalink / raw)
To: Giulio Benetti, buildroot; +Cc: Martin Bark, Thomas Petazzoni, Daniel Price
On 05.11.23 15:24, Giulio Benetti wrote:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
>
> define NODEJS_SRC_INSTALL_STAGING_CMDS
________________________________
othermo GmbH | Sitz der Gesellschaft: Alzenau | Amtsgericht Aschaffenburg: HRB 14783 | USt-IdNr.: DE319977978 | Geschäftsführung: Dr. Dennis Metz.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
2023-11-06 19:13 ` Marcus Hoffmann via buildroot
@ 2023-11-07 21:39 ` Yann E. MORIN
2023-11-10 17:39 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2023-11-07 21:39 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Daniel Price, Martin Bark, Thomas Petazzoni, buildroot
Giulio, All,
On 2023-11-05 15:24 +0100, Giulio Benetti spake thusly:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
I have extended the commit log drastically, to explain the situation is
more details, and why we decided to just ignore the issue.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
>
> define NODEJS_SRC_INSTALL_STAGING_CMDS
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
` (2 preceding siblings ...)
2023-11-07 21:39 ` Yann E. MORIN
@ 2023-11-10 17:39 ` Peter Korsgaard
3 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2023-11-10 17:39 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Daniel Price, Martin Bark, Thomas Petazzoni, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> At the moment check-bin-arch script finds NodeJS modules containing
> prebuilt binaries for different architectures and build fails.
> So let check-bin-arch to ignore folder /usr/lib/node_modules by setting
> NODEJS_SRC_BIN_ARCH_EXCLUDE to it.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/nodejs/nodejs-src/nodejs-src.mk | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/package/nodejs/nodejs-src/nodejs-src.mk b/package/nodejs/nodejs-src/nodejs-src.mk
> index 6fb550f158..8f934202b0 100644
> --- a/package/nodejs/nodejs-src/nodejs-src.mk
> +++ b/package/nodejs/nodejs-src/nodejs-src.mk
> @@ -244,6 +244,9 @@ define NODEJS_SRC_INSTALL_MODULES
> # help in diagnosing the problem.
> $(NPM) install -g $(NODEJS_SRC_MODULES_LIST)
> endef
> +
> +# Exclude prebuilt binaries with different architectures and OS from check
> +NODEJS_SRC_BIN_ARCH_EXCLUDE = /usr/lib/node_modules/
> endif
Committed to 2023.02.x and 2023.08.x (after moving it to the nodejs
package and adjusting the variable name to match), thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-10 17:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-05 14:24 [Buildroot] [PATCH] package/nodejs/nodejs-src: fix arch check on additional modules Giulio Benetti
2023-11-05 14:27 ` Giulio Benetti
2023-11-06 9:32 ` Yegor Yefremov via buildroot
2023-11-06 19:13 ` Marcus Hoffmann via buildroot
2023-11-07 21:39 ` Yann E. MORIN
2023-11-10 17:39 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox