Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Raphael Pavlidis <raphael.pavlidis@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH/next 02/13] package/dmenu-wayland: new package
Date: Thu, 23 Nov 2023 14:44:54 +0100	[thread overview]
Message-ID: <20231123144454.50fd7944@windsurf> (raw)
In-Reply-To: <20231123000819.488595-3-adam.duskett@amarulasolutions.com>

Hello Adam,

On Wed, 22 Nov 2023 17:08:08 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:

> diff --git a/package/dmenu-wayland/Config.in b/package/dmenu-wayland/Config.in
> new file mode 100644
> index 0000000000..111bbfb434
> --- /dev/null
> +++ b/package/dmenu-wayland/Config.in
> @@ -0,0 +1,26 @@
> +config BR2_PACKAGE_DMENU_WAYLAND
> +	bool "dmenu-wayland"
> +	depends on BR2_USE_MMU # pango -> lib2

lib2 ?

> +	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # pango -> harfbuzz
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> glib2, wayland
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # pango -> harfbuz
> +	depends on !BR2_STATIC_LIBS # wayland -> dlfcn.h
> +	depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype support
> +	depends on BR2_USE_WCHAR # pango -> glib2

I think listing the first order dependency is enough.

> +DMENU_WAYLAND_VERSION = a380201dff5bfac2dace553d7eaedb6cea6855f9
> +DMENU_WAYLAND_SITE = https://github.com/nyyManni/dmenu-wayland.git
> +DMENU_WAYLAND_SITE_METHOD = git

Use the github macro?

> +DMENU_WAYLAND_LICENSE = MIT
> +DMENU_WAYLAND_LICENSE_FILES = LICENSE
> +
> +DMENU_WAYLAND_DEPENDENCIES = \
> +	cairo \
> +	libglib2 \
> +	libxkbcommon \
> +	pango \
> +	wayland \
> +	wayland-protocols
> +
> +# By default, sway calls dmenu not dmenu-wl
> +define DMENU_WAYLAND_SYMLINK_DMENU_WL
> +	cd $(TARGET_DIR)/usr/bin && \
> +	ln -sf dmenu-wl dmenu

I think:

	ln -sf dmenu-wl $(TARGET_DIR)/usr/bin/dmenu

achieves the same.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-23 13:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23  0:08 [Buildroot] [PATCH 00/13] Sway fixups Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 01/13] package/sway/Config.in: select BR2_PACKAGE_XKEYBOARD_CONFIG Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 02/13] package/dmenu-wayland: new package Adam Duskett
2023-11-23 13:44   ` Thomas Petazzoni via buildroot [this message]
2023-11-23 19:12     ` Adam Duskett
2023-11-23 19:13       ` Adam Duskett
2023-11-24  8:43         ` Thomas Petazzoni via buildroot
2023-11-24  8:41       ` Thomas Petazzoni via buildroot
2023-11-23  0:08 ` [Buildroot] [PATCH/next 03/13] package/tllist: " Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 04/13] package/fcft: " Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 05/13] package/libutempter: " Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 06/13] package/foot: " Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 07/13] package/ncurses: install foot terminfo if foot is selected Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 08/13] package/sway: enable bash-completion support Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 09/13] package/sway: enable default-wallpaper support Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 10/13] package/sway: enable swaybar support Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 11/13] package/sway: enable swaybar tray support Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 12/13] package/sway: enable swaynag support Adam Duskett
2023-11-23  0:08 ` [Buildroot] [PATCH/next 13/13] package/sway/Config.in: Add a help note about the default terminal Adam Duskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231123144454.50fd7944@windsurf \
    --to=buildroot@buildroot.org \
    --cc=adam.duskett@amarulasolutions.com \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=raphael.pavlidis@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox