Re: [Buildroot] [PATCH 1/1] python-sip: fix compile error

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Ralf, All,

On 2023-11-27 22:14 +0100, Ralf Dragon spake thusly:
> thank you for your feedback. As you might have noticed, this is my
> first submission to buildroot and I had no contact so far to such
> a contribution process. So feedback is appreciated.

No worries, you did quite good!

>   Here, you'd want to explain why it now fails, so that we can assess
>   whether we need to backport the fix to maintainance branches.
> 
>   So, something along the lines of:
> 
>        siplib: fix build with python >= 3.11
> 
>        With python 3.11, the PyFrameObject structure members have been
>        removed from the public C API:
> 
>            [1]https://docs.python.org/3.11/whatsnew/3.11.html#whatsnew311-c-api-porting
>            [2]https://docs.python.org/3.11/whatsnew/3.11.html#pyframeobject-3-11-hiding
> 
>        So, use the proper object type that can store an actual
>        PyFrameObject.
> 
> Your description it is already quite good 🙂. I will check again.

Thanks, it would be good to be sure why the change is needed.

> I have to say, the patch checker command passed for me, but I was
> probably in the long-term branch at that time.

Usually, we run the tooling in our reference environment, which
utils/docker-run uses, so that you are sure to use the proper versions
of the checkers.

>   We also try hard to push patches upstream so that we do not have to
>   carry them indefinitely. Please try and submit that patch to the SIP
>   project:
>        [3]https://riverbankcomputing.com/support/lists
> 
> They write that siplib is no longer supported and that 4.19.25 is the last version:
> [4]https://riverbankcomputing.com/software/sip/download . That's why I did not consider asking there.

What I read is that version 4 is no longer maintained:

    SIP v4 is no longer supported. This is the last release.

The repository is still getting a lot of attention, and they tagged
6.7.12 last october, which is prestty recent. Also, it looks like it is
now a proper python package, so we should be able to migrate python-sip
to the python-package infra now, and drop our custom _CONFIGURE_CMDS,
_BUILD_CMDS, and _INSTLAL_CMDS altogether.

Of course, pyqt5, the sole user of python-sip, may still require sip v4,
which would preclude updating... :-(

Could you look into that?

>     +Index: host-python-sip-4.19.25/siplib/sip.h
>     +===================================================================
> 
>   What diff fornat is that? We usually have plain diff, or git-formatted
>   patches.
> 
> I think it is the output from "git diff" piped into the file.

The official repository is using mercurial, not git, and that does not
look like an hg diff either...

Regards,
Yann E. MORIN.

>   Can you look into reworking this patch of yours, please?
> 
> Will do.
> 
> Best,
> 
> Ralf
> 
> Links:
> 1. https://docs.python.org/3.11/whatsnew/3.11.html#whatsnew311-c-api-porting
> 2. https://docs.python.org/3.11/whatsnew/3.11.html#pyframeobject-3-11-hiding
> 3. https://riverbankcomputing.com/support/lists
> 4. https://riverbankcomputing.com/software/sip/download

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot