Re: [Buildroot] [PATCH 1/1] python-sip: fix compile error

[Ralf Dragon <hypnotoad@lindra.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --]

Dear Yann,

thank you for your feedback. As you might have noticed, this is my first 
submission to buildroot and I had no contact so far to such a 
contribution process. So feedback is appreciated.

> Here, you'd want to explain why it now fails, so that we can assess
> whether we need to backport the fix to maintainance branches.
>
> So, something along the lines of:
>
>      siplib: fix build with python >= 3.11
>
>      With python 3.11, the PyFrameObject structure members have been
>      removed from the public C API:
>
> https://docs.python.org/3.11/whatsnew/3.11.html#whatsnew311-c-api-porting
> https://docs.python.org/3.11/whatsnew/3.11.html#pyframeobject-3-11-hiding
>
>      So, use the proper object type that can store an actual
>      PyFrameObject.
>
Your description it is already quite good 🙂. I will check again. I have 
to say, the patch checker command passed for me, but I was probably in 
the long-term branch at that time.


> We also try hard to push patches upstream so that we do not have to
> carry them indefinitely. Please try and submit that patch to the SIP
> project:
> https://riverbankcomputing.com/support/lists

They write that siplib is no longer supported and that 4.19.25 is the 
last version: https://riverbankcomputing.com/software/sip/download . 
That's why I did not consider asking there.

>> +Index: host-python-sip-4.19.25/siplib/sip.h
>> +===================================================================
> What diff fornat is that? We usually have plain diff, or git-formatted
> patches.

I think it is the output from "git diff" piped into the file.

> Can you look into reworking this patch of yours, please?

Will do.

Best,

Ralf

[-- Attachment #1.2: Type: text/html, Size: 3599 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot