Re: [Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Fabrice, All,

On 2023-11-28 20:46 +0100, Fabrice Fontaine spake thusly:
[--SNIP--]
> So, as advised by Yann E. Morin, openrc is hided away for uClibc, until
> upstream has a proper fix.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  system/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index 0b4dc9543e..b90e40e415 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -105,12 +105,13 @@ config BR2_INIT_OPENRC
>  	bool "OpenRC"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_STATIC_LIBS
> +	depends on !BR2_TOOLCHAIN_BUILDROOT_UCLIBC

Err, no; the proper symbol is BR2_TOOLCHAIN_USES_UCLIBC:
    https://buildroot.org/downloads/manual/manual.html#dependencies-target-toolchain-options

Also, the dependency must be on the package itself. Indeed, the issue is
with the package, not with our use of init as an init system. So we need
the dependency on the package itself, and it is inherited in the init
system choice:

    config BR2_PACKAGE_OPENRC
        bool "openrc"
        depends on !BR2_TOOLCHAIN_USES_UCLIBC

and then:

    config BR2_INIT_OPENRC
        bool "openrc"
        depends on !BR2_TOOLCHAIN_USES_UCLIBC  # openrc

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_OPENRC
>  	select BR2_PACKAGE_SKELETON_INIT_OPENRC if BR2_ROOTFS_SKELETON_DEFAULT
>  
> -comment "openrc needs a toolchain w/ dynamic library"
> +comment "openrc needs a glibc or musl toolchain w/ dynamic library"
>  	depends on BR2_USE_MMU
> -	depends on BR2_STATIC_LIBS
> +	depends on BR2_STATIC_LIBS && BR2_TOOLCHAIN_BUILDROOT_UCLIBC
>  
>  # In Buildroot, we decided not to support a split-usr when systemd is
>  # used as an init system. This is a design decision, not a systemd
> -- 
> 2.42.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot