Re: [Buildroot] [PATCH 1/1] system/Config.in: disable openrc with uclibc

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > openrc raises the following uclibc build failures since bump to version
 > 0.51 in commit 730c90faa3ec13ee1ead47113c9c5c7d3a8dac55:

 > ../src/rc-abort/rc-abort.c: In function 'main':
 > ../src/rc-abort/rc-abort.c:27:21: error: implicit declaration of
 > function 'kill'; did you mean 'killpg'?
 > [-Werror=implicit-function-declaration]
 >    27 |                 if (kill(pid, SIGUSR1) != 0)
 >       |                     ^~~~
 >       |                     killpg

 > ../src/libeinfo/libeinfo.c: In function 'colour_terminal':
 > ../src/libeinfo/libeinfo.c:319:26: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration]
 >   319 |         if (f && !isatty(fileno(f)))
 >       |                          ^~~~~~

 > ../src/librc/librc-misc.c: In function 'rc_getfile':
 > ../src/librc/librc-misc.c:79:14: error: implicit declaration of
 > function 'fileno'; did you mean 'd_fileno'?
 > [-Werror=implicit-function-declaration]
 >    79 |         fd = fileno(fp);
 >       |              ^~~~~~
 >       |              d_fileno

 > ../src/librc/librc-daemon.c: In function 'rc_service_daemons_crashed':
 > ../src/librc/librc-daemon.c:633:37: error: implicit declaration of
 > function 'kill'; did you mean 'killpg'?
 > [-Werror=implicit-function-declaration]
 >   633 |                                 if (kill(pid, 0) == -1 && errno == ESRCH)
 >       |                                     ^~~~
 >       |                                     killpg

 > These build failures could be fixed by patching openrc but upstream
 > is not happy with this patch: https://github.com/OpenRC/openrc/pull/674.

 > So, as advised by Yann E. Morin, openrc is hided away for uClibc, until
 > upstream has a proper fix.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/494ef392a971ddb3c5c7b01e0149c6439018dbe7

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I was going to say that such things are normally fixed by defining
_GNU_SOURCE, E.G. we could do

OPENRC_CFLAGS=$(TARGET_CFLAGS) -D_GNU_SOURCE

But indeed, upstream doesn't seem very receptive - So lets drop uClibc
support.

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot